{"parents":["5aec1b2a8d1bcafb43a7ddb64dc37eacad081bea"],"commit":{"authorEmail":"sebastian.silbermann@vercel.com","authoredAt":"2026-01-13T16:00:16+01:00","authorName":"Sebastian \"Sebbie\" Silbermann","subject":"[test] Fix DevTools regression tests (#35501)","revision":"8a83073753125156d62db14726e8527706411962","shortRevision":"8a83073753"},"files":[{"path":"packages\/react-devtools-shared\/src\/__tests__\/store-test.js","status":"M"}],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\nindex c4fe7d337d..8c9beb1854 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\n@@ -7,7 +7,12 @@\n * @flow\n *\/\n \n+import semver from 'semver';\n+\n import {getVersionedRenderImplementation} from '.\/utils';\n+import {ReactVersion} from '..\/..\/..\/..\/ReactVersions';\n+\n+const ReactVersionTestingAgainst = process.env.REACT_VERSION || ReactVersion;\n \n describe('Store', () => {\n let React;\n@@ -3143,8 +3148,9 @@ describe('Store', () => {\n expect(store).toMatchInlineSnapshot(``);\n });\n \n- \/\/ @reactVersion >= 17.0\n- it('should track suspended by in filtered fallback', async () => {\n+ \/\/ Can't suspend the root in React 17.\n+ \/\/ @reactVersion >= 18.0\n+ it('should track suspended-by in filtered fallback suspending the root', async () => {\n function IgnoreMe({promise}) {\n return readValue(promise);\n }\n@@ -3196,6 +3202,91 @@ describe('Store', () => {\n `);\n });\n \n+ \/\/ @reactVersion >= 17.0\n+ it('should track suspended-by in filtered fallback', async () => {\n+ function IgnoreMe({promise}) {\n+ return readValue(promise);\n+ }\n+\n+ function Component({promise}) {\n+ if (promise) {\n+ return readValue(promise);\n+ }\n+ return null;\n+ }\n+\n+ await actAsync(\n+ async () =>\n+ (store.componentFilters = [createDisplayNameFilter('^IgnoreMe', true)]),\n+ );\n+\n+ let resolveFallback;\n+ const fallbackPromise = new Promise(resolve => {\n+ resolveFallback = resolve;\n+ });\n+ let resolveContent;\n+ const contentPromise = new Promise(resolve => {\n+ resolveContent = resolve;\n+ });\n+\n+ await actAsync(() =>\n+ render(\n+ }\n+ name=\"root\">\n+ }>\n+ \n+ <\/React.Suspense>\n+ <\/React.Suspense>,\n+ ),\n+ );\n+\n+ if (semver.lt(ReactVersionTestingAgainst, '18.0.0')) {\n+ \/\/ React 17 commits partial trees hidden which causes the \"main\"\n+ \/\/ Suspense boundary to be included.\n+ \/\/ React 18 and upwards excluded partial tree entirely.\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ ▾ \n+ \n+ [suspense-root] rects={null}\n+ \n+ \n+ `);\n+ } else {\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ ▾ \n+ \n+ [suspense-root] rects={null}\n+ \n+ `);\n+ }\n+\n+ await actAsync(() => resolveFallback('loading'));\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ ▾ \n+ \n+ [suspense-root] rects={null}\n+ \n+ \n+ `);\n+\n+ await actAsync(() => resolveContent('content'));\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ ▾ \n+ ▾ \n+ \n+ [suspense-root] rects={null}\n+ \n+ \n+ `);\n+ });\n+\n \/\/ @reactVersion >= 19\n it('should keep suspended boundaries in the Suspense tree but not hidden Activity', async () => {\n const Activity = React.Activity || React.unstable_Activity;\n","body":""}

dillon1000/react

Files changed