{"commit":{"shortRevision":"8af90c8972","subject":"Add test for nested avoided boundaries (#15636)","authoredAt":"2019-05-14T14:41:45-07:00","revision":"8af90c8972ab4cfc5fdbca8c576c202ce9cadab8","authorName":"Sebastian Markbåge","authorEmail":"sema@fb.com"},"parents":["af19e2eb2f8a849a11d2f5fa98d65d46087058e2"],"body":"* Add test for nested avoided boundaries\r\n\r\n* Add test for top level avoided boundaries","patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\nindex b74488faea..894f9d5553 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n@@ -1507,7 +1507,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n );\n });\n \n- it('shows the parent boundary if the inner boundary should be avoided', async () => {\n+ it('shows the parent fallback if the inner fallback should be avoided', async () => {\n function Foo({showC}) {\n Scheduler.yieldValue('Foo');\n return (\n@@ -1572,6 +1572,80 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n expect(ReactNoop.getChildren()).toEqual([span('A'), span('C'), span('B')]);\n });\n \n+ it('favors showing the inner fallback for nested top level avoided fallback', async () => {\n+ function Foo({showB}) {\n+ Scheduler.yieldValue('Foo');\n+ return (\n+ }>\n+ \n+ }>\n+ \n+ <\/Suspense>\n+ <\/Suspense>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushAndYield([\n+ 'Foo',\n+ 'A',\n+ 'Suspend! [B]',\n+ 'Loading B...',\n+ ]);\n+ \/\/ Flush to skip suspended time.\n+ Scheduler.advanceTime(600);\n+ await advanceTimers(600);\n+\n+ expect(ReactNoop.getChildren()).toEqual([span('A'), span('Loading B...')]);\n+ });\n+\n+ it('keeps showing an avoided parent fallback if it is already showing', async () => {\n+ function Foo({showB}) {\n+ Scheduler.yieldValue('Foo');\n+ return (\n+ }>\n+ }>\n+ \n+ {showB ? (\n+ }>\n+ \n+ <\/Suspense>\n+ ) : null}\n+ <\/Suspense>\n+ <\/Suspense>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushAndYield(['Foo', 'A']);\n+ expect(ReactNoop.getChildren()).toEqual([span('A')]);\n+\n+ ReactNoop.render();\n+\n+ expect(Scheduler).toFlushAndYield([\n+ 'Foo',\n+ 'A',\n+ 'Suspend! [B]',\n+ 'Loading B...',\n+ ]);\n+ \/\/ Still suspended.\n+ expect(ReactNoop.getChildren()).toEqual([span('A')]);\n+\n+ \/\/ Flush to skip suspended time.\n+ Scheduler.advanceTime(600);\n+ await advanceTimers(600);\n+\n+ expect(ReactNoop.getChildren()).toEqual([span('A'), span('Loading B...')]);\n+ });\n+\n it('commits a suspended idle pri render within a reasonable time', async () => {\n function Foo({something}) {\n return (\n","files":[{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js","status":"M"}]}

dillon1000/react

Files changed