dillon1000/react

Commit

Unify noop and test renderer assertion APIs (#14952)

* Throw in tests if work is done before emptying log

Test renderer already does this. Makes it harder to miss unexpected
behavior by forcing you to assert on every logged value.

* Convert ReactNoop tests to use jest matchers

The matchers warn if work is flushed while the log is empty. This is
the pattern we already follow for test renderer. I've used the same APIs
as test renderer, so it should be easy to switch between the two.
Browse files
Changed paths30 files
First-parent comparison
M packages/create-subscription/src/__tests__/createSubscription-test.internal.js ModifiedM packages/react-art/src/__tests__/ReactART-test.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/__tests__/ReactExpiration-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactFragment-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncremental-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorLogging-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalPerf-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalReflection-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalScheduling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalTriangle-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactMemo-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactNewContext-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactPersistent-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactTopLevelFragment-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactTopLevelText-test.js ModifiedM packages/react-reconciler/src/__tests__/__snapshots__/ReactIncrementalPerf-test.internal.js.snap ModifiedM packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/forwardRef-test.internal.js ModifiedM packages/react/src/__tests__/forwardRef-test.js ModifiedA scripts/jest/matchers/reactTestMatchers.js AddedM scripts/jest/setupTests.js ModifiedM scripts/jest/spec-equivalence-reporter/setupTests.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…