dillon1000/react
Commit
Browse files fix[devtools/ci]: fixed incorrect condition calculation for @reactVersion annotation (#26997)
Suppose that you have this setup for devtools test: ``` // @reactVersion <= 18.1 // @reactVersion >= 17.1 ``` With previous implementation, the accumulated condition will be `"<= 18.1" && ">= 17.1"`, which is just `">= 17.1"`, when evaluated. That's why we executed some tests for old versions of react on main (and failed). With these changes the resulting condition will be `"<= 18.1 >= 17.1"`, not using `&&`, because semver does not support this operator. All currently failing tests will be skipped now as expected. Also increased timeout value for shell server to start
Changed paths3 files
First-parent comparisonpackages/react-devtools-extensions/src/__tests__/xGoogleIgnoreList-test.js ModifiedM scripts/babel/transform-react-version-pragma.js ModifiedM scripts/circleci/run_devtools_e2e_tests.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…