dillon1000/react
Commit
Browse files refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime (#27215)
Fixes https://github.com/facebook/react/issues/27119, https://github.com/facebook/react/issues/27185. Fixed: - React DevTools now works as expected when user performs in-tab navigation, previously it was just stuck. https://github.com/facebook/react/assets/28902667/b11c5f84-7155-47a5-8b5a-7e90baca5347 - When user closes browser DevTools panel, we now do some cleanup to disconnect ports and emit shutdown event for bridge. This should fix the issue with registering duplicated fibers with the same id in Store. Changed: - We reconnect proxy port once in 25 seconds, in order to [keep service worker alive](https://developer.chrome.com/docs/extensions/whatsnew/#m110-sw-idle). - Instead of unregistering dynamically injected content scripts, wen now get list of already registered scripts and filter them out from scripts that we want to inject again, see dynamicallyInjectContentScripts.js. - Split `main.js` and `background.js` into multiple files. Tested on Chromium and Firefox browsers.
Changed paths22 files
First-parent comparisonpackages/react-devtools-extensions/firefox/manifest.json ModifiedD packages/react-devtools-extensions/src/background.js DeletedA packages/react-devtools-extensions/src/background/dynamicallyInjectContentScripts.js AddedA packages/react-devtools-extensions/src/background/index.js AddedA packages/react-devtools-extensions/src/background/injectProxy.js AddedA packages/react-devtools-extensions/src/background/setExtensionIconAndPopup.js AddedA packages/react-devtools-extensions/src/background/tabsManager.js AddedR packages/react-devtools-extensions/src/backendManager.js →packages/react-devtools-extensions/src/contentScripts/backendManager.js RenamedM packages/react-devtools-extensions/src/contentScripts/prepareInjection.js ModifiedM packages/react-devtools-extensions/src/contentScripts/proxy.js ModifiedD packages/react-devtools-extensions/src/main.js DeletedA packages/react-devtools-extensions/src/main/cloneStyleTags.js AddedA packages/react-devtools-extensions/src/main/elementSelection.js AddedA packages/react-devtools-extensions/src/main/getProfilingFlags.js AddedA packages/react-devtools-extensions/src/main/index.js AddedA packages/react-devtools-extensions/src/main/injectBackendManager.js AddedA packages/react-devtools-extensions/src/main/registerEventsLogger.js AddedA packages/react-devtools-extensions/src/main/requestAnimationFramePolyfill.js AddedA packages/react-devtools-extensions/src/main/syncSavedPreferences.js AddedM packages/react-devtools-extensions/webpack.config.js ModifiedM packages/react-devtools-shared/src/constants.js ModifiedM packages/react-devtools-shared/src/devtools/views/DevTools.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…