{"commit":{"subject":"Fixed focus styles for OwnersStack dropdown toggle button","authorEmail":"bvaughn@fb.com","authorName":"Brian Vaughn","revision":"91f74a513433a7060c3ff6de6f2df88efb4f12d0","shortRevision":"91f74a5134","authoredAt":"2019-04-21T08:59:24-07:00"},"body":"","parents":["09b995ab1cf7e7e5d031ffef5b1dcdcb664bd275"],"patch":"diff --git a\/src\/devtools\/views\/Components\/OwnersStack.css b\/src\/devtools\/views\/Components\/OwnersStack.css\nindex 443eadf54e..db2d946b83 100644\n--- a\/src\/devtools\/views\/Components\/OwnersStack.css\n+++ b\/src\/devtools\/views\/Components\/OwnersStack.css\n@@ -42,13 +42,19 @@\n border-radius: 0.25rem;\n display: inline-flex;\n align-items: center;\n- padding: 0.25rem;\n+ padding: 0;\n flex: 0 0 auto;\n border: none;\n background: var(--color-button-background);\n color: var(--color-button);\n margin-right: 0.5rem;\n }\n+.MenuButtonContent {\n+ display: inline-flex;\n+ align-items: center;\n+ border-radius: 0.25rem;\n+ padding: 0.25rem;\n+}\n .MenuButton:hover {\n color: var(--color-button-hover);\n }\n@@ -57,10 +63,14 @@\n color: var(--color-button-active);\n outline: none;\n }\n-.MenuButton:focus-within {\n- background: var(--color-button-background-focus);\n+\n+.MenuButton:focus,\n+.MenuButtonContent:focus {\n outline: none;\n }\n+.MenuButton:focus > .MenuButtonContent {\n+ background: var(--color-button-background-focus);\n+}\n \n .Modal[data-reach-menu-list] {\n display: inline-flex;\ndiff --git a\/src\/devtools\/views\/Components\/OwnersStack.js b\/src\/devtools\/views\/Components\/OwnersStack.js\nindex 6d909d3a70..860514fc78 100644\n--- a\/src\/devtools\/views\/Components\/OwnersStack.js\n+++ b\/src\/devtools\/views\/Components\/OwnersStack.js\n@@ -97,7 +97,9 @@ function ElementsDropdown({\n \n {\/* TODO (tooltips) *\/}\n \n- \n+ \n+ \n+ <\/span>\n <\/MenuButton>\n {\/* TODO (tooltips) <\/Tooltip> *\/}\n \n","files":[{"path":"src\/devtools\/views\/Components\/OwnersStack.css","status":"M"},{"path":"src\/devtools\/views\/Components\/OwnersStack.js","status":"M"}]}

dillon1000/react

Files changed