dillon1000/react

Commit

Avoid passing custom stacks to console.error (#18685)

* Detect double stacks in the new format in tests

* Remove unnecessary uses of getStackByFiberInDevAndProd

These all execute in the right execution context already.

* Set the debug fiber around the cases that don't have an execution context

* Remove stack detection in our console log overrides

We never pass custom stacks as part of the args anymore.

* Bonus: Don't append getStackAddendum to invariants

We print component stacks for every error anyway so this is just duplicate
information.
Browse files
Sebastian Markbåge authored 940f48b999a3131e77b2545bd7ae252ef27ae6d1 Parent ff431b7
Changed paths20 files
First-parent comparison
M packages/react-dom/src/__tests__/ReactComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactServerRendering-test.js ModifiedM packages/react-dom/src/shared/assertValidProps.js ModifiedM packages/react-dom/src/shared/sanitizeURL.js ModifiedM packages/react-reconciler/src/ReactChildFiber.new.js ModifiedM packages/react-reconciler/src/ReactChildFiber.old.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.new.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.old.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.new.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.old.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.new.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.old.js ModifiedM packages/react-reconciler/src/ReactStrictModeWarnings.new.js ModifiedM packages/react-reconciler/src/ReactStrictModeWarnings.old.js ModifiedM packages/react/src/ReactChildren.js ModifiedM packages/shared/consoleWithStackDev.js ModifiedM packages/shared/forks/consoleWithStackDev.www.js ModifiedM scripts/error-codes/codes.json ModifiedM scripts/jest/matchers/toWarnDev.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…