{"patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/DebugTracing-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/DebugTracing-test.internal.js\nindex 14960c3681..2df04c8c88 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/DebugTracing-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/DebugTracing-test.internal.js\n@@ -96,6 +96,45 @@ describe('DebugTracing', () => {\n expect(logs).toEqual(['log: ⚛️ Example resolved']);\n });\n \n+ \/\/ @gate experimental && build === 'development' && enableDebugTracing\n+ it('should log sync render with CPU suspense', () => {\n+ function Example() {\n+ console.log('');\n+ return null;\n+ }\n+\n+ function Wrapper({children}) {\n+ console.log('');\n+ return children;\n+ }\n+\n+ ReactTestRenderer.create(\n+ \n+ \n+ \n+ \n+ <\/React.Suspense>\n+ <\/Wrapper>\n+ <\/React.unstable_DebugTracingMode>,\n+ );\n+\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000000000000001)',\n+ 'log: ',\n+ 'groupEnd: ⚛️ render (0b0000000000000000000000000000001)',\n+ ]);\n+\n+ logs.splice(0);\n+\n+ expect(Scheduler).toFlushUntilNextPaint([]);\n+\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000010000000000000000000000000)',\n+ 'log: ',\n+ 'groupEnd: ⚛️ render (0b0000010000000000000000000000000)',\n+ ]);\n+ });\n+\n \/\/ @gate experimental && build === 'development' && enableDebugTracing\n it('should log concurrent render with suspense', async () => {\n const fakeSuspensePromise = Promise.resolve(true);\n@@ -130,6 +169,52 @@ describe('DebugTracing', () => {\n expect(logs).toEqual(['log: ⚛️ Example resolved']);\n });\n \n+ \/\/ @gate experimental && build === 'development' && enableDebugTracing\n+ it('should log concurrent render with CPU suspense', () => {\n+ function Example() {\n+ console.log('');\n+ return null;\n+ }\n+\n+ function Wrapper({children}) {\n+ console.log('');\n+ return children;\n+ }\n+\n+ ReactTestRenderer.create(\n+ \n+ \n+ \n+ \n+ <\/React.Suspense>\n+ <\/Wrapper>\n+ <\/React.unstable_DebugTracingMode>,\n+ {unstable_isConcurrent: true},\n+ );\n+\n+ expect(logs).toEqual([]);\n+\n+ logs.splice(0);\n+\n+ expect(Scheduler).toFlushUntilNextPaint([]);\n+\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000001000000000)',\n+ 'log: ',\n+ 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n+ ]);\n+\n+ logs.splice(0);\n+\n+ expect(Scheduler).toFlushUntilNextPaint([]);\n+\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000010000000000000000000000000)',\n+ 'log: ',\n+ 'groupEnd: ⚛️ render (0b0000010000000000000000000000000)',\n+ ]);\n+ });\n+\n \/\/ @gate experimental && build === 'development' && enableDebugTracing\n it('should log cascading class component updates', () => {\n class Example extends React.Component {\n@@ -191,12 +276,23 @@ describe('DebugTracing', () => {\n expect(Scheduler).toFlushUntilNextPaint([]);\n }).toErrorDev('Cannot update during an existing state transition');\n \n- expect(logs).toEqual([\n- 'group: ⚛️ render (0b0000000000000000000001000000000)',\n- 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n- 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n- 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n- ]);\n+ gate(flags => {\n+ if (flags.new) {\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000001000000000)',\n+ 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n+ ]);\n+ } else {\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n+ 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n+ ]);\n+ }\n+ });\n });\n \n \/\/ @gate experimental && build === 'development' && enableDebugTracing\n@@ -274,12 +370,24 @@ describe('DebugTracing', () => {\n {unstable_isConcurrent: true},\n );\n });\n- expect(logs).toEqual([\n- 'group: ⚛️ render (0b0000000000000000000001000000000)',\n- 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n- 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)', \/\/ debugRenderPhaseSideEffectsForStrictMode\n- 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n- ]);\n+\n+ gate(flags => {\n+ if (flags.new) {\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000001000000000)', \/\/ debugRenderPhaseSideEffectsForStrictMode\n+ 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n+ ]);\n+ } else {\n+ expect(logs).toEqual([\n+ 'group: ⚛️ render (0b0000000000000000000001000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)',\n+ 'log: ⚛️ Example updated state (0b0000000000000000000010000000000)', \/\/ debugRenderPhaseSideEffectsForStrictMode\n+ 'groupEnd: ⚛️ render (0b0000000000000000000001000000000)',\n+ ]);\n+ }\n+ });\n });\n \n \/\/ @gate experimental && build === 'development' && enableDebugTracing\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\nindex aa3cf1a64a..881a0e6101 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n@@ -25,7 +25,7 @@ export const enableEagerRootListeners = !__VARIANT__;\n \/\/ It logs information to the console about React scheduling, rendering, and commit phases.\n \/\/\n \/\/ NOTE: This feature will only work in DEV mode; all callsights are wrapped with __DEV__.\n-export const enableDebugTracing = false;\n+export const enableDebugTracing = __EXPERIMENTAL__;\n \n \/\/ This only has an effect in the new reconciler. But also, the new reconciler\n \/\/ is only enabled when __VARIANT__ is true. So this is set to the opposite of\n","commit":{"authorEmail":"bvaughn@fb.com","authoredAt":"2020-10-01T12:02:26-04:00","authorName":"Brian Vaughn","subject":"Debug tracing tests for CPU bound suspense (#19943)","revision":"97625272abe1fecc8ffba469795803ca8cfff9a7","shortRevision":"97625272ab"},"body":"","parents":["43363e2795393a00fd77312a16d6b80e626c29de"],"files":[{"path":"packages\/react-reconciler\/src\/__tests__\/DebugTracing-test.internal.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js","status":"M"}]}

dillon1000/react

Files changed