{"parents":["26297f5383f7e7150d9aa2cf12e8326c96991cab"],"files":[{"path":"packages\/react-client\/src\/__tests__\/ReactFlight-test.js","status":"M"}],"body":"","patch":"diff --git a\/packages\/react-client\/src\/__tests__\/ReactFlight-test.js b\/packages\/react-client\/src\/__tests__\/ReactFlight-test.js\nindex b248970539..980dbbf0e1 100644\n--- a\/packages\/react-client\/src\/__tests__\/ReactFlight-test.js\n+++ b\/packages\/react-client\/src\/__tests__\/ReactFlight-test.js\n@@ -1467,13 +1467,12 @@ describe('ReactFlight', () => {\n \n const transport = ReactNoopFlightServer.render();\n \n- await expect(async () => {\n- await act(() => {\n- startTransition(() => {\n- ReactNoop.render(ReactNoopFlightClient.read(transport));\n- });\n+ await act(() => {\n+ startTransition(() => {\n+ ReactNoop.render(ReactNoopFlightClient.read(transport));\n });\n- }).toErrorDev(\n+ });\n+ assertConsoleErrorDev([\n 'Each child in a list should have a unique \"key\" prop.\\n' +\n '\\n' +\n 'Check the render method of `Component`. See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n@@ -1483,7 +1482,7 @@ describe('ReactFlight', () => {\n ? ''\n : ' in Indirection (at **)\\n') +\n ' in App (at **)',\n- );\n+ ]);\n });\n \n it('should trigger the inner most error boundary inside a Client Component', async () => {\n@@ -1541,17 +1540,47 @@ describe('ReactFlight', () => {\n return 123;\n },\n };\n- expect(() => {\n- const transport = ReactNoopFlightServer.render();\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Objects with toJSON methods are not supported. ' +\n- 'Convert it manually to a simple value before passing it to props.\\n' +\n- ' \\n' +\n- ' ^^^^^^^^^^^^^^^',\n- {withoutStack: true},\n- );\n+ const transport = ReactNoopFlightServer.render();\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^^^^^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a toJSON instance is passed to a host component child', () => {\n@@ -1560,43 +1589,123 @@ describe('ReactFlight', () => {\n return 123;\n }\n }\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n-

Womp womp: {new MyError('spaghetti')}<\/div>,\n+ const transport = ReactNoopFlightServer.render(\n+

Womp womp: {new MyError('spaghetti')}<\/div>,\n+ );\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Error objects cannot be rendered as text children. Try formatting it using toString().\\n' +\n+ '

Womp womp: {Error}<\/div>\\n' +\n+ ' ^^^^^^^',\n+ ],\n+ {withoutStack: true},\n );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Error objects cannot be rendered as text children. Try formatting it using toString().\\n' +\n- '

Womp womp: {Error}<\/div>\\n' +\n- ' ^^^^^^^',\n- {withoutStack: true},\n- );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Error objects cannot be rendered as text children. Try formatting it using toString().\\n' +\n+ '

Womp womp: {Error}<\/div>\\n' +\n+ ' ^^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Error objects cannot be rendered as text children. Try formatting it using toString().\\n' +\n+ '

Womp womp: {Error}<\/div>\\n' +\n+ ' ^^^^^^^',\n+ 'Error objects cannot be rendered as text children. Try formatting it using toString().\\n' +\n+ '

Womp womp: {Error}<\/div>\\n' +\n+ ' ^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a special object is passed to a host component', () => {\n- expect(() => {\n- const transport = ReactNoopFlightServer.render();\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Math objects are not supported.\\n' +\n- ' \\n' +\n- ' ^^^^^^',\n- {withoutStack: true},\n- );\n+ const transport = ReactNoopFlightServer.render();\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if an object with symbols is passed to a host component', () => {\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n- ,\n+ const transport = ReactNoopFlightServer.render(\n+ ,\n+ );\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Objects with symbol properties like Symbol.iterator are not supported.',\n- {withoutStack: true},\n- );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' \\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a toJSON instance is passed to a Client Component', () => {\n@@ -1609,14 +1718,47 @@ describe('ReactFlight', () => {\n return

{value}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render();\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Objects with toJSON methods are not supported.',\n- {withoutStack: true},\n- );\n+ const transport = ReactNoopFlightServer.render();\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <... value={{toJSON: ...}}>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <... value={{toJSON: ...}}>\\n' +\n+ ' ^^^^^^^^^^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <... value={{toJSON: ...}}>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <... value={{toJSON: ...}}>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a toJSON instance is passed to a Client Component child', () => {\n@@ -1629,19 +1771,49 @@ describe('ReactFlight', () => {\n return

{children}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n- Current date: {obj}<\/Client>,\n+ const transport = ReactNoopFlightServer.render(\n+ Current date: {obj}<\/Client>,\n+ );\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <>Current date: {{toJSON: ...}}<\/>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Objects with toJSON methods are not supported. ' +\n- 'Convert it manually to a simple value before passing it to props.\\n' +\n- ' <>Current date: {{toJSON: ...}}<\/>\\n' +\n- ' ^^^^^^^^^^^^^^^',\n- {withoutStack: true},\n- );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <>Current date: {{toJSON: ...}}<\/>\\n' +\n+ ' ^^^^^^^^^^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <>Current date: {{toJSON: ...}}<\/>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with toJSON methods are not supported. ' +\n+ 'Convert it manually to a simple value before passing it to props.\\n' +\n+ ' <>Current date: {{toJSON: ...}}<\/>\\n' +\n+ ' ^^^^^^^^^^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a special object is passed to a Client Component', () => {\n@@ -1649,16 +1821,44 @@ describe('ReactFlight', () => {\n return

{value}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render();\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Math objects are not supported.\\n' +\n- ' <... value={Math}>\\n' +\n- ' ^^^^^^',\n- {withoutStack: true},\n- );\n+ const transport = ReactNoopFlightServer.render();\n+\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' <... value={Math}>\\n' +\n+ ' ^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' <... value={Math}>\\n' +\n+ ' ^^^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' <... value={Math}>\\n' +\n+ ' ^^^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' <... value={Math}>\\n' +\n+ ' ^^^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if an object with symbols is passed to a Client Component', () => {\n@@ -1666,16 +1866,46 @@ describe('ReactFlight', () => {\n return

{value}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n- ,\n+ assertConsoleErrorDev([]);\n+ const transport = ReactNoopFlightServer.render(\n+ ,\n+ );\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Objects with symbol properties like Symbol.iterator are not supported.',\n- {withoutStack: true},\n- );\n+ }\n+\n+ ReactNoopFlightClient.read(transport);\n+\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^\\n',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a special object is passed to a nested object in Client Component', () => {\n@@ -1683,18 +1913,41 @@ describe('ReactFlight', () => {\n return

{value}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n- hi<\/h1>}} \/>,\n- );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Math objects are not supported.\\n' +\n- ' {hello: Math, title: }\\n' +\n- ' ^^^^',\n- {withoutStack: true},\n+ const transport = ReactNoopFlightServer.render(\n+ ,\n );\n+ ReactNoopFlightClient.read(transport);\n+\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ {withoutStack: true},\n+ ],\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Objects with symbol properties like Symbol.iterator are not supported.\\n' +\n+ ' <... value={{}}>\\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should warn in DEV if a special object is passed to a nested array in Client Component', () => {\n@@ -1702,20 +1955,40 @@ describe('ReactFlight', () => {\n return

{value}<\/div>;\n }\n const Client = clientReference(ClientImpl);\n- expect(() => {\n- const transport = ReactNoopFlightServer.render(\n- hi<\/h1>]}\n- \/>,\n- );\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev(\n- 'Only plain objects can be passed to Client Components from Server Components. ' +\n- 'Math objects are not supported.\\n' +\n- ' [..., Math, ]\\n' +\n- ' ^^^^',\n- {withoutStack: true},\n+ const transport = ReactNoopFlightServer.render(\n+ hi<\/h1>]} \/>,\n );\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' [..., Math, ]\\n' +\n+ ' ^^^^',\n+ {withoutStack: true},\n+ ],\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' [..., Math, ]\\n' +\n+ ' ^^^^\\n' +\n+ ' at ()',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev(\n+ [\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' [..., Math, ]\\n' +\n+ ' ^^^^',\n+ 'Only plain objects can be passed to Client Components from Server Components. ' +\n+ 'Math objects are not supported.\\n' +\n+ ' [..., Math, ]\\n' +\n+ ' ^^^^',\n+ ],\n+ {withoutStack: true},\n+ );\n+ }\n });\n \n it('should NOT warn in DEV for key getters', () => {\n@@ -1729,63 +2002,100 @@ describe('ReactFlight', () => {\n key: \"this has a key but parent doesn't\",\n });\n }\n- expect(() => {\n- \/\/ While we're on the server we need to have the Server version active to track component stacks.\n- jest.resetModules();\n- jest.mock('react', () => ReactServer);\n- const transport = ReactNoopFlightServer.render(\n- ReactServer.createElement(\n- 'div',\n- null,\n- Array(6).fill(ReactServer.createElement(NoKey)),\n- ),\n- );\n- jest.resetModules();\n- jest.mock('react', () => React);\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev('Each child in a list should have a unique \"key\" prop.');\n+ \/\/ While we're on the server we need to have the Server version active to track component stacks.\n+ jest.resetModules();\n+ jest.mock('react', () => ReactServer);\n+ const transport = ReactNoopFlightServer.render(\n+ ReactServer.createElement(\n+ 'div',\n+ null,\n+ Array(6).fill(ReactServer.createElement(NoKey)),\n+ ),\n+ );\n+ jest.resetModules();\n+ jest.mock('react', () => React);\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in NoKey (at **)',\n+ 'Each child in a list should have a unique \"key\" prop. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in NoKey (at **)',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop.\\n\\n' +\n+ 'Check the top-level render call using

. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in NoKey (at **)',\n+ ]);\n+ }\n });\n \n \/\/ @gate !__DEV__ || enableOwnerStacks\n it('should warn in DEV a child is missing keys on a fragment', () => {\n- expect(() => {\n- \/\/ While we're on the server we need to have the Server version active to track component stacks.\n- jest.resetModules();\n- jest.mock('react', () => ReactServer);\n- const transport = ReactNoopFlightServer.render(\n- ReactServer.createElement(\n- 'div',\n- null,\n- Array(6).fill(ReactServer.createElement(ReactServer.Fragment)),\n- ),\n- );\n- jest.resetModules();\n- jest.mock('react', () => React);\n- ReactNoopFlightClient.read(transport);\n- }).toErrorDev('Each child in a list should have a unique \"key\" prop.');\n+ \/\/ While we're on the server we need to have the Server version active to track component stacks.\n+ jest.resetModules();\n+ jest.mock('react', () => ReactServer);\n+ const transport = ReactNoopFlightServer.render(\n+ ReactServer.createElement(\n+ 'div',\n+ null,\n+ Array(6).fill(ReactServer.createElement(ReactServer.Fragment)),\n+ ),\n+ );\n+ jest.resetModules();\n+ jest.mock('react', () => React);\n+ ReactNoopFlightClient.read(transport);\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in Fragment (at **)',\n+ 'Each child in a list should have a unique \"key\" prop. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in Fragment (at **)',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop.\\n\\n' +\n+ 'Check the top-level render call using

. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in Fragment (at **)',\n+ ]);\n+ }\n });\n \n it('should warn in DEV a child is missing keys in client component', async () => {\n function ParentClient({children}) {\n return children;\n }\n- const Parent = clientReference(ParentClient);\n- await expect(async () => {\n+\n+ await act(async () => {\n+ const Parent = clientReference(ParentClient);\n const transport = ReactNoopFlightServer.render(\n {Array(6).fill(

no key<\/div>)}<\/Parent>,\n );\n ReactNoopFlightClient.read(transport);\n- await act(async () => {\n- ReactNoop.render(await ReactNoopFlightClient.read(transport));\n- });\n- }).toErrorDev(\n- gate(flags => flags.enableOwnerStacks)\n- ? 'Each child in a list should have a unique \"key\" prop.' +\n- '\\n\\nCheck the top-level render call using . ' +\n- 'See https:\/\/react.dev\/link\/warning-keys for more information.'\n- : 'Each child in a list should have a unique \"key\" prop. ' +\n- 'See https:\/\/react.dev\/link\/warning-keys for more information.',\n- );\n+\n+ ReactNoop.render(await ReactNoopFlightClient.read(transport));\n+ });\n+ if (gate(flags => flags.enableOwnerStacks)) {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop.\\n\\n' +\n+ 'Check the top-level render call using . ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in div (at **)',\n+ ]);\n+ } else {\n+ assertConsoleErrorDev([\n+ 'Each child in a list should have a unique \"key\" prop. ' +\n+ 'See https:\/\/react.dev\/link\/warning-keys for more information.\\n' +\n+ ' in div (at **)',\n+ ]);\n+ }\n });\n \n it('should error if a class instance is passed to a host component', () => {\n@@ -3135,19 +3445,17 @@ describe('ReactFlight', () => {\n },\n );\n \n- let transport;\n- expect(() => {\n- \/\/ Reset the modules so that we get a new overridden console on top of the\n- \/\/ one installed by expect. This ensures that we still emit console.error\n- \/\/ calls.\n- jest.resetModules();\n- jest.mock('react', () => require('react\/react.react-server'));\n- ReactServer = require('react');\n- ReactNoopFlightServer = require('react-noop-renderer\/flight-server');\n- transport = ReactNoopFlightServer.render({\n- root: ReactServer.createElement(App),\n- });\n- }).toErrorDev('err');\n+ \/\/ Reset the modules so that we get a new overridden console on top of the\n+ \/\/ one installed by expect. This ensures that we still emit console.error\n+ \/\/ calls.\n+ jest.resetModules();\n+ jest.mock('react', () => require('react\/react.react-server'));\n+ ReactServer = require('react');\n+ ReactNoopFlightServer = require('react-noop-renderer\/flight-server');\n+ const transport = ReactNoopFlightServer.render({\n+ root: ReactServer.createElement(App),\n+ });\n+ assertConsoleErrorDev(['Error: err']);\n \n expect(mockConsoleLog).toHaveBeenCalledTimes(1);\n expect(mockConsoleLog.mock.calls[0][0]).toBe('hi');\n","commit":{"subject":"[assert helpers] ReactFlight (#31860)","shortRevision":"99471c02dd","revision":"99471c02dd6631df1892bf76d932afd22fffa5e3","authoredAt":"2024-12-20T12:41:30-05:00","authorName":"Ricky","authorEmail":"rickhanlonii@gmail.com"}}

dillon1000/react

Files changed