dillon1000/react

Commit

Remove the condition argument from warning() (#17568)

* prep for codemod

* prep warnings

* rename lint rules

* codemod for ifs

* shim www functions

* Handle more cases in the transform

* Thanks De Morgan

* Run the codemod

* Delete the transform

* Fix up confusing conditions manually

* Fix up www shims to match expected API

* Also check for low-pri warning in the lint rule
Browse files
Laura buns authored 9ac42dd074c42b66ecc0334b75200b1d2989f892 Parent 7bf40e1
Changed paths102 files
First-parent comparison
M .eslintrc.js ModifiedM packages/create-subscription/src/createSubscription.js ModifiedM packages/legacy-events/EventPluginUtils.js ModifiedM packages/legacy-events/EventPropagators.js ModifiedM packages/legacy-events/ResponderTouchHistoryStore.js ModifiedM packages/legacy-events/SyntheticEvent.js ModifiedM packages/react-cache/src/ReactCache.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMComponent.js ModifiedM packages/react-dom/src/client/ReactDOMInput.js ModifiedM packages/react-dom/src/client/ReactDOMLegacy.js ModifiedM packages/react-dom/src/client/ReactDOMOption.js ModifiedM packages/react-dom/src/client/ReactDOMRoot.js ModifiedM packages/react-dom/src/client/ReactDOMSelect.js ModifiedM packages/react-dom/src/client/ReactDOMTextarea.js ModifiedM packages/react-dom/src/client/setInnerHTML.js ModifiedM packages/react-dom/src/client/validateDOMNesting.js ModifiedM packages/react-dom/src/events/DOMEventResponderSystem.js ModifiedM packages/react-dom/src/events/SimpleEventPlugin.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js ModifiedM packages/react-dom/src/server/ReactPartialRendererContext.js ModifiedM packages/react-dom/src/server/ReactPartialRendererHooks.js ModifiedM packages/react-dom/src/shared/CSSPropertyOperations.js ModifiedM packages/react-dom/src/shared/DOMProperty.js ModifiedM packages/react-dom/src/shared/ReactDOMInvalidARIAHook.js ModifiedM packages/react-dom/src/shared/ReactDOMNullInputValuePropHook.js ModifiedM packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js ModifiedM packages/react-dom/src/shared/assertValidProps.js ModifiedM packages/react-dom/src/shared/sanitizeURL.js ModifiedM packages/react-dom/src/shared/warnValidStyle.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtilsAct.js ModifiedM packages/react-flight/src/ReactFlightClientHostConfig.js ModifiedM packages/react-interactions/events/src/dom/Press.js ModifiedM packages/react-interactions/events/src/dom/PressLegacy.js ModifiedM packages/react-is/src/ReactIs.js ModifiedM packages/react-native-renderer/src/NativeMethodsMixin.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactFabricEventResponderSystem.js ModifiedM packages/react-native-renderer/src/ReactFabricHostConfig.js ModifiedM packages/react-native-renderer/src/ReactNativeComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeEventEmitter.js ModifiedM packages/react-native-renderer/src/ReactNativeFiberHostComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/InitializeNativeFabricUIManager.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/ReactNativeViewConfigRegistry.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/UIManager.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/ReactFiber.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberContext.js ModifiedM packages/react-reconciler/src/ReactFiberDevToolsHook.js ModifiedM packages/react-reconciler/src/ReactFiberEvents.js ModifiedM packages/react-reconciler/src/ReactFiberHooks.js ModifiedM packages/react-reconciler/src/ReactFiberHostConfig.js ModifiedM packages/react-reconciler/src/ReactFiberHydrationContext.js ModifiedM packages/react-reconciler/src/ReactFiberNewContext.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberStack.js ModifiedM packages/react-reconciler/src/ReactFiberThrow.js ModifiedM packages/react-reconciler/src/ReactFiberTreeReflection.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-reconciler/src/ReactStrictModeWarnings.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.js ModifiedM packages/react-server/src/ReactServerFormatConfig.js ModifiedM packages/react-server/src/ReactServerHostConfig.js ModifiedM packages/react-test-renderer/src/ReactShallowRenderer.js ModifiedM packages/react-test-renderer/src/ReactTestHostConfig.js ModifiedM packages/react-test-renderer/src/ReactTestRendererAct.js ModifiedM packages/react/src/ReactBaseClasses.js ModifiedM packages/react/src/ReactChildren.js ModifiedM packages/react/src/ReactContext.js ModifiedM packages/react/src/ReactElement.js ModifiedM packages/react/src/ReactElementValidator.js ModifiedM packages/react/src/ReactHooks.js ModifiedM packages/react/src/ReactLazy.js ModifiedM packages/react/src/ReactNoopUpdateQueue.js ModifiedM packages/react/src/forwardRef.js ModifiedM packages/react/src/memo.js ModifiedM packages/shared/ReactLazyComponent.js ModifiedM packages/shared/enqueueTask.js ModifiedM packages/shared/forks/lowPriorityWarningWithoutStack.www.js ModifiedM packages/shared/forks/warningWithoutStack.www.js ModifiedM packages/shared/getComponentName.js ModifiedM packages/shared/lowPriorityWarning.js ModifiedM packages/shared/lowPriorityWarningWithoutStack.js ModifiedM packages/shared/warning.js ModifiedM packages/shared/warningWithoutStack.js ModifiedD scripts/babel/__tests__/lift-warning-conditional-argument-test.js DeletedD scripts/babel/lift-warning-conditional-argument.js DeletedR scripts/eslint-rules/__tests__/warning-and-invariant-args-test.internal.js →scripts/eslint-rules/__tests__/invariant-args-test.internal.js RenamedA scripts/eslint-rules/__tests__/warning-args-test.internal.js AddedM scripts/eslint-rules/index.js ModifiedR scripts/eslint-rules/warning-and-invariant-args.js →scripts/eslint-rules/invariant-args.js RenamedA scripts/eslint-rules/warning-args.js AddedM scripts/jest/preprocessor.js ModifiedM scripts/print-warnings/print-warnings.js ModifiedM scripts/rollup/build.js ModifiedM scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…