dillon1000/react

Commit

[react-dom] Remove `findDOMNode` from OSS builds (#28267)

In the next major `findDOMNode` is being removed. This PR removes the
API from the react-dom entrypoints for OSS builds and re-exposes the
implementation as part of internals.

`findDOMNode` is being retained for Meta builds and so all tests that
currently use it will continue to do so by accessing it from internals.
Once the replacement API ships in an upcoming minor any tests that were
using this API incidentally can be updated to use the new API and any
tests asserting `findDOMNode`'s behavior directly can stick around until
we remove it entirely (once Meta has moved away from it)
Browse files
Changed paths25 files
First-parent comparison
M packages/react-dom/index.experimental.js ModifiedM packages/react-dom/index.js ModifiedM packages/react-dom/index.stable.js ModifiedM packages/react-dom/src/ReactDOMSharedInternals.js ModifiedM packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOM-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMEventListener-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMLegacyFiber-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js ModifiedM packages/react-dom/src/__tests__/ReactEmptyComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyCompositeComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyUpdates-test.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/findDOMNode-test.js ModifiedM packages/react-dom/src/__tests__/react-dom-server-rendering-stub-test.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMLegacy.js ModifiedM packages/react-dom/unstable_testing.experimental.js ModifiedM packages/react-dom/unstable_testing.js ModifiedM packages/react-dom/unstable_testing.stable.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactJSXRuntime-test.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…