dillon1000/react

Commit

[Flight] Don't drop debug info if there's only a readable debug channel (#34304)

When the Flight Client is waiting for pending debug chunks, it drops the
debug info if there is no writable side of the debug channel defined.
However, it should instead check if there's no readable side defined.

Fixing this is not only important for browser clients that don't want or
need a return channel, but it's also crucial for server-side rendering,
because the Node and Edge clients only accept a readable side of the
debug channel. So they can't even define a noop writable side as a
workaround.
Browse files
Changed paths18 files
First-parent comparison
M packages/react-client/src/ReactFlightClient.js ModifiedM packages/react-server-dom-esm/src/client/ReactFlightDOMClientBrowser.js ModifiedM packages/react-server-dom-esm/src/client/ReactFlightDOMClientNode.js ModifiedM packages/react-server-dom-parcel/src/client/ReactFlightDOMClientBrowser.js ModifiedM packages/react-server-dom-parcel/src/client/ReactFlightDOMClientEdge.js ModifiedM packages/react-server-dom-parcel/src/client/ReactFlightDOMClientNode.js ModifiedM packages/react-server-dom-turbopack/src/__tests__/ReactFlightTurbopackDOMBrowser-test.js ModifiedM packages/react-server-dom-turbopack/src/__tests__/ReactFlightTurbopackDOMEdge-test.js ModifiedM packages/react-server-dom-turbopack/src/__tests__/ReactFlightTurbopackDOMNode-test.js ModifiedM packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientBrowser.js ModifiedM packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientEdge.js ModifiedM packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientNode.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMEdge-test.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMNode-test.js ModifiedM packages/react-server-dom-webpack/src/client/ReactFlightDOMClientBrowser.js ModifiedM packages/react-server-dom-webpack/src/client/ReactFlightDOMClientEdge.js ModifiedM packages/react-server-dom-webpack/src/client/ReactFlightDOMClientNode.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…