{"body":"","parents":["6ff733873c662086f919baced2bb80fcffc1b343"],"patch":"diff --git a\/vendor\/react-window\/dist\/index.esm.js b\/vendor\/react-window\/dist\/index.esm.js\nindex c1c2fab71a..19b1884d12 100644\n--- a\/vendor\/react-window\/dist\/index.esm.js\n+++ b\/vendor\/react-window\/dist\/index.esm.js\n@@ -3,6 +3,7 @@ import _inheritsLoose from '@babel\/runtime\/helpers\/esm\/inheritsLoose';\n import _assertThisInitialized from '@babel\/runtime\/helpers\/esm\/assertThisInitialized';\n import memoizeOne from 'memoize-one';\n import { createElement, PureComponent } from 'react';\n+import { flushSync } from 'react-dom';\n import _objectWithoutPropertiesLoose from '@babel\/runtime\/helpers\/esm\/objectWithoutPropertiesLoose';\n \n \/\/ Animation frame based implementation of setTimeout.\n@@ -182,37 +183,40 @@ function createGridComponent(_ref2) {\n scrollTop = _event$currentTarget.scrollTop,\n scrollWidth = _event$currentTarget.scrollWidth;\n \n- _this.setState(function (prevState) {\n- if (prevState.scrollLeft === scrollLeft && prevState.scrollTop === scrollTop) {\n- \/\/ Scroll position may have been updated by cDM\/cDU,\n- \/\/ In which case we don't need to trigger another render,\n- \/\/ And we don't want to update state.isScrolling.\n- return null;\n- }\n+ \/\/ Force flush sync for scroll updates to reduce visual checkerboarding.\n+ flushSync(() => {\n+ _this.setState(function (prevState) {\n+ if (prevState.scrollLeft === scrollLeft && prevState.scrollTop === scrollTop) {\n+ \/\/ Scroll position may have been updated by cDM\/cDU,\n+ \/\/ In which case we don't need to trigger another render,\n+ \/\/ And we don't want to update state.isScrolling.\n+ return null;\n+ }\n \n- var direction = _this.props.direction; \/\/ HACK According to the spec, scrollLeft should be negative for RTL aligned elements.\n- \/\/ Chrome does not seem to adhere; its scrollLeft values are positive (measured relative to the left).\n- \/\/ See https:\/\/developer.mozilla.org\/en-US\/docs\/Web\/API\/Element\/scrollLeft\n+ var direction = _this.props.direction; \/\/ HACK According to the spec, scrollLeft should be negative for RTL aligned elements.\n+ \/\/ Chrome does not seem to adhere; its scrollLeft values are positive (measured relative to the left).\n+ \/\/ See https:\/\/developer.mozilla.org\/en-US\/docs\/Web\/API\/Element\/scrollLeft\n \n- var calculatedScrollLeft = scrollLeft;\n+ var calculatedScrollLeft = scrollLeft;\n \n- if (direction === 'rtl') {\n- if (scrollLeft <= 0) {\n- calculatedScrollLeft = -scrollLeft;\n- } else {\n- calculatedScrollLeft = scrollWidth - clientWidth - scrollLeft;\n+ if (direction === 'rtl') {\n+ if (scrollLeft <= 0) {\n+ calculatedScrollLeft = -scrollLeft;\n+ } else {\n+ calculatedScrollLeft = scrollWidth - clientWidth - scrollLeft;\n+ }\n }\n- }\n \n- return {\n- isScrolling: true,\n- horizontalScrollDirection: prevState.scrollLeft < scrollLeft ? 'forward' : 'backward',\n- scrollLeft: calculatedScrollLeft,\n- scrollTop: scrollTop,\n- verticalScrollDirection: prevState.scrollTop < scrollTop ? 'forward' : 'backward',\n- scrollUpdateWasRequested: false\n- };\n- }, _this._resetIsScrollingDebounced);\n+ return {\n+ isScrolling: true,\n+ horizontalScrollDirection: prevState.scrollLeft < scrollLeft ? 'forward' : 'backward',\n+ scrollLeft: calculatedScrollLeft,\n+ scrollTop: scrollTop,\n+ verticalScrollDirection: prevState.scrollTop < scrollTop ? 'forward' : 'backward',\n+ scrollUpdateWasRequested: false\n+ };\n+ }, _this._resetIsScrollingDebounced);\n+ });\n };\n \n _this._outerRefSetter = function (ref) {\n@@ -1023,55 +1027,61 @@ function createListComponent(_ref) {\n scrollLeft = _event$currentTarget.scrollLeft,\n scrollWidth = _event$currentTarget.scrollWidth;\n \n- _this.setState(function (prevState) {\n- if (prevState.scrollOffset === scrollLeft) {\n- \/\/ Scroll position may have been updated by cDM\/cDU,\n- \/\/ In which case we don't need to trigger another render,\n- \/\/ And we don't want to update state.isScrolling.\n- return null;\n- }\n+ \/\/ Force flush sync for scroll updates to reduce visual checkerboarding.\n+ flushSync(() => {\n+ _this.setState(function (prevState) {\n+ if (prevState.scrollOffset === scrollLeft) {\n+ \/\/ Scroll position may have been updated by cDM\/cDU,\n+ \/\/ In which case we don't need to trigger another render,\n+ \/\/ And we don't want to update state.isScrolling.\n+ return null;\n+ }\n \n- var direction = _this.props.direction; \/\/ HACK According to the spec, scrollLeft should be negative for RTL aligned elements.\n- \/\/ Chrome does not seem to adhere; its scrolLeft values are positive (measured relative to the left).\n- \/\/ See https:\/\/developer.mozilla.org\/en-US\/docs\/Web\/API\/Element\/scrollLeft\n+ var direction = _this.props.direction; \/\/ HACK According to the spec, scrollLeft should be negative for RTL aligned elements.\n+ \/\/ Chrome does not seem to adhere; its scrolLeft values are positive (measured relative to the left).\n+ \/\/ See https:\/\/developer.mozilla.org\/en-US\/docs\/Web\/API\/Element\/scrollLeft\n \n- var scrollOffset = scrollLeft;\n+ var scrollOffset = scrollLeft;\n \n- if (direction === 'rtl') {\n- if (scrollLeft <= 0) {\n- scrollOffset = -scrollOffset;\n- } else {\n- scrollOffset = scrollWidth - clientWidth - scrollLeft;\n+ if (direction === 'rtl') {\n+ if (scrollLeft <= 0) {\n+ scrollOffset = -scrollOffset;\n+ } else {\n+ scrollOffset = scrollWidth - clientWidth - scrollLeft;\n+ }\n }\n- }\n \n- return {\n- isScrolling: true,\n- scrollDirection: prevState.scrollOffset < scrollLeft ? 'forward' : 'backward',\n- scrollOffset: scrollOffset,\n- scrollUpdateWasRequested: false\n- };\n- }, _this._resetIsScrollingDebounced);\n+ return {\n+ isScrolling: true,\n+ scrollDirection: prevState.scrollOffset < scrollLeft ? 'forward' : 'backward',\n+ scrollOffset: scrollOffset,\n+ scrollUpdateWasRequested: false\n+ };\n+ }, _this._resetIsScrollingDebounced);\n+ });\n };\n \n _this._onScrollVertical = function (event) {\n var scrollTop = event.currentTarget.scrollTop;\n \n- _this.setState(function (prevState) {\n- if (prevState.scrollOffset === scrollTop) {\n- \/\/ Scroll position may have been updated by cDM\/cDU,\n- \/\/ In which case we don't need to trigger another render,\n- \/\/ And we don't want to update state.isScrolling.\n- return null;\n- }\n+ \/\/ Force flush sync for scroll updates to reduce visual checkerboarding.\n+ flushSync(() => {\n+ _this.setState(function (prevState) {\n+ if (prevState.scrollOffset === scrollTop) {\n+ \/\/ Scroll position may have been updated by cDM\/cDU,\n+ \/\/ In which case we don't need to trigger another render,\n+ \/\/ And we don't want to update state.isScrolling.\n+ return null;\n+ }\n \n- return {\n- isScrolling: true,\n- scrollDirection: prevState.scrollOffset < scrollTop ? 'forward' : 'backward',\n- scrollOffset: scrollTop,\n- scrollUpdateWasRequested: false\n- };\n- }, _this._resetIsScrollingDebounced);\n+ return {\n+ isScrolling: true,\n+ scrollDirection: prevState.scrollOffset < scrollTop ? 'forward' : 'backward',\n+ scrollOffset: scrollTop,\n+ scrollUpdateWasRequested: false\n+ };\n+ }, _this._resetIsScrollingDebounced);\n+ });\n };\n \n _this._outerRefSetter = function (ref) {\n","files":[{"status":"M","path":"vendor\/react-window\/dist\/index.esm.js"}],"commit":{"subject":"react-window sync flushes scroll updates","authorName":"Brian Vaughn","shortRevision":"9d90189ee3","revision":"9d90189ee3129f3a6169fb510ca33bcf69fd200c","authorEmail":"bvaughn@fb.com","authoredAt":"2019-06-05T14:30:43-07:00"}}

dillon1000/react

Files changed