dillon1000/react

Commit

Revert "Bugfix: Expiring a partially completed tree (#17926)" (#17941)

This reverts commit 01974a867c543fca6ebe9f4e612dcc3bb8f80528.

* Failing test: Expiring a partially completed tree

We should not throw out a partially completed tree if it expires in the
middle of rendering. We should finish the rest of the tree without
yielding, then finish any remaining expired levels in a single batch.

* Check if there's a partial tree before restarting

If a partial render expires, we should stay in the concurrent path
(performConcurrentWorkOnRoot); we'll stop yielding, but the rest of the
behavior remains the same.

We will only revert to the sync path (performSyncWorkOnRoot) when
starting on a new level.

This approach prevents partially completed concurrent work from
being discarded.

* New test: retry after error during expired render
Browse files
Changed paths3 files
First-parent comparison
M packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…