dillon1000/react

Commit

Visit terminal ids before terminal branches

This is a follow-up to merging ranges. I realized that we need to mark terminal 
ids as visited _before_ processing the branches of that terminal (whereas before 
we were marking terminal ids only _after_ processing the branches). That exposed 
another bug where interleaving could fail to be detected (with an error, 
thankfully) if one of the branches had completed already. 

Our small test suite is already really good!
Browse files
Joe Savona authored a0054a18371a5aa1a69a1132f420d69f3c373957 Parent d2e5c31
Changed paths10 files
First-parent comparison
M compiler/forget/src/HIR/Codegen.ts ModifiedM compiler/forget/src/HIR/HIRTreeVisitor.ts ModifiedM compiler/forget/src/HIR/InferReactiveScopes.ts ModifiedM compiler/forget/src/HIR/PrintHIRTree.ts ModifiedM compiler/forget/src/__tests__/fixtures/hir/conditional-on-mutable.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/hir/conditional-on-mutable.js ModifiedM compiler/forget/src/__tests__/fixtures/hir/reassignment-separate-scopes.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/hir/reverse-postorder.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/hir/ssa-simple-phi.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/hir/ssa-switch.expect.md Modified
Patch

Files changed

Rendering syntax-highlighted changes…