dillon1000/react

Commit

warn if you try to use act() in prod (#16282)

We have behaviour divergence for act() between prod and dev (specifically, act() + concurrent mode does not flush fallbacks in prod. This doesn't affect anyone in OSS yet)

We also don't have a good story for writing tests in prod (and what from what I gather, nobody really writes tests in prod mode).

We could have wiped out act() in prod builds, except that _we_ ourselves use act() for our tests when we run them in prod mode.

This PR is a compromise to all of this. We will log a warning if you try to use act() in prod mode, and we silence it in our test suites.
Browse files
Sunil Pai authored a1dbb852c29d23d5d0b76a0171eb59df4bebf684 Parent dc232e6
Changed paths5 files
First-parent comparison
M packages/react-dom/src/__tests__/ReactTestUtilsAct-test.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtilsAct.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-test-renderer/src/ReactTestRendererAct.js ModifiedM scripts/jest/shouldIgnoreConsoleError.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…