{"commit":{"revision":"a22880e5e59d5cb17fffe04af093ea54e356538d","subject":"Add support for Suspense & lazy() to the react-is package (#14423)","authorName":"Pleun Vanderbauwhede","authorEmail":"pleun.vdb@gmail.com","shortRevision":"a22880e5e5","authoredAt":"2018-12-12T19:56:52+01:00"},"body":"* Add support for lazy & Suspense to react-is","patch":"diff --git a\/packages\/react-is\/src\/ReactIs.js b\/packages\/react-is\/src\/ReactIs.js\nindex e69486610c..c618f621d9 100644\n--- a\/packages\/react-is\/src\/ReactIs.js\n+++ b\/packages\/react-is\/src\/ReactIs.js\n@@ -16,11 +16,13 @@ import {\n REACT_ELEMENT_TYPE,\n REACT_FORWARD_REF_TYPE,\n REACT_FRAGMENT_TYPE,\n+ REACT_LAZY_TYPE,\n REACT_MEMO_TYPE,\n REACT_PORTAL_TYPE,\n REACT_PROFILER_TYPE,\n REACT_PROVIDER_TYPE,\n REACT_STRICT_MODE_TYPE,\n+ REACT_SUSPENSE_TYPE,\n } from 'shared\/ReactSymbols';\n import isValidElementType from 'shared\/isValidElementType';\n import lowPriorityWarning from 'shared\/lowPriorityWarning';\n@@ -38,6 +40,7 @@ export function typeOf(object: any) {\n case REACT_FRAGMENT_TYPE:\n case REACT_PROFILER_TYPE:\n case REACT_STRICT_MODE_TYPE:\n+ case REACT_SUSPENSE_TYPE:\n return type;\n default:\n const $$typeofType = type && type.$$typeof;\n@@ -51,6 +54,7 @@ export function typeOf(object: any) {\n return $$typeof;\n }\n }\n+ case REACT_LAZY_TYPE:\n case REACT_MEMO_TYPE:\n case REACT_PORTAL_TYPE:\n return $$typeof;\n@@ -68,10 +72,12 @@ export const ContextProvider = REACT_PROVIDER_TYPE;\n export const Element = REACT_ELEMENT_TYPE;\n export const ForwardRef = REACT_FORWARD_REF_TYPE;\n export const Fragment = REACT_FRAGMENT_TYPE;\n-export const Profiler = REACT_PROFILER_TYPE;\n-export const Portal = REACT_PORTAL_TYPE;\n+export const Lazy = REACT_LAZY_TYPE;\n export const Memo = REACT_MEMO_TYPE;\n+export const Portal = REACT_PORTAL_TYPE;\n+export const Profiler = REACT_PROFILER_TYPE;\n export const StrictMode = REACT_STRICT_MODE_TYPE;\n+export const Suspense = REACT_SUSPENSE_TYPE;\n \n export {isValidElementType};\n \n@@ -114,8 +120,8 @@ export function isForwardRef(object: any) {\n export function isFragment(object: any) {\n return typeOf(object) === REACT_FRAGMENT_TYPE;\n }\n-export function isProfiler(object: any) {\n- return typeOf(object) === REACT_PROFILER_TYPE;\n+export function isLazy(object: any) {\n+ return typeOf(object) === REACT_LAZY_TYPE;\n }\n export function isMemo(object: any) {\n return typeOf(object) === REACT_MEMO_TYPE;\n@@ -123,6 +129,12 @@ export function isMemo(object: any) {\n export function isPortal(object: any) {\n return typeOf(object) === REACT_PORTAL_TYPE;\n }\n+export function isProfiler(object: any) {\n+ return typeOf(object) === REACT_PROFILER_TYPE;\n+}\n export function isStrictMode(object: any) {\n return typeOf(object) === REACT_STRICT_MODE_TYPE;\n }\n+export function isSuspense(object: any) {\n+ return typeOf(object) === REACT_SUSPENSE_TYPE;\n+}\ndiff --git a\/packages\/react-is\/src\/__tests__\/ReactIs-test.js b\/packages\/react-is\/src\/__tests__\/ReactIs-test.js\nindex aeb1805d2f..9838096d3a 100644\n--- a\/packages\/react-is\/src\/__tests__\/ReactIs-test.js\n+++ b\/packages\/react-is\/src\/__tests__\/ReactIs-test.js\n@@ -39,17 +39,19 @@ describe('ReactIs', () => {\n }\n \n const FunctionComponent = () => React.createElement('div');\n-\n const ForwardRefComponent = React.forwardRef((props, ref) =>\n React.createElement(Component, {forwardedRef: ref, ...props}),\n );\n-\n+ const LazyComponent = React.lazy(() => Component);\n+ const MemoComponent = React.memo(Component);\n const Context = React.createContext(false);\n \n expect(ReactIs.isValidElementType('div')).toEqual(true);\n expect(ReactIs.isValidElementType(Component)).toEqual(true);\n expect(ReactIs.isValidElementType(FunctionComponent)).toEqual(true);\n expect(ReactIs.isValidElementType(ForwardRefComponent)).toEqual(true);\n+ expect(ReactIs.isValidElementType(LazyComponent)).toEqual(true);\n+ expect(ReactIs.isValidElementType(MemoComponent)).toEqual(true);\n expect(ReactIs.isValidElementType(Context.Provider)).toEqual(true);\n expect(ReactIs.isValidElementType(Context.Consumer)).toEqual(true);\n expect(ReactIs.isValidElementType(React.createFactory('div'))).toEqual(\n@@ -60,6 +62,7 @@ describe('ReactIs', () => {\n true,\n );\n expect(ReactIs.isValidElementType(React.StrictMode)).toEqual(true);\n+ expect(ReactIs.isValidElementType(React.Suspense)).toEqual(true);\n \n expect(ReactIs.isValidElementType(true)).toEqual(false);\n expect(ReactIs.isValidElementType(123)).toEqual(false);\n@@ -116,6 +119,7 @@ describe('ReactIs', () => {\n expect(ReactIs.isElement()).toBe(true);\n expect(ReactIs.isElement()).toBe(true);\n expect(ReactIs.isElement()).toBe(true);\n+ expect(ReactIs.isElement()).toBe(true);\n });\n \n it('should identify ref forwarding component', () => {\n@@ -152,6 +156,14 @@ describe('ReactIs', () => {\n expect(ReactIs.isMemo(Component)).toBe(false);\n });\n \n+ it('should identify lazy', () => {\n+ const Component = () => React.createElement('div');\n+ const lazyComponent = React.lazy(() => Component);\n+ expect(ReactIs.typeOf(lazyComponent)).toBe(ReactIs.Lazy);\n+ expect(ReactIs.isLazy(lazyComponent)).toBe(true);\n+ expect(ReactIs.isLazy(Component)).toBe(false);\n+ });\n+\n it('should identify strict mode', () => {\n expect(ReactIs.typeOf()).toBe(ReactIs.StrictMode);\n expect(ReactIs.isStrictMode()).toBe(true);\n@@ -160,6 +172,14 @@ describe('ReactIs', () => {\n expect(ReactIs.isStrictMode(

)).toBe(false);\n });\n \n+ it('should identify suspense', () => {\n+ expect(ReactIs.typeOf()).toBe(ReactIs.Suspense);\n+ expect(ReactIs.isSuspense()).toBe(true);\n+ expect(ReactIs.isSuspense({type: ReactIs.Suspense})).toBe(false);\n+ expect(ReactIs.isSuspense('React.Suspense')).toBe(false);\n+ expect(ReactIs.isSuspense(

)).toBe(false);\n+ });\n+\n it('should identify profile root', () => {\n expect(\n ReactIs.typeOf(),\n","parents":["947bddd5cf94b185166d51f8d36873492b5bd57c"],"files":[{"status":"M","path":"packages\/react-is\/src\/ReactIs.js"},{"status":"M","path":"packages\/react-is\/src\/__tests__\/ReactIs-test.js"}]}

dillon1000/react

Files changed