{"body":"We mostly do this but not 100%; I fixed the stragglers here with `.\/node_modules\/.bin\/eslint --fix src` and enabled the lint rule.","files":[{"path":".eslintrc.js","status":"M"},{"path":"src\/addons\/transitions\/__tests__\/ReactCSSTransitionGroup-test.js","status":"M"},{"path":"src\/addons\/transitions\/__tests__\/ReactTransitionGroup-test.js","status":"M"},{"path":"src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js","status":"M"},{"path":"src\/isomorphic\/classic\/element\/__tests__\/ReactElement-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/ReactComponent-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/ReactComponentLifeCycle-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/ReactCompositeComponent-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/ReactMultiChild-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/refs-destruction-test.js","status":"M"},{"path":"src\/renderers\/__tests__\/refs-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/CSSPropertyOperations-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/ReactDOM-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/ReactDOMComponent-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/ReactDOMTextComponent-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/ReactServerRendering-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/__tests__\/findDOMNode-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/eventPlugins\/__tests__\/ChangeEventPlugin-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/wrappers\/__tests__\/ReactDOMInput-test.js","status":"M"},{"path":"src\/renderers\/dom\/shared\/wrappers\/__tests__\/ReactDOMSelect-test.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/__tests__\/ReactIncrementalErrorHandling-test.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/__tests__\/ReactIncrementalSideEffects-test.js","status":"M"}],"parents":["e35724a03d66bb73dbbec4dc4b12a5170bfe2615"],"patch":"diff --git a\/.eslintrc.js b\/.eslintrc.js\nindex 9cc7d1d024..fda855f401 100644\n--- a\/.eslintrc.js\n+++ b\/.eslintrc.js\n@@ -43,6 +43,7 @@ module.exports = {\n 'react\/jsx-no-undef': ERROR,\n \/\/ We don't care to do this\n 'react\/jsx-sort-prop-types': OFF,\n+ 'react\/jsx-space-before-closing': ERROR,\n 'react\/jsx-uses-react': ERROR,\n 'react\/no-is-mounted': OFF,\n \/\/ This isn't useful in our test code\ndiff --git a\/src\/addons\/transitions\/__tests__\/ReactCSSTransitionGroup-test.js b\/src\/addons\/transitions\/__tests__\/ReactCSSTransitionGroup-test.js\nindex 6f52435d82..858fb46fdf 100644\n--- a\/src\/addons\/transitions\/__tests__\/ReactCSSTransitionGroup-test.js\n+++ b\/src\/addons\/transitions\/__tests__\/ReactCSSTransitionGroup-test.js\n@@ -283,8 +283,8 @@ describe('ReactCSSTransitionGroup', () => {\n }\n }\n \n- ReactDOM.render(, container);\n- ReactDOM.render(<\/Component>, container);\n+ ReactDOM.render(, container);\n+ ReactDOM.render(<\/Component>, container);\n \n ReactDOM.unmountComponentAtNode(container);\n \n@@ -322,7 +322,7 @@ describe('ReactCSSTransitionGroup', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ ReactDOM.render(, container);\n \n \/\/ Testing that no exception is thrown here, as the timeout has been cleared.\n jest.runAllTimers();\ndiff --git a\/src\/addons\/transitions\/__tests__\/ReactTransitionGroup-test.js b\/src\/addons\/transitions\/__tests__\/ReactTransitionGroup-test.js\nindex 14d1713917..248a5e08b2 100644\n--- a\/src\/addons\/transitions\/__tests__\/ReactTransitionGroup-test.js\n+++ b\/src\/addons\/transitions\/__tests__\/ReactTransitionGroup-test.js\n@@ -297,7 +297,7 @@ describe('ReactTransitionGroup', () => {\n \n class Component extends React.Component {\n render() {\n- var children = [

];\n+ var children = [

];\n return {children}<\/ReactTransitionGroup>;\n }\n }\ndiff --git a\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js b\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\nindex a5a04430aa..4eab5185cb 100644\n--- a\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\n+++ b\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\n@@ -311,7 +311,7 @@ describe('ReactContextValidator', () => {\n }\n }\n \n- ReactTestUtils.renderIntoDocument();\n+ ReactTestUtils.renderIntoDocument();\n expectDev(console.error.calls.count()).toBe(1);\n expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(\n 'Warning: ComponentA.childContextTypes is specified but there is no ' +\n@@ -320,9 +320,9 @@ describe('ReactContextValidator', () => {\n );\n \n \/\/ Warnings should be deduped by component type\n- ReactTestUtils.renderIntoDocument();\n+ ReactTestUtils.renderIntoDocument();\n expectDev(console.error.calls.count()).toBe(1);\n- ReactTestUtils.renderIntoDocument();\n+ ReactTestUtils.renderIntoDocument();\n expectDev(console.error.calls.count()).toBe(2);\n expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(\n 'Warning: ComponentB.childContextTypes is specified but there is no ' +\n@@ -371,7 +371,7 @@ describe('ReactContextValidator', () => {\n },\n });\n \n- ReactTestUtils.renderIntoDocument();\n+ ReactTestUtils.renderIntoDocument();\n expect(childContext.bar).toBeUndefined();\n expect(childContext.foo).toBe('FOO');\n });\ndiff --git a\/src\/isomorphic\/classic\/element\/__tests__\/ReactElement-test.js b\/src\/isomorphic\/classic\/element\/__tests__\/ReactElement-test.js\nindex 13187cd3b0..db3cf3fce1 100644\n--- a\/src\/isomorphic\/classic\/element\/__tests__\/ReactElement-test.js\n+++ b\/src\/isomorphic\/classic\/element\/__tests__\/ReactElement-test.js\n@@ -553,7 +553,7 @@ describe('comparing jsx vs .createFactory() vs .createElement()', () => {\n );\n },\n });\n- instance = ReactTestUtils.renderIntoDocument();\n+ instance = ReactTestUtils.renderIntoDocument();\n });\n \n it('should scry children but cannot', () => {\ndiff --git a\/src\/renderers\/__tests__\/ReactComponent-test.js b\/src\/renderers\/__tests__\/ReactComponent-test.js\nindex 024a729a39..bdc0e823a5 100644\n--- a\/src\/renderers\/__tests__\/ReactComponent-test.js\n+++ b\/src\/renderers\/__tests__\/ReactComponent-test.js\n@@ -56,9 +56,9 @@ describe('ReactComponent', () => {\n expect(() => {\n ReactTestUtils.renderIntoDocument(\n \n- \n- \n- \n+ \n+ \n+ \n <\/Wrapper>\n );\n }).toThrowError(\/Cannot assign to read only property.*\/);\n@@ -81,9 +81,9 @@ describe('ReactComponent', () => {\n expect(() => {\n ReactTestUtils.renderIntoDocument(\n \n- \n- \n- \n+ \n+ \n+ \n <\/Wrapper>\n );\n }).toThrowError(\/Cannot assign to read only property.*\/);\n@@ -247,10 +247,10 @@ describe('ReactComponent', () => {\n

\n {\n log.push(`ref 1 got ${c ? `instance ${c.props.id}` : 'null'}`);\n- }}\/>\n+ }} \/>\n {\n log.push(`ref 2 got ${c ? `instance ${c.props.id}` : 'null'}`);\n- }}\/>\n+ }} \/>\n <\/div>\n );\n }\ndiff --git a\/src\/renderers\/__tests__\/ReactComponentLifeCycle-test.js b\/src\/renderers\/__tests__\/ReactComponentLifeCycle-test.js\nindex 7c6c06cf75..ae512f1b53 100644\n--- a\/src\/renderers\/__tests__\/ReactComponentLifeCycle-test.js\n+++ b\/src\/renderers\/__tests__\/ReactComponentLifeCycle-test.js\n@@ -248,7 +248,7 @@ describe('ReactComponentLifeCycle', () => {\n },\n render: function() {\n expect(this.isMounted()).toBeFalsy();\n- return ;\n+ return

;\n },\n });\n \n@@ -292,7 +292,7 @@ describe('ReactComponentLifeCycle', () => {\n it('isMounted should return false when unmounted', () => {\n var Component = React.createClass({\n render: function() {\n- return ;\n+ return

;\n },\n });\n \n@@ -319,7 +319,7 @@ describe('ReactComponentLifeCycle', () => {\n if (this.state.isMounted) {\n expect(ReactDOM.findDOMNode(this).tagName).toBe('DIV');\n }\n- return ;\n+ return

;\n },\n });\n \ndiff --git a\/src\/renderers\/__tests__\/ReactCompositeComponent-test.js b\/src\/renderers\/__tests__\/ReactCompositeComponent-test.js\nindex 03ad27e560..6346ff739d 100644\n--- a\/src\/renderers\/__tests__\/ReactCompositeComponent-test.js\n+++ b\/src\/renderers\/__tests__\/ReactCompositeComponent-test.js\n@@ -138,19 +138,19 @@ describe('ReactCompositeComponent', () => {\n it('should not cache old DOM nodes when switching constructors', () => {\n var container = document.createElement('div');\n var instance = ReactDOM.render(\n- ,\n+ ,\n container\n );\n ReactDOM.render( \/\/ Warm any cache\n- ,\n+ ,\n container\n );\n ReactDOM.render( \/\/ Clear out the anchor\n- ,\n+ ,\n container\n );\n ReactDOM.render( \/\/ rerender\n- ,\n+ ,\n container\n );\n expect(instance.getAnchor().className).toBe('');\ndiff --git a\/src\/renderers\/__tests__\/ReactMultiChild-test.js b\/src\/renderers\/__tests__\/ReactMultiChild-test.js\nindex 50156fdbd3..42d7f4296f 100644\n--- a\/src\/renderers\/__tests__\/ReactMultiChild-test.js\n+++ b\/src\/renderers\/__tests__\/ReactMultiChild-test.js\n@@ -178,12 +178,12 @@ describe('ReactMultiChild', () => {\n }\n \n ReactDOM.render(\n- {[

]}<\/Parent>,\n+ {[

]}<\/Parent>,\n container\n );\n \n ReactDOM.render(\n- {[

]}<\/Parent>,\n+ {[

]}<\/Parent>,\n container\n );\n \n@@ -241,12 +241,12 @@ describe('ReactMultiChild', () => {\n }\n \n ReactDOM.render(\n- {createIterable([

])}<\/Parent>,\n+ {createIterable([

])}<\/Parent>,\n container\n );\n \n ReactDOM.render(\n- {createIterable([

])}<\/Parent>,\n+ {createIterable([

;\n+ return

;\n }\n }\n \n@@ -216,7 +216,7 @@ describe('CSSPropertyOperations', () => {\n static displayName = 'Comp';\n \n render() {\n- return

;\n+ return

;\n }\n }\n \ndiff --git a\/src\/renderers\/dom\/shared\/__tests__\/ReactDOM-test.js b\/src\/renderers\/dom\/shared\/__tests__\/ReactDOM-test.js\nindex c7c574a8fb..5da34e3824 100644\n--- a\/src\/renderers\/dom\/shared\/__tests__\/ReactDOM-test.js\n+++ b\/src\/renderers\/dom\/shared\/__tests__\/ReactDOM-test.js\n@@ -287,7 +287,7 @@ describe('ReactDOM', () => {\n ReactDOM.render(\n

Auto-focus Test<\/h1>\n- \n+ \n
The above input should be focused after mount.<\/p>\n <\/div>,\n container,\ndiff --git a\/src\/renderers\/dom\/shared\/tests\/ReactDOMComponent-test.js b\/src\/renderers\/dom\/shared\/tests\/ReactDOMComponent-test.js\nindex dc9c8cecea..24232bd782 100644\n--- a\/src\/renderers\/dom\/shared\/tests\/ReactDOMComponent-test.js\n+++ b\/src\/renderers\/dom\/shared\/tests\/ReactDOMComponent-test.js\n@@ -360,8 +360,8 @@ describe('ReactDOMComponent', () => {\n \n it('should properly update custom attributes on custom elements', () => {\n var container = document.createElement('div');\n- ReactDOM.render(, container);\n- ReactDOM.render(, container);\n+ ReactDOM.render(, container);\n+ ReactDOM.render(, container);\n var node = container.firstChild;\n expect(node.hasAttribute('foo')).toBe(false);\n expect(node.getAttribute('bar')).toBe('buzz');\n@@ -637,7 +637,7 @@ describe('ReactDOMComponent', () => {\n \n it('should ignore attribute whitelist for elements with the \"is: attribute', () => {\n var container = document.createElement('div');\n- ReactDOM.render(

dillon1000/react

Files changed