{"commit":{"shortRevision":"a2eaa21ac7","authorName":"Jan Kassens","authoredAt":"2024-01-19T13:35:43-05:00","authorEmail":"jkassens@meta.com","revision":"a2eaa21ac70ef898535479cb9fc9ea546854e072","subject":"Convert dangerouslySetInnerHTML-test to createRoot (#28008)"},"files":[{"status":"M","path":"packages\/react-dom\/src\/client\/__tests__\/dangerouslySetInnerHTML-test.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/client\/__tests__\/dangerouslySetInnerHTML-test.js b\/packages\/react-dom\/src\/client\/__tests__\/dangerouslySetInnerHTML-test.js\nindex 71f9249a1e..64b4c0b0f7 100644\n--- a\/packages\/react-dom\/src\/client\/__tests__\/dangerouslySetInnerHTML-test.js\n+++ b\/packages\/react-dom\/src\/client\/__tests__\/dangerouslySetInnerHTML-test.js\n@@ -10,17 +10,21 @@\n 'use strict';\n \n const React = require('react');\n-const ReactDOM = require('react-dom');\n+const ReactDOMClient = require('react-dom\/client');\n+\n+const act = require('internal-test-utils').act;\n \n describe('dangerouslySetInnerHTML', () => {\n describe('when the node has innerHTML property', () => {\n- it('sets innerHTML on it', () => {\n+ it('sets innerHTML on it', async () => {\n const container = document.createElement('div');\n- const node = ReactDOM.render(\n-

Hello<\/h1>'}} \/>,\n- container,\n- );\n- expect(node.innerHTML).toBe('

Hello<\/h1>');\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render(\n+
Hello<\/h1>'}} \/>,\n+ );\n+ });\n+ expect(container.firstChild.innerHTML).toBe('
Hello<\/h1>');\n });\n });\n \n@@ -56,22 +60,22 @@ describe('dangerouslySetInnerHTML', () => {\n });\n \n \/\/ @gate !disableIEWorkarounds\n- it('sets innerHTML on it', () => {\n+ it('sets innerHTML on it', async () => {\n const html = '<\/circle>';\n const container = document.createElementNS(\n 'http:\/\/www.w3.org\/2000\/svg',\n 'svg',\n );\n- ReactDOM.render(\n- ,\n- container,\n- );\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n const circle = container.firstChild.firstChild;\n expect(circle.tagName).toBe('circle');\n });\n \n \/\/ @gate !disableIEWorkarounds\n- it('clears previous children', () => {\n+ it('clears previous children', async () => {\n const firstHtml = '<\/rect>';\n const secondHtml = '<\/circle>';\n \n@@ -79,16 +83,15 @@ describe('dangerouslySetInnerHTML', () => {\n 'http:\/\/www.w3.org\/2000\/svg',\n 'svg',\n );\n- ReactDOM.render(\n- ,\n- container,\n- );\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n const rect = container.firstChild.firstChild;\n expect(rect.tagName).toBe('rect');\n- ReactDOM.render(\n- ,\n- container,\n- );\n+ await act(() => {\n+ root.render();\n+ });\n const circle = container.firstChild.firstChild;\n expect(circle.tagName).toBe('circle');\n });\n","parents":["24d1c6f0fa28f95e5ea5f9fa23c31a1058e2d1a1"],"body":"Convert dangerouslySetInnerHTML-test to createRoot"}

dillon1000/react

Files changed