{"commit":{"revision":"a473d08fcee187f957b844b53b2eee2d2714630b","shortRevision":"a473d08fce","subject":"Update to Flow from 0.97 to 0.122 (#25204)","authoredAt":"2022-09-08T11:46:07-04:00","authorName":"Jan Kassens","authorEmail":"jkassens@fb.com"},"files":[{"path":"package.json","status":"M"},{"path":"packages\/jest-react\/src\/internalAct.js","status":"M"},{"path":"packages\/react-debug-tools\/src\/ReactDebugHooks.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/backend\/StyleX\/utils.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/backend\/renderer.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/backend\/types.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Button.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/menu-button.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/tooltip.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/hydration.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/node_modules\/react-window\/src\/createGridComponent.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/node_modules\/react-window\/src\/createListComponent.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/registerDevToolsEventLogger.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/utils.js","status":"M"},{"path":"packages\/react-dom\/src\/events\/SyntheticEvent.js","status":"M"},{"path":"packages\/react-dom\/src\/server\/ReactDOMFizzServerBrowser.js","status":"M"},{"path":"packages\/react-dom\/src\/server\/ReactDOMFizzStaticBrowser.js","status":"M"},{"path":"packages\/react-fetch\/src\/ReactFetchNode.js","status":"M"},{"path":"packages\/react-native-renderer\/src\/legacy-events\/accumulateInto.js","status":"M"},{"path":"packages\/react-noop-renderer\/src\/ReactNoopFlightServer.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactChildFiber.new.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactChildFiber.old.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCommitWork.new.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCommitWork.old.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberHotReloading.new.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberHotReloading.old.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactTestSelectors.js","status":"M"},{"path":"packages\/react-server-dom-webpack\/src\/ReactFlightDOMServerBrowser.js","status":"M"},{"path":"packages\/react-server-dom-webpack\/src\/ReactFlightServerWebpackBundlerConfig.js","status":"M"},{"path":"packages\/react-server-dom-webpack\/src\/ReactFlightWebpackPlugin.js","status":"M"},{"path":"packages\/react-server\/src\/ReactFlightServer.js","status":"M"},{"path":"packages\/react-server\/src\/ReactFlightServerConfigStream.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/ReactTestRenderer.js","status":"M"},{"path":"packages\/react\/src\/ReactChildren.js","status":"M"},{"path":"packages\/react\/src\/ReactLazy.js","status":"M"},{"path":"packages\/shared\/CheckStringCoercion.js","status":"M"},{"path":"packages\/shared\/ReactServerContextRegistry.js","status":"M"},{"path":"packages\/shared\/ReactSymbols.js","status":"M"},{"path":"packages\/shared\/ReactTypes.js","status":"M"},{"path":"packages\/shared\/isValidElementType.js","status":"M"},{"path":"scripts\/flow\/config\/flowconfig","status":"M"},{"path":"yarn.lock","status":"M"}],"body":"* flow 0.122\r\n* update ReactModel type","parents":["fe55c0ea09f0241d4f012d3c6a69e77014d3ca52"],"patch":"diff --git a\/package.json b\/package.json\nindex 2e8445521b..47514e3ec2 100644\n--- a\/package.json\n+++ b\/package.json\n@@ -63,7 +63,7 @@\n \"eslint-plugin-react-internal\": \"link:.\/scripts\/eslint-rules\",\n \"fbjs-scripts\": \"1.2.0\",\n \"filesize\": \"^6.0.1\",\n- \"flow-bin\": \"0.97\",\n+ \"flow-bin\": \"^0.122\",\n \"glob\": \"^7.1.6\",\n \"glob-stream\": \"^6.1.0\",\n \"google-closure-compiler\": \"^20200517.0.0\",\ndiff --git a\/packages\/jest-react\/src\/internalAct.js b\/packages\/jest-react\/src\/internalAct.js\nindex 4e41f6234c..a5a398b7e2 100644\n--- a\/packages\/jest-react\/src\/internalAct.js\n+++ b\/packages\/jest-react\/src\/internalAct.js\n@@ -28,6 +28,8 @@ export function act(scope: () => Thenable | T): Thenable {\n 'This version of `act` requires a special mock build of Scheduler.',\n );\n }\n+\n+ \/\/ $FlowFixMe: _isMockFunction doesn't exist on function\n if (setTimeout._isMockFunction !== true) {\n throw Error(\n \"This version of `act` requires Jest's timer mocks \" +\ndiff --git a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\nindex 940873725c..7cfb576fad 100644\n--- a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n+++ b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n@@ -683,6 +683,7 @@ function handleRenderFunctionError(error: any): void {\n \/\/ TODO: refactor this if we ever combine the devtools and debug tools packages\n wrapperError.name = 'ReactDebugToolsRenderError';\n \/\/ this stage-4 proposal is not supported by all environments yet.\n+ \/\/ $FlowFixMe Flow doesn't have this type yet.\n wrapperError.cause = error;\n throw wrapperError;\n }\ndiff --git a\/packages\/react-devtools-shared\/src\/backend\/StyleX\/utils.js b\/packages\/react-devtools-shared\/src\/backend\/StyleX\/utils.js\nindex 68bda23a22..2167321b0c 100644\n--- a\/packages\/react-devtools-shared\/src\/backend\/StyleX\/utils.js\n+++ b\/packages\/react-devtools-shared\/src\/backend\/StyleX\/utils.js\n@@ -92,7 +92,9 @@ function getPropertyValueForStyleName(styleName: string): string | null {\n ]: any): CSSStyleSheet);\n \/\/ $FlowFixMe Flow doesn't konw about these properties\n const rules = styleSheet.rules || styleSheet.cssRules;\n+ \/\/ $FlowFixMe `rules` is mixed\n for (let ruleIndex = 0; ruleIndex < rules.length; ruleIndex++) {\n+ \/\/ $FlowFixMe `rules` is mixed\n const rule = rules[ruleIndex];\n \/\/ $FlowFixMe Flow doesn't konw about these properties\n const {cssText, selectorText, style} = rule;\ndiff --git a\/packages\/react-devtools-shared\/src\/backend\/renderer.js b\/packages\/react-devtools-shared\/src\/backend\/renderer.js\nindex 3a893060da..9802d4b8c0 100644\n--- a\/packages\/react-devtools-shared\/src\/backend\/renderer.js\n+++ b\/packages\/react-devtools-shared\/src\/backend\/renderer.js\n@@ -124,7 +124,7 @@ import type {\n } from 'react-devtools-shared\/src\/types';\n \n type getDisplayNameForFiberType = (fiber: Fiber) => string | null;\n-type getTypeSymbolType = (type: any) => Symbol | number;\n+type getTypeSymbolType = (type: any) => symbol | number;\n \n type ReactPriorityLevelsType = {|\n ImmediatePriority: number,\n@@ -382,13 +382,14 @@ export function getInternalReactConstants(\n \/\/ End of copied code.\n \/\/ **********************************************************\n \n- function getTypeSymbol(type: any): Symbol | number {\n+ function getTypeSymbol(type: any): symbol | number {\n const symbolOrNumber =\n typeof type === 'object' && type !== null ? type.$$typeof : type;\n \n \/\/ $FlowFixMe Flow doesn't know about typeof \"symbol\"\n return typeof symbolOrNumber === 'symbol'\n- ? symbolOrNumber.toString()\n+ ? \/\/ $FlowFixMe `toString()` doesn't match the type signature?\n+ symbolOrNumber.toString()\n : symbolOrNumber;\n }\n \ndiff --git a\/packages\/react-devtools-shared\/src\/backend\/types.js b\/packages\/react-devtools-shared\/src\/backend\/types.js\nindex 81ed15b04a..be71a816d6 100644\n--- a\/packages\/react-devtools-shared\/src\/backend\/types.js\n+++ b\/packages\/react-devtools-shared\/src\/backend\/types.js\n@@ -84,7 +84,7 @@ export type GetFiberIDForNative = (\n export type FindNativeNodesForFiberID = (id: number) => ?Array;\n \n export type ReactProviderType = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n _context: ReactContext,\n ...\n };\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Button.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Button.js\nindex 82400bb898..bdd84b57da 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Button.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Button.js\n@@ -28,6 +28,7 @@ export default function Button({\n ...rest\n }: Props) {\n let button = (\n+ \/\/ $FlowFixMe unsafe spread\n {\n const style = useThemeStyles();\n return (\n+ \/\/ $FlowFixMe unsafe spread\n \n {children}\n <\/ReachMenuList>\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/tooltip.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/tooltip.js\nindex d3f07258c8..c6dbec7ff4 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/tooltip.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/reach-ui\/tooltip.js\n@@ -23,6 +23,7 @@ const Tooltip = ({\n }) => {\n const style = useThemeStyles();\n return (\n+ \/\/ $FlowFixMe unsafe spread\n > = new LRU({\n });\n \n export function alphaSortKeys(\n- a: string | number | Symbol,\n- b: string | number | Symbol,\n+ a: string | number | symbol,\n+ b: string | number | symbol,\n ): number {\n if (a.toString() > b.toString()) {\n return 1;\n@@ -81,7 +81,7 @@ export function alphaSortKeys(\n \n export function getAllEnumerableKeys(\n obj: Object,\n-): Set {\n+): Set {\n const keys = new Set();\n let current = obj;\n while (current != null) {\ndiff --git a\/packages\/react-dom\/src\/events\/SyntheticEvent.js b\/packages\/react-dom\/src\/events\/SyntheticEvent.js\nindex 3609e6794a..2c61b9a42e 100644\n--- a\/packages\/react-dom\/src\/events\/SyntheticEvent.js\n+++ b\/packages\/react-dom\/src\/events\/SyntheticEvent.js\n@@ -166,7 +166,9 @@ let lastMouseEvent;\n function updateMouseMovementPolyfillState(event) {\n if (event !== lastMouseEvent) {\n if (lastMouseEvent && event.type === 'mousemove') {\n+ \/\/ $FlowFixMe assuming this is a number\n lastMovementX = event.screenX - lastMouseEvent.screenX;\n+ \/\/ $FlowFixMe assuming this is a number\n lastMovementY = event.screenY - lastMouseEvent.screenY;\n } else {\n lastMovementX = 0;\n@@ -367,7 +369,9 @@ function getEventKey(nativeEvent) {\n \n \/\/ FireFox implements `key` but returns `MozPrintableKey` for all\n \/\/ printable characters (normalized to `Unidentified`), ignore it.\n- const key = normalizeKey[nativeEvent.key] || nativeEvent.key;\n+ const key =\n+ \/\/ $FlowFixMe unable to index with a `mixed` value\n+ normalizeKey[nativeEvent.key] || nativeEvent.key;\n if (key !== 'Unidentified') {\n return key;\n }\n@@ -375,7 +379,10 @@ function getEventKey(nativeEvent) {\n \n \/\/ Browser does not implement `key`, polyfill as much of it as we can.\n if (nativeEvent.type === 'keypress') {\n- const charCode = getEventCharCode(nativeEvent);\n+ const charCode = getEventCharCode(\n+ \/\/ $FlowFixMe unable to narrow to `KeyboardEvent`\n+ nativeEvent,\n+ );\n \n \/\/ The enter-key is technically both printable and non-printable and can\n \/\/ thus be captured by `keypress`, no other non-printable key should.\n@@ -384,6 +391,7 @@ function getEventKey(nativeEvent) {\n if (nativeEvent.type === 'keydown' || nativeEvent.type === 'keyup') {\n \/\/ While user keyboard layout determines the actual meaning of each\n \/\/ `keyCode` value, almost all function keys have a universal value.\n+ \/\/ $FlowFixMe unable to index with a `mixed` value\n return translateToKey[nativeEvent.keyCode] || 'Unidentified';\n }\n return '';\n@@ -441,7 +449,10 @@ const KeyboardEventInterface = {\n \/\/ KeyPress is deprecated, but its replacement is not yet final and not\n \/\/ implemented in any major browser. Only KeyPress has charCode.\n if (event.type === 'keypress') {\n- return getEventCharCode(event);\n+ return getEventCharCode(\n+ \/\/ $FlowFixMe unable to narrow to `KeyboardEvent`\n+ event,\n+ );\n }\n return 0;\n },\n@@ -462,7 +473,10 @@ const KeyboardEventInterface = {\n \/\/ `which` is an alias for either `keyCode` or `charCode` depending on the\n \/\/ type of the event.\n if (event.type === 'keypress') {\n- return getEventCharCode(event);\n+ return getEventCharCode(\n+ \/\/ $FlowFixMe unable to narrow to `KeyboardEvent`\n+ event,\n+ );\n }\n if (event.type === 'keydown' || event.type === 'keyup') {\n return event.keyCode;\n@@ -538,7 +552,8 @@ const WheelEventInterface = {\n ? event.deltaX\n : \/\/ Fallback to `wheelDeltaX` for Webkit and normalize (right is positive).\n 'wheelDeltaX' in event\n- ? -event.wheelDeltaX\n+ ? \/\/ $FlowFixMe assuming this is a number\n+ -event.wheelDeltaX\n : 0;\n },\n deltaY(event) {\n@@ -546,10 +561,12 @@ const WheelEventInterface = {\n ? event.deltaY\n : \/\/ Fallback to `wheelDeltaY` for Webkit and normalize (down is positive).\n 'wheelDeltaY' in event\n- ? -event.wheelDeltaY\n+ ? \/\/ $FlowFixMe assuming this is a number\n+ -event.wheelDeltaY\n : \/\/ Fallback to `wheelDelta` for IE<9 and normalize (down is positive).\n 'wheelDelta' in event\n- ? -event.wheelDelta\n+ ? \/\/ $FlowFixMe assuming this is a number\n+ -event.wheelDelta\n : 0;\n },\n deltaZ: 0,\ndiff --git a\/packages\/react-dom\/src\/server\/ReactDOMFizzServerBrowser.js b\/packages\/react-dom\/src\/server\/ReactDOMFizzServerBrowser.js\nindex 2f626c922a..25920232e8 100644\n--- a\/packages\/react-dom\/src\/server\/ReactDOMFizzServerBrowser.js\n+++ b\/packages\/react-dom\/src\/server\/ReactDOMFizzServerBrowser.js\n@@ -57,10 +57,10 @@ function renderToReadableStream(\n const stream: ReactDOMServerReadableStream = (new ReadableStream(\n {\n type: 'bytes',\n- pull(controller) {\n+ pull(controller): ?Promise {\n startFlowing(request, controller);\n },\n- cancel(reason) {\n+ cancel(reason): ?Promise {\n abort(request);\n },\n },\ndiff --git a\/packages\/react-dom\/src\/server\/ReactDOMFizzStaticBrowser.js b\/packages\/react-dom\/src\/server\/ReactDOMFizzStaticBrowser.js\nindex 38e4c948f6..c2c619046d 100644\n--- a\/packages\/react-dom\/src\/server\/ReactDOMFizzStaticBrowser.js\n+++ b\/packages\/react-dom\/src\/server\/ReactDOMFizzStaticBrowser.js\n@@ -50,7 +50,7 @@ function prerender(\n const stream = new ReadableStream(\n {\n type: 'bytes',\n- pull(controller) {\n+ pull(controller): ?Promise {\n startFlowing(request, controller);\n },\n },\ndiff --git a\/packages\/react-fetch\/src\/ReactFetchNode.js b\/packages\/react-fetch\/src\/ReactFetchNode.js\nindex 2b1ef5f200..9020529d44 100644\n--- a\/packages\/react-fetch\/src\/ReactFetchNode.js\n+++ b\/packages\/react-fetch\/src\/ReactFetchNode.js\n@@ -43,6 +43,7 @@ function nodeFetch(\n \/\/ TODO: cherry-pick supported user-passed options.\n };\n const nodeImpl = protocol === 'https:' ? https : http;\n+ \/\/ $FlowFixMe: node flow type has `port` as a number\n const request = nodeImpl.request(nodeOptions, response => {\n \/\/ TODO: support redirects.\n onResolve(new Response(response));\ndiff --git a\/packages\/react-native-renderer\/src\/legacy-events\/accumulateInto.js b\/packages\/react-native-renderer\/src\/legacy-events\/accumulateInto.js\nindex 974c0143a5..7c9f17a757 100644\n--- a\/packages\/react-native-renderer\/src\/legacy-events\/accumulateInto.js\n+++ b\/packages\/react-native-renderer\/src\/legacy-events\/accumulateInto.js\n@@ -40,9 +40,11 @@ function accumulateInto(\n \/\/ certain that x is an Array (x could be a string with concat method).\n if (isArray(current)) {\n if (isArray(next)) {\n+ \/\/ $FlowFixMe `isArray` does not ensure array is mutable\n current.push.apply(current, next);\n return current;\n }\n+ \/\/ $FlowFixMe `isArray` does not ensure array is mutable\n current.push(next);\n return current;\n }\ndiff --git a\/packages\/react-noop-renderer\/src\/ReactNoopFlightServer.js b\/packages\/react-noop-renderer\/src\/ReactNoopFlightServer.js\nindex 3a84a06d08..bd0badc535 100644\n--- a\/packages\/react-noop-renderer\/src\/ReactNoopFlightServer.js\n+++ b\/packages\/react-noop-renderer\/src\/ReactNoopFlightServer.js\n@@ -53,7 +53,7 @@ const ReactNoopFlightServer = ReactFlightServer({\n },\n resolveModuleMetaData(\n config: void,\n- reference: {$$typeof: Symbol, value: any},\n+ reference: {$$typeof: symbol, value: any},\n ) {\n return saveModule(reference.value);\n },\ndiff --git a\/packages\/react-reconciler\/src\/ReactChildFiber.new.js b\/packages\/react-reconciler\/src\/ReactChildFiber.new.js\nindex 71971c0389..2e1a232e02 100644\n--- a\/packages\/react-reconciler\/src\/ReactChildFiber.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactChildFiber.new.js\n@@ -80,6 +80,7 @@ if (__DEV__) {\n );\n }\n \n+ \/\/ $FlowFixMe unable to narrow type from mixed to writable object\n child._store.validated = true;\n \n const componentName = getComponentNameFromFiber(returnFiber) || 'Component';\ndiff --git a\/packages\/react-reconciler\/src\/ReactChildFiber.old.js b\/packages\/react-reconciler\/src\/ReactChildFiber.old.js\nindex 86f75fbf65..c6fdbcc728 100644\n--- a\/packages\/react-reconciler\/src\/ReactChildFiber.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactChildFiber.old.js\n@@ -80,6 +80,7 @@ if (__DEV__) {\n );\n }\n \n+ \/\/ $FlowFixMe unable to narrow type from mixed to writable object\n child._store.validated = true;\n \n const componentName = getComponentNameFromFiber(returnFiber) || 'Component';\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.new.js b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.new.js\nindex d2cd313a05..c70e4ae347 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.new.js\n@@ -296,6 +296,7 @@ function safelyDetachRef(current: Fiber, nearestMountedAncestor: Fiber | null) {\n }\n }\n } else {\n+ \/\/ $FlowFixMe unable to narrow type to RefObject\n ref.current = null;\n }\n }\n@@ -1522,6 +1523,7 @@ function commitAttachRef(finishedWork: Fiber) {\n }\n }\n \n+ \/\/ $FlowFixMe unable to narrow type to the non-function case\n ref.current = instanceToUse;\n }\n }\n@@ -1542,6 +1544,7 @@ function commitDetachRef(current: Fiber) {\n currentRef(null);\n }\n } else {\n+ \/\/ $FlowFixMe unable to narrow type to the non-function case\n currentRef.current = null;\n }\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.old.js b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.old.js\nindex 70a6861776..4b5076a61c 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.old.js\n@@ -296,6 +296,7 @@ function safelyDetachRef(current: Fiber, nearestMountedAncestor: Fiber | null) {\n }\n }\n } else {\n+ \/\/ $FlowFixMe unable to narrow type to RefObject\n ref.current = null;\n }\n }\n@@ -1522,6 +1523,7 @@ function commitAttachRef(finishedWork: Fiber) {\n }\n }\n \n+ \/\/ $FlowFixMe unable to narrow type to the non-function case\n ref.current = instanceToUse;\n }\n }\n@@ -1542,6 +1544,7 @@ function commitDetachRef(current: Fiber) {\n currentRef(null);\n }\n } else {\n+ \/\/ $FlowFixMe unable to narrow type to the non-function case\n currentRef.current = null;\n }\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHotReloading.new.js b\/packages\/react-reconciler\/src\/ReactFiberHotReloading.new.js\nindex 22b78280f9..469fbabf9e 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHotReloading.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHotReloading.new.js\n@@ -222,6 +222,7 @@ export function markFailedErrorBoundaryForHotReloading(fiber: Fiber) {\n return;\n }\n if (failedBoundaries === null) {\n+ \/\/ $FlowFixMe Flow got confused by the feature check above.\n failedBoundaries = new WeakSet();\n }\n failedBoundaries.add(fiber);\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHotReloading.old.js b\/packages\/react-reconciler\/src\/ReactFiberHotReloading.old.js\nindex 805176560c..c503c7a111 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHotReloading.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHotReloading.old.js\n@@ -222,6 +222,7 @@ export function markFailedErrorBoundaryForHotReloading(fiber: Fiber) {\n return;\n }\n if (failedBoundaries === null) {\n+ \/\/ $FlowFixMe Flow got confused by the feature check above.\n failedBoundaries = new WeakSet();\n }\n failedBoundaries.add(fiber);\ndiff --git a\/packages\/react-reconciler\/src\/ReactTestSelectors.js b\/packages\/react-reconciler\/src\/ReactTestSelectors.js\nindex adadc8ed73..ad1333c936 100644\n--- a\/packages\/react-reconciler\/src\/ReactTestSelectors.js\n+++ b\/packages\/react-reconciler\/src\/ReactTestSelectors.js\n@@ -39,7 +39,7 @@ if (typeof Symbol === 'function' && Symbol.for) {\n TEXT_TYPE = symbolFor('selector.text');\n }\n \n-type Type = Symbol | number;\n+type Type = symbol | number;\n \n type ComponentSelector = {|\n $$typeof: Type,\ndiff --git a\/packages\/react-server-dom-webpack\/src\/ReactFlightDOMServerBrowser.js b\/packages\/react-server-dom-webpack\/src\/ReactFlightDOMServerBrowser.js\nindex 93d047e4a0..2cbd609b47 100644\n--- a\/packages\/react-server-dom-webpack\/src\/ReactFlightDOMServerBrowser.js\n+++ b\/packages\/react-server-dom-webpack\/src\/ReactFlightDOMServerBrowser.js\n@@ -52,13 +52,13 @@ function renderToReadableStream(\n const stream = new ReadableStream(\n {\n type: 'bytes',\n- start(controller) {\n+ start(controller): ?Promise {\n startWork(request);\n },\n- pull(controller) {\n+ pull(controller): ?Promise {\n startFlowing(request, controller);\n },\n- cancel(reason) {},\n+ cancel(reason): ?Promise {},\n },\n \/\/ $FlowFixMe size() methods are not allowed on byte streams.\n {highWaterMark: 0},\ndiff --git a\/packages\/react-server-dom-webpack\/src\/ReactFlightServerWebpackBundlerConfig.js b\/packages\/react-server-dom-webpack\/src\/ReactFlightServerWebpackBundlerConfig.js\nindex caeed14a7b..8d7dccae33 100644\n--- a\/packages\/react-server-dom-webpack\/src\/ReactFlightServerWebpackBundlerConfig.js\n+++ b\/packages\/react-server-dom-webpack\/src\/ReactFlightServerWebpackBundlerConfig.js\n@@ -17,7 +17,7 @@ export type BundlerConfig = WebpackMap;\n \n \/\/ eslint-disable-next-line no-unused-vars\n export type ModuleReference = {\n- $$typeof: Symbol,\n+ $$typeof: symbol,\n filepath: string,\n name: string,\n async: boolean,\ndiff --git a\/packages\/react-server-dom-webpack\/src\/ReactFlightWebpackPlugin.js b\/packages\/react-server-dom-webpack\/src\/ReactFlightWebpackPlugin.js\nindex 0c49d29373..b3da107e60 100644\n--- a\/packages\/react-server-dom-webpack\/src\/ReactFlightWebpackPlugin.js\n+++ b\/packages\/react-server-dom-webpack\/src\/ReactFlightWebpackPlugin.js\n@@ -25,7 +25,7 @@ import {\n import isArray from 'shared\/isArray';\n \n class ClientReferenceDependency extends ModuleDependency {\n- constructor(request) {\n+ constructor(request: mixed) {\n super(request);\n }\n \ndiff --git a\/packages\/react-server\/src\/ReactFlightServer.js b\/packages\/react-server\/src\/ReactFlightServer.js\nindex 7c6801e378..1e84a89350 100644\n--- a\/packages\/react-server\/src\/ReactFlightServer.js\n+++ b\/packages\/react-server\/src\/ReactFlightServer.js\n@@ -86,6 +86,7 @@ export type ReactModel =\n | string\n | boolean\n | number\n+ | symbol\n | null\n | Iterable\n | ReactModelObject;\n@@ -119,7 +120,7 @@ export type Request = {\n completedModuleChunks: Array,\n completedJSONChunks: Array,\n completedErrorChunks: Array,\n- writtenSymbols: Map,\n+ writtenSymbols: Map,\n writtenModules: Map,\n writtenProviders: Map,\n identifierPrefix: string,\n@@ -746,12 +747,17 @@ export function resolveModelToJSON(\n if (existingId !== undefined) {\n return serializeByValueID(existingId);\n }\n- const name = value.description;\n+ \/\/ $FlowFixMe `description` might be undefined\n+ const name: string = value.description;\n \n+ \/\/ $FlowFixMe `name` might be undefined\n if (Symbol.for(name) !== value) {\n throw new Error(\n 'Only global symbols received from Symbol.for(...) can be passed to client components. ' +\n- `The symbol Symbol.for(${value.description}) cannot be found among global symbols. ` +\n+ `The symbol Symbol.for(${\n+ \/\/ $FlowFixMe `description` might be undefined\n+ value.description\n+ }) cannot be found among global symbols. ` +\n `Remove ${describeKeyForErrorMessage(\n key,\n )} from this object, or avoid the entire object: ${describeObjectForErrorMessage(\ndiff --git a\/packages\/react-server\/src\/ReactFlightServerConfigStream.js b\/packages\/react-server\/src\/ReactFlightServerConfigStream.js\nindex b9772ef6f2..6320f28d58 100644\n--- a\/packages\/react-server\/src\/ReactFlightServerConfigStream.js\n+++ b\/packages\/react-server\/src\/ReactFlightServerConfigStream.js\n@@ -94,7 +94,8 @@ export function processModelChunk(\n id: number,\n model: ReactModel,\n ): Chunk {\n- const json = stringify(model, request.toJSON);\n+ \/\/ $FlowFixMe: `json` might be `undefined` when model is a symbol.\n+ const json: string = stringify(model, request.toJSON);\n const row = serializeRowHeader('J', id) + json + '\\n';\n return stringToChunk(row);\n }\n@@ -114,7 +115,8 @@ export function processModuleChunk(\n id: number,\n moduleMetaData: ReactModel,\n ): Chunk {\n- const json = stringify(moduleMetaData);\n+ \/\/ $FlowFixMe: `json` might be `undefined` when moduleMetaData is a symbol.\n+ const json: string = stringify(moduleMetaData);\n const row = serializeRowHeader('M', id) + json + '\\n';\n return stringToChunk(row);\n }\ndiff --git a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\nindex 76911d701d..43cfe6ef82 100644\n--- a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n+++ b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n@@ -65,7 +65,7 @@ type ReactTestRendererJSON = {|\n type: string,\n props: {[propName: string]: any, ...},\n children: null | Array,\n- $$typeof?: Symbol, \/\/ Optional because we add it with defineProperty().\n+ $$typeof?: symbol, \/\/ Optional because we add it with defineProperty().\n |};\n type ReactTestRendererNode = ReactTestRendererJSON | string;\n \ndiff --git a\/packages\/react\/src\/ReactChildren.js b\/packages\/react\/src\/ReactChildren.js\nindex d0562f53e3..686d39a571 100644\n--- a\/packages\/react\/src\/ReactChildren.js\n+++ b\/packages\/react\/src\/ReactChildren.js\n@@ -137,9 +137,12 @@ function mapIntoArray(\n escapedPrefix +\n \/\/ $FlowFixMe Flow incorrectly thinks React.Portal doesn't have a key\n (mappedChild.key && (!child || child.key !== mappedChild.key)\n- ? \/\/ $FlowFixMe Flow incorrectly thinks existing element's key can be a number\n- \/\/ eslint-disable-next-line react-internal\/safe-string-coercion\n- escapeUserProvidedKey('' + mappedChild.key) + '\/'\n+ ? escapeUserProvidedKey(\n+ \/\/ eslint-disable-next-line react-internal\/safe-string-coercion\n+ '' +\n+ \/\/ $FlowFixMe Flow incorrectly thinks existing element's key can be a number\n+ mappedChild.key,\n+ ) + '\/'\n : '') +\n childKey,\n );\n@@ -190,6 +193,7 @@ function mapIntoArray(\n const iterator = iteratorFn.call(iterableChildren);\n let step;\n let ii = 0;\n+ \/\/ $FlowFixMe `iteratorFn` might return null according to typing.\n while (!(step = iterator.next()).done) {\n child = step.value;\n nextName = nextNamePrefix + getElementKey(child, ii++);\n@@ -222,7 +226,7 @@ function mapIntoArray(\n return subtreeCount;\n }\n \n-type MapFunc = (child: ?React$Node) => ?ReactNodeList;\n+type MapFunc = (child: ?React$Node, index: number) => ?ReactNodeList;\n \n \/**\n * Maps children that are typically specified as `props.children`.\ndiff --git a\/packages\/react\/src\/ReactLazy.js b\/packages\/react\/src\/ReactLazy.js\nindex 6bfa6cbdec..4f786ed25f 100644\n--- a\/packages\/react\/src\/ReactLazy.js\n+++ b\/packages\/react\/src\/ReactLazy.js\n@@ -43,7 +43,7 @@ type Payload =\n | RejectedPayload;\n \n export type LazyComponent = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n _payload: P,\n _init: (payload: P) => T,\n };\ndiff --git a\/packages\/shared\/CheckStringCoercion.js b\/packages\/shared\/CheckStringCoercion.js\nindex 305572f846..e8fbf64a99 100644\n--- a\/packages\/shared\/CheckStringCoercion.js\n+++ b\/packages\/shared\/CheckStringCoercion.js\n@@ -26,6 +26,7 @@ function typeName(value: mixed): string {\n (hasToStringTag && (value: any)[Symbol.toStringTag]) ||\n (value: any).constructor.name ||\n 'Object';\n+ \/\/ $FlowFixMe\n return type;\n }\n }\ndiff --git a\/packages\/shared\/ReactServerContextRegistry.js b\/packages\/shared\/ReactServerContextRegistry.js\nindex ab8421b3c3..d8f7c70829 100644\n--- a\/packages\/shared\/ReactServerContextRegistry.js\n+++ b\/packages\/shared\/ReactServerContextRegistry.js\n@@ -17,6 +17,7 @@ export function getOrCreateServerContext(globalName: string) {\n if (!ContextRegistry[globalName]) {\n ContextRegistry[globalName] = createServerContext(\n globalName,\n+ \/\/ $FlowFixMe function signature doesn't reflect the symbol value\n REACT_SERVER_CONTEXT_DEFAULT_VALUE_NOT_LOADED,\n );\n }\ndiff --git a\/packages\/shared\/ReactSymbols.js b\/packages\/shared\/ReactSymbols.js\nindex 6ff9305fa7..50f4fba27d 100644\n--- a\/packages\/shared\/ReactSymbols.js\n+++ b\/packages\/shared\/ReactSymbols.js\n@@ -40,7 +40,7 @@ export const REACT_SERVER_CONTEXT_DEFAULT_VALUE_NOT_LOADED = Symbol.for(\n const MAYBE_ITERATOR_SYMBOL = Symbol.iterator;\n const FAUX_ITERATOR_SYMBOL = '@@iterator';\n \n-export function getIteratorFn(maybeIterable: ?any): ?() => ?Iterator<*> {\n+export function getIteratorFn(maybeIterable: ?any): ?() => ?Iterator {\n if (maybeIterable === null || typeof maybeIterable !== 'object') {\n return null;\n }\ndiff --git a\/packages\/shared\/ReactTypes.js b\/packages\/shared\/ReactTypes.js\nindex 6e829a3a9f..5209c795c2 100644\n--- a\/packages\/shared\/ReactTypes.js\n+++ b\/packages\/shared\/ReactTypes.js\n@@ -24,7 +24,7 @@ export type ReactNodeList = ReactEmpty | React$Node;\n export type ReactText = string | number;\n \n export type ReactProvider = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n type: ReactProviderType,\n key: null | string,\n ref: null,\n@@ -37,13 +37,13 @@ export type ReactProvider = {\n };\n \n export type ReactProviderType = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n _context: ReactContext,\n ...\n };\n \n export type ReactConsumer = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n type: ReactContext,\n key: null | string,\n ref: null,\n@@ -55,7 +55,7 @@ export type ReactConsumer = {\n };\n \n export type ReactContext = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n Consumer: ReactContext,\n Provider: ReactProviderType,\n _currentValue: T,\n@@ -85,7 +85,7 @@ export type ServerContextJSONValue =\n export type ReactServerContext = ReactContext;\n \n export type ReactPortal = {\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n key: null | string,\n containerInfo: any,\n children: ReactNodeList,\n@@ -99,7 +99,7 @@ export type RefObject = {|\n |};\n \n export type ReactScope = {|\n- $$typeof: Symbol | number,\n+ $$typeof: symbol | number,\n |};\n \n export type ReactScopeQuery = (\ndiff --git a\/packages\/shared\/isValidElementType.js b\/packages\/shared\/isValidElementType.js\nindex 87424982af..c0e4cdc769 100644\n--- a\/packages\/shared\/isValidElementType.js\n+++ b\/packages\/shared\/isValidElementType.js\n@@ -33,7 +33,7 @@ import {\n enableLegacyHidden,\n } from '.\/ReactFeatureFlags';\n \n-const REACT_MODULE_REFERENCE: Symbol = Symbol.for('react.module.reference');\n+const REACT_MODULE_REFERENCE: symbol = Symbol.for('react.module.reference');\n \n export default function isValidElementType(type: mixed) {\n if (typeof type === 'string' || typeof type === 'function') {\ndiff --git a\/scripts\/flow\/config\/flowconfig b\/scripts\/flow\/config\/flowconfig\nindex 9c10ba265d..a61f324d93 100644\n--- a\/scripts\/flow\/config\/flowconfig\n+++ b\/scripts\/flow\/config\/flowconfig\n@@ -50,4 +50,4 @@ esproposal.optional_chaining=enable\n munge_underscores=false\n \n [version]\n-^0.97.0\n+^0.122.0\ndiff --git a\/yarn.lock b\/yarn.lock\nindex c9009657b4..15c796b9b7 100644\n--- a\/yarn.lock\n+++ b\/yarn.lock\n@@ -7913,10 +7913,10 @@ flatted@^2.0.0:\n resolved \"https:\/\/registry.yarnpkg.com\/flatted\/-\/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138\"\n integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+\/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==\n \n-flow-bin@0.97:\n- version \"0.97.0\"\n- resolved \"https:\/\/registry.yarnpkg.com\/flow-bin\/-\/flow-bin-0.97.0.tgz#036ffcfc27503367a9d906ec9d843a0aa6f6bb83\"\n- integrity sha512-jXjD05gkatLuC4+e28frH1hZoRwr1iASP6oJr61Q64+kR4kmzaS+AdFBhYgoYS5kpoe4UzwDebWK8ETQFNh00w==\n+flow-bin@^0.122:\n+ version \"0.122.0\"\n+ resolved \"https:\/\/registry.yarnpkg.com\/flow-bin\/-\/flow-bin-0.122.0.tgz#c723a2b33b1a70bd10204704ae1dc776d5d89d79\"\n+ integrity sha512-my8N5jgl\/A+UVby9E7NDppHdhLgRbWgKbmFZSx2MSYMRh3d9YGnM2MM+wexpUpl0ftY1IM6ZcUwaAhrypLyvlA==\n \n fluent-syntax@0.13.0:\n version \"0.13.0\"\n"}

dillon1000/react

Files changed