{"body":"","files":[{"path":"scripts\/fiber\/tests-passing.txt","status":"M"},{"path":"src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js","status":"M"}],"patch":"diff --git a\/scripts\/fiber\/tests-passing.txt b\/scripts\/fiber\/tests-passing.txt\nindex 5867da6a6a..b3516d6da6 100644\n--- a\/scripts\/fiber\/tests-passing.txt\n+++ b\/scripts\/fiber\/tests-passing.txt\n@@ -490,6 +490,7 @@ src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js\n * finds the first child even when fragment is nested\n * finds the first child even when first child renders null\n * should render portal children\n+* should render nested portals\n * should pass portal context when rendering subtree elsewhere\n * should update portal context if it changes due to setState\n * should update portal context if it changes due to re-render\ndiff --git a\/src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js b\/src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js\nindex 84e6de3271..777c8e2842 100644\n--- a\/src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js\n+++ b\/src\/renderers\/dom\/fiber\/__tests__\/ReactDOMFiber-test.js\n@@ -280,6 +280,39 @@ describe('ReactDOMFiber', () => {\n ]);\n });\n \n+ it('should render nested portals', () => {\n+ var portalContainer1 = document.createElement('div');\n+ var portalContainer2 = document.createElement('div');\n+ var portalContainer3 = document.createElement('div');\n+\n+ ReactDOM.render([\n+

normal[0]<\/div>,\n+ ReactDOM.unstable_createPortal([\n+

portal1[0]<\/div>,\n+ ReactDOM.unstable_createPortal(\n+

portal2[0]<\/div>,\n+ portalContainer2\n+ ),\n+ ReactDOM.unstable_createPortal(\n+

portal3[0]<\/div>,\n+ portalContainer3\n+ ),\n+

portal1[1]<\/div>,\n+ ], portalContainer1),\n+

normal[1]<\/div>,\n+ ], container);\n+ expect(portalContainer1.innerHTML).toBe('

portal1[0]<\/div>

portal1[1]<\/div>');\n+ expect(portalContainer2.innerHTML).toBe('

portal2[0]<\/div>');\n+ expect(portalContainer3.innerHTML).toBe('

portal3[0]<\/div>');\n+ expect(container.innerHTML).toBe('

normal[0]<\/div>

normal[1]<\/div>');\n+\n+ ReactDOM.unmountComponentAtNode(container);\n+ expect(portalContainer1.innerHTML).toBe('');\n+ expect(portalContainer2.innerHTML).toBe('');\n+ expect(portalContainer3.innerHTML).toBe('');\n+ expect(container.innerHTML).toBe('');\n+ });\n+\n it('should pass portal context when rendering subtree elsewhere', () => {\n var portalContainer = document.createElement('div');\n \n","parents":["0ba8434a33a23c12e3ad0e8a0ccfce72d4c4ddd4"],"commit":{"authorEmail":"dan.abramov@gmail.com","authorName":"Dan Abramov","shortRevision":"a4dd68fb3d","authoredAt":"2016-11-24T18:43:45+00:00","subject":"Add a test for nested portals (#8416)","revision":"a4dd68fb3d6bae79b555442a3e4c3f3484ccb2bf"}}

dillon1000/react

Files changed