{"body":"","parents":["af94b075c02a82ea0e3c1937036a75b9f43727d7"],"patch":"diff --git a\/compiler\/forget\/packages\/snap\/src\/compiler-worker.ts b\/compiler\/forget\/packages\/snap\/src\/compiler-worker.ts\nindex 2ad5c170f2..08f2ba2a93 100644\n--- a\/compiler\/forget\/packages\/snap\/src\/compiler-worker.ts\n+++ b\/compiler\/forget\/packages\/snap\/src\/compiler-worker.ts\n@@ -96,6 +96,7 @@ export async function compile(\n let enableAssumeHooksFollowRulesOfReact = false;\n let enableTreatHooksAsFunctions = true;\n let disableAllMemoization = false;\n+ let validateRefAccessDuringRender = true;\n if (firstLine.indexOf(\"@forgetDirective\") !== -1) {\n enableOnlyOnUseForgetDirective = true;\n }\n@@ -132,6 +133,9 @@ export async function compile(\n if (firstLine.indexOf(\"@disableAllMemoization true\") !== -1) {\n disableAllMemoization = true;\n }\n+ if (firstLine.indexOf(\"@validateRefAccessDuringRender false\") !== -1) {\n+ validateRefAccessDuringRender = false;\n+ }\n \n const language = parseLanguage(firstLine);\n \n@@ -154,6 +158,7 @@ export async function compile(\n inlineUseMemo: true,\n memoizeJsxElements,\n validateHooksUsage: true,\n+ validateRefAccessDuringRender,\n },\n logger: null,\n gating,\ndiff --git a\/compiler\/forget\/src\/CompilerPipeline.ts b\/compiler\/forget\/src\/CompilerPipeline.ts\nindex cedd57b480..2eaa74a933 100644\n--- a\/compiler\/forget\/src\/CompilerPipeline.ts\n+++ b\/compiler\/forget\/src\/CompilerPipeline.ts\n@@ -14,6 +14,7 @@ import {\n ReactiveFunction,\n validateConsistentIdentifiers,\n validateHooksUsage,\n+ validateNoRefAccessInRender,\n validateTerminalSuccessors,\n validateUnconditionalHooks,\n } from \".\/HIR\";\n@@ -93,6 +94,9 @@ export function* run(\n inferTypes(hir);\n yield log({ kind: \"hir\", name: \"InferTypes\", value: hir });\n \n+ if (env.validateRefAccessDuringRender) {\n+ validateNoRefAccessInRender(hir);\n+ }\n if (env.validateHooksUsage) {\n validateHooksUsage(hir);\n const conditionalHooksResult = validateUnconditionalHooks(hir).unwrap();\ndiff --git a\/compiler\/forget\/src\/HIR\/Environment.ts b\/compiler\/forget\/src\/HIR\/Environment.ts\nindex 8b575edbb2..f6188d78a2 100644\n--- a\/compiler\/forget\/src\/HIR\/Environment.ts\n+++ b\/compiler\/forget\/src\/HIR\/Environment.ts\n@@ -67,6 +67,13 @@ export type EnvironmentConfig = Partial<{\n *\/\n validateHooksUsage: boolean;\n \n+ \/**\n+ * Validate that ref values (`ref.current`) are not accessed during render.\n+ *\n+ * Defaults to false\n+ *\/\n+ validateRefAccessDuringRender: boolean;\n+\n \/**\n * Enable inlining of `useMemo()` function expressions so that they can be more optimally\n * compiled.\n@@ -119,6 +126,7 @@ export class Environment {\n #nextIdentifer: number = 0;\n #nextBlock: number = 0;\n validateHooksUsage: boolean;\n+ validateRefAccessDuringRender: boolean;\n enableFunctionCallSignatureOptimizations: boolean;\n enableAssumeHooksFollowRulesOfReact: boolean;\n enableTreatHooksAsFunctions: boolean;\n@@ -154,6 +162,8 @@ export class Environment {\n this.#globals = DEFAULT_GLOBALS;\n }\n this.validateHooksUsage = config?.validateHooksUsage ?? false;\n+ this.validateRefAccessDuringRender =\n+ config?.validateRefAccessDuringRender ?? false;\n this.enableFunctionCallSignatureOptimizations =\n config?.enableFunctionCallSignatureOptimizations ?? false;\n this.enableAssumeHooksFollowRulesOfReact =\ndiff --git a\/compiler\/forget\/src\/HIR\/ValidateNoRefAccesInRender.ts b\/compiler\/forget\/src\/HIR\/ValidateNoRefAccesInRender.ts\nnew file mode 100644\nindex 0000000000..21d84e04c5\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/HIR\/ValidateNoRefAccesInRender.ts\n@@ -0,0 +1,104 @@\n+\/**\n+ * Copyright (c) Meta Platforms, Inc. and affiliates.\n+ *\n+ * This source code is licensed under the MIT license found in the\n+ * LICENSE file in the root directory of this source tree.\n+ *\/\n+\n+import {\n+ CompilerError,\n+ CompilerErrorDetail,\n+ ErrorSeverity,\n+} from \"..\/CompilerError\";\n+import { HIRFunction, Place, isRefValueType, isUseRefType } from \".\/HIR\";\n+import { printPlace } from \".\/PrintHIR\";\n+import { eachInstructionValueOperand, eachTerminalOperand } from \".\/visitors\";\n+\n+\/**\n+ * Validates that ref values (the `current` property) are not accessed during render.\n+ * This validation is conservative and only rejects accesses of known ref values:\n+ *\n+ * ```javascript\n+ * \/\/ ERROR\n+ * const ref = useRef();\n+ * ref.current;\n+ *\n+ * const ref = useRef();\n+ * foo(ref); \/\/ may access .current\n+ *\n+ * \/\/ ALLOWED\n+ * const ref = useHookThatReturnsRef();\n+ * ref.current;\n+ * ```\n+ *\n+ * In the future we may reject more cases, based on either object names (`fooRef.current` is likely a ref)\n+ * or based on property name alone (`foo.current` might be a ref).\n+ *\/\n+export function validateNoRefAccessInRender(fn: HIRFunction): void {\n+ const error = new CompilerError();\n+\n+ for (const [, block] of fn.body.blocks) {\n+ for (const instr of block.instructions) {\n+ switch (instr.value.kind) {\n+ case \"FunctionExpression\": {\n+ \/\/ For now we assume *all* function expressions are safe, eventually we can\n+ \/\/ be more precise and disallow ref access in functions that may be called\n+ \/\/ during render\n+ break;\n+ }\n+ case \"CallExpression\":\n+ case \"NewExpression\": {\n+ for (const operand of eachInstructionValueOperand(instr.value)) {\n+ validateNonRefValue(error, operand);\n+ validateNonRefObject(error, operand);\n+ }\n+ break;\n+ }\n+ default: {\n+ for (const operand of eachInstructionValueOperand(instr.value)) {\n+ validateNonRefValue(error, operand);\n+ }\n+ }\n+ }\n+ }\n+ for (const operand of eachTerminalOperand(block.terminal)) {\n+ validateNonRefValue(error, operand);\n+ }\n+ }\n+\n+ if (error.hasErrors()) {\n+ throw error;\n+ }\n+}\n+\n+\/\/ Check that the operand's type is not that of useRef().current (the ref's current value)\n+function validateNonRefValue(error: CompilerError, operand: Place): void {\n+ if (isRefValueType(operand.identifier)) {\n+ error.pushErrorDetail(\n+ new CompilerErrorDetail({\n+ codeframe: null,\n+ description: `Cannot access ref value at ${printPlace(operand)}`,\n+ loc: typeof operand.loc !== \"symbol\" ? operand.loc : null,\n+ reason:\n+ \"Ref values (the `current` property) may not be accessed during render\",\n+ severity: ErrorSeverity.InvalidInput,\n+ })\n+ );\n+ }\n+}\n+\n+\/\/ Check that the operand's type is not that of useRef() return value (the ref container)\n+function validateNonRefObject(error: CompilerError, operand: Place): void {\n+ if (isUseRefType(operand.identifier)) {\n+ error.pushErrorDetail(\n+ new CompilerErrorDetail({\n+ codeframe: null,\n+ description: `Cannot access ref object at ${printPlace(operand)}`,\n+ loc: typeof operand.loc !== \"symbol\" ? operand.loc : null,\n+ reason:\n+ \"Ref values may not be passed to functions because they could read the ref value (`current` property) during render\",\n+ severity: ErrorSeverity.InvalidInput,\n+ })\n+ );\n+ }\n+}\ndiff --git a\/compiler\/forget\/src\/HIR\/index.ts b\/compiler\/forget\/src\/HIR\/index.ts\nindex 47e296ed83..609e88ff7b 100644\n--- a\/compiler\/forget\/src\/HIR\/index.ts\n+++ b\/compiler\/forget\/src\/HIR\/index.ts\n@@ -19,5 +19,6 @@ export { mergeConsecutiveBlocks } from \".\/MergeConsecutiveBlocks\";\n export { printFunction, printHIR } from \".\/PrintHIR\";\n export { validateConsistentIdentifiers } from \".\/ValidateConsistentIdentifiers\";\n export { validateHooksUsage } from \".\/ValidateHooksUsage\";\n+export { validateNoRefAccessInRender } from \".\/ValidateNoRefAccesInRender\";\n export { validateTerminalSuccessors } from \".\/ValidateTerminalSuccessors\";\n export { validateUnconditionalHooks } from \".\/ValidateUnconditionalHooks\";\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.expect.md\nnew file mode 100644\nindex 0000000000..8a816009a2\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.expect.md\n@@ -0,0 +1,25 @@\n+\n+## Input\n+\n+```javascript\n+\/\/ @debug\n+function Component(props) {\n+ const ref = useRef(null);\n+ const value = ref.current;\n+ return value;\n+}\n+\n+```\n+\n+\n+## Error\n+\n+```\n+[ReactForget] InvalidInput: Ref values (the `current` property) may not be accessed during render. Cannot access ref value at $20:TObject (4:4)\n+\n+[ReactForget] InvalidInput: Ref values (the `current` property) may not be accessed during render. Cannot access ref value at value$21:TObject (5:5)\n+\n+[ReactForget] InvalidInput: Ref values (the `current` property) may not be accessed during render. Cannot access ref value at $23:TObject (5:5)\n+```\n+ \n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.js\nnew file mode 100644\nindex 0000000000..0be1f1047a\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.js\n@@ -0,0 +1,6 @@\n+\/\/ @debug\n+function Component(props) {\n+ const ref = useRef(null);\n+ const value = ref.current;\n+ return value;\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.expect.md\nindex 398153b4a5..e1cbf724a4 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.expect.md\n@@ -3,9 +3,9 @@\n \n ```javascript\n function Component(props) {\n- const x = useRef;\n- const ref = x(null);\n- return ref.current;\n+ const x = useState;\n+ const state = x(null);\n+ return state[0];\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.js\nindex ab676997a8..886860e4de 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.js\n@@ -1,5 +1,5 @@\n function Component(props) {\n- const x = useRef;\n- const ref = x(null);\n- return ref.current;\n+ const x = useState;\n+ const state = x(null);\n+ return state[0];\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.expect.md\nnew file mode 100644\nindex 0000000000..f90ca6a5e6\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.expect.md\n@@ -0,0 +1,20 @@\n+\n+## Input\n+\n+```javascript\n+function Component(props) {\n+ const ref = useRef(null);\n+ const x = foo(ref);\n+ return x.current;\n+}\n+\n+```\n+\n+\n+## Error\n+\n+```\n+[ReactForget] InvalidInput: Ref values may not be passed to functions because they could read the ref value (`current` property) during render. Cannot access ref object at $22:TObject (3:3)\n+```\n+ \n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.js\nnew file mode 100644\nindex 0000000000..ce93fc174c\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.js\n@@ -0,0 +1,5 @@\n+function Component(props) {\n+ const ref = useRef(null);\n+ const x = foo(ref);\n+ return x.current;\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.expect.md\nnew file mode 100644\nindex 0000000000..8cfd73d10c\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.expect.md\n@@ -0,0 +1,20 @@\n+\n+## Input\n+\n+```javascript\n+function Component(props) {\n+ const ref = useRef(null);\n+ ref.current = props.value;\n+ return ref.current;\n+}\n+\n+```\n+\n+\n+## Error\n+\n+```\n+[ReactForget] InvalidInput: Ref values (the `current` property) may not be accessed during render. Cannot access ref value at $25:TObject (4:4)\n+```\n+ \n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.js\nsimilarity index 100%\nrename from compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.js\nrename to compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.js\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.expect.md\nindex a68e34a230..351873f98a 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.expect.md\n@@ -2,6 +2,7 @@\n ## Input\n \n ```javascript\n+\/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const ref = useRef();\n const t = ref.current;\n@@ -17,7 +18,7 @@ function VideoTab() {\n ## Code\n \n ```javascript\n-import { unstable_useMemoCache as useMemoCache } from \"react\";\n+import { unstable_useMemoCache as useMemoCache } from \"react\"; \/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const $ = useMemoCache(3);\n const ref = useRef();\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.js\nindex 4ee957e987..e11fb47247 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.js\n@@ -1,3 +1,4 @@\n+\/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const ref = useRef();\n const t = ref.current;\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.expect.md\nindex b5ec176278..4a142eb308 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.expect.md\n@@ -2,6 +2,7 @@\n ## Input\n \n ```javascript\n+\/\/ @validateRefAccessDuringRender false\n function Foo({ a }) {\n const ref = useRef();\n const val = ref.current;\n@@ -15,7 +16,7 @@ function Foo({ a }) {\n ## Code\n \n ```javascript\n-import { unstable_useMemoCache as useMemoCache } from \"react\";\n+import { unstable_useMemoCache as useMemoCache } from \"react\"; \/\/ @validateRefAccessDuringRender false\n function Foo(t21) {\n const $ = useMemoCache(4);\n const { a } = t21;\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.js\nindex 1bdd040c67..92d7decf20 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.js\n@@ -1,3 +1,4 @@\n+\/\/ @validateRefAccessDuringRender false\n function Foo({ a }) {\n const ref = useRef();\n const val = ref.current;\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.expect.md\nindex 7a630ff951..bb151446f6 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.expect.md\n@@ -2,6 +2,7 @@\n ## Input\n \n ```javascript\n+\/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const ref = useRef();\n let x = () => {\n@@ -16,7 +17,7 @@ function VideoTab() {\n ## Code\n \n ```javascript\n-import { unstable_useMemoCache as useMemoCache } from \"react\";\n+import { unstable_useMemoCache as useMemoCache } from \"react\"; \/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const $ = useMemoCache(3);\n const ref = useRef();\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.js\nindex 53d4489d8c..fd5c43cdba 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.js\n@@ -1,3 +1,4 @@\n+\/\/ @validateRefAccessDuringRender false\n function VideoTab() {\n const ref = useRef();\n let x = () => {\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.expect.md\nindex 3edc16158e..bb197280f3 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.expect.md\n@@ -2,6 +2,7 @@\n ## Input\n \n ```javascript\n+\/\/ @validateRefAccessDuringRender false\n function Foo({ a }) {\n const ref = useRef();\n const x = { a, val: ref.current };\n@@ -14,7 +15,7 @@ function Foo({ a }) {\n ## Code\n \n ```javascript\n-import { unstable_useMemoCache as useMemoCache } from \"react\";\n+import { unstable_useMemoCache as useMemoCache } from \"react\"; \/\/ @validateRefAccessDuringRender false\n function Foo(t18) {\n const $ = useMemoCache(4);\n const { a } = t18;\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.js\nindex 80ced49a9d..a31a11fd3e 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.js\n@@ -1,3 +1,4 @@\n+\/\/ @validateRefAccessDuringRender false\n function Foo({ a }) {\n const ref = useRef();\n const x = { a, val: ref.current };\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.expect.md\nnew file mode 100644\nindex 0000000000..1eb8fb418b\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.expect.md\n@@ -0,0 +1,58 @@\n+\n+## Input\n+\n+```javascript\n+function Component(props) {\n+ const ref = useRef(null);\n+ const onChange = (e) => {\n+ ref.current = e.target.value;\n+ };\n+ useEffect(() => {\n+ console.log(ref.current);\n+ });\n+ return ;\n+}\n+\n+```\n+\n+## Code\n+\n+```javascript\n+import { unstable_useMemoCache as useMemoCache } from \"react\";\n+function Component(props) {\n+ const $ = useMemoCache(4);\n+ const ref = useRef(null);\n+ let t0;\n+ if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t0 = (e) => {\n+ ref.current = e.target.value;\n+ };\n+ $[0] = t0;\n+ } else {\n+ t0 = $[0];\n+ }\n+ const onChange = t0;\n+ let t1;\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t1 = () => {\n+ console.log(ref.current);\n+ };\n+ $[1] = t1;\n+ } else {\n+ t1 = $[1];\n+ }\n+ useEffect(t1);\n+ const c_2 = $[2] !== onChange;\n+ let t2;\n+ if (c_2) {\n+ t2 = ;\n+ $[2] = onChange;\n+ $[3] = t2;\n+ } else {\n+ t2 = $[3];\n+ }\n+ return t2;\n+}\n+\n+```\n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.js b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.js\nnew file mode 100644\nindex 0000000000..b26e06c529\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.js\n@@ -0,0 +1,10 @@\n+function Component(props) {\n+ const ref = useRef(null);\n+ const onChange = (e) => {\n+ ref.current = e.target.value;\n+ };\n+ useEffect(() => {\n+ console.log(ref.current);\n+ });\n+ return ;\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.expect.md\ndeleted file mode 100644\nindex 6ba63442e1..0000000000\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.expect.md\n+++ \/dev\/null\n@@ -1,23 +0,0 @@\n-\n-## Input\n-\n-```javascript\n-function Component(props) {\n- const ref = useRef(null);\n- ref.current = props.value;\n- return ref.current;\n-}\n-\n-```\n-\n-## Code\n-\n-```javascript\n-function Component(props) {\n- const ref = useRef(null);\n- ref.current = props.value;\n- return ref.current;\n-}\n-\n-```\n- \n\\ No newline at end of file\n","commit":{"authoredAt":"2023-05-31T09:38:28-07:00","subject":"Validate against ref access in render","authorName":"Joe Savona","shortRevision":"a5a86c302a","authorEmail":"joesavona@fb.com","revision":"a5a86c302aef71111be15816cbdb37ec98d6921a"},"files":[{"path":"compiler\/forget\/packages\/snap\/src\/compiler-worker.ts","status":"M"},{"path":"compiler\/forget\/src\/CompilerPipeline.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/Environment.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/ValidateNoRefAccesInRender.ts","status":"A"},{"path":"compiler\/forget\/src\/HIR\/index.ts","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-access-ref-during-render.js","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-assign-hook-to-local.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-pass-ref-to-function.js","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/error.invalid-set-and-read-ref-during-render.js","status":"R100","previousPath":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.js"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-no-added-to-dep.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-aliased-not-added-to-dep-2.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-field-not-added-to-dep.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-current-not-added-to-dep-2.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/ref-in-effect.js","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/compiler\/useRef-mutable.expect.md","status":"D"}]}

dillon1000/react

Files changed