{"body":"We already warn for all the other legacy APIs. Forgot to enable\r\nthis one.","parents":["52c393b5d261550609dda955f059a26d1db63538"],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/renderSubtreeIntoContainer-test.js b\/packages\/react-dom\/src\/__tests__\/renderSubtreeIntoContainer-test.js\nindex 99d1bd92e4..f18744a199 100644\n--- a\/packages\/react-dom\/src\/__tests__\/renderSubtreeIntoContainer-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/renderSubtreeIntoContainer-test.js\n@@ -16,8 +16,6 @@ const ReactTestUtils = require('react-dom\/test-utils');\n const renderSubtreeIntoContainer = require('react-dom')\n .unstable_renderSubtreeIntoContainer;\n \n-const ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n-\n describe('renderSubtreeIntoContainer', () => {\n it('should pass context when rendering subtree elsewhere', () => {\n const portal = document.createElement('div');\n@@ -48,18 +46,13 @@ describe('renderSubtreeIntoContainer', () => {\n }\n \n componentDidMount() {\n- if (ReactFeatureFlags.warnUnstableRenderSubtreeIntoContainer) {\n- expect(\n- function() {\n- renderSubtreeIntoContainer(this, , portal);\n- }.bind(this),\n- ).toWarnDev(\n- 'ReactDOM.unstable_renderSubtreeIntoContainer() is deprecated and ' +\n- 'will be removed in a future major release. Consider using React Portals instead.',\n- );\n- } else {\n- renderSubtreeIntoContainer(this, , portal);\n- }\n+ expect(\n+ function() {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }.bind(this),\n+ ).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \n@@ -144,11 +137,19 @@ describe('renderSubtreeIntoContainer', () => {\n }\n \n componentDidMount() {\n- renderSubtreeIntoContainer(this, , portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n \n componentDidUpdate() {\n- renderSubtreeIntoContainer(this, , portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \n@@ -192,11 +193,19 @@ describe('renderSubtreeIntoContainer', () => {\n }\n \n componentDidMount() {\n- renderSubtreeIntoContainer(this, , portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n \n componentDidUpdate() {\n- renderSubtreeIntoContainer(this, , portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \n@@ -217,7 +226,11 @@ describe('renderSubtreeIntoContainer', () => {\n }\n \n componentDidMount() {\n- renderSubtreeIntoContainer(this,

hello<\/div>, portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this,

hello<\/div>, portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \n@@ -247,7 +260,11 @@ describe('renderSubtreeIntoContainer', () => {\n return null;\n }\n componentDidMount() {\n- renderSubtreeIntoContainer(this, , portal);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \n@@ -278,7 +295,11 @@ describe('renderSubtreeIntoContainer', () => {\n return {value: this.props.value};\n }\n componentDidMount() {\n- renderSubtreeIntoContainer(this, , portal1);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal1);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n static childContextTypes = {\n value: PropTypes.string.isRequired,\n@@ -290,7 +311,11 @@ describe('renderSubtreeIntoContainer', () => {\n return null;\n }\n componentDidMount() {\n- renderSubtreeIntoContainer(this, , portal2);\n+ expect(() => {\n+ renderSubtreeIntoContainer(this, , portal2);\n+ }).toErrorDev(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported',\n+ );\n }\n }\n \ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOM.js b\/packages\/react-dom\/src\/client\/ReactDOM.js\nindex 87ba7bf361..c3f9e3fcb4 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOM.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOM.js\n@@ -39,10 +39,7 @@ import {\n import {createPortal as createPortalImpl} from 'react-reconciler\/src\/ReactPortal';\n import {canUseDOM} from 'shared\/ExecutionEnvironment';\n import ReactVersion from 'shared\/ReactVersion';\n-import {\n- warnUnstableRenderSubtreeIntoContainer,\n- enableNewReconciler,\n-} from 'shared\/ReactFeatureFlags';\n+import {enableNewReconciler} from 'shared\/ReactFeatureFlags';\n \n import {\n getInstanceFromNode,\n@@ -73,8 +70,6 @@ setAttemptHydrationAtCurrentPriority(attemptHydrationAtCurrentPriority);\n setGetCurrentUpdatePriority(getCurrentUpdatePriority);\n setAttemptHydrationAtPriority(runWithPriority);\n \n-let didWarnAboutUnstableRenderSubtreeIntoContainer = false;\n-\n if (__DEV__) {\n if (\n typeof Map !== 'function' ||\n@@ -121,19 +116,6 @@ function renderSubtreeIntoContainer(\n containerNode: Container,\n callback: ?Function,\n ) {\n- if (__DEV__) {\n- if (\n- warnUnstableRenderSubtreeIntoContainer &&\n- !didWarnAboutUnstableRenderSubtreeIntoContainer\n- ) {\n- didWarnAboutUnstableRenderSubtreeIntoContainer = true;\n- console.warn(\n- 'ReactDOM.unstable_renderSubtreeIntoContainer() is deprecated ' +\n- 'and will be removed in a future major release. Consider using ' +\n- 'React Portals instead.',\n- );\n- }\n- }\n return unstable_renderSubtreeIntoContainer(\n parentComponent,\n element,\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOMLegacy.js b\/packages\/react-dom\/src\/client\/ReactDOMLegacy.js\nindex 340e151bf8..1c53b5620b 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOMLegacy.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOMLegacy.js\n@@ -316,6 +316,15 @@ export function unstable_renderSubtreeIntoContainer(\n containerNode: Container,\n callback: ?Function,\n ) {\n+ if (__DEV__) {\n+ console.error(\n+ 'ReactDOM.unstable_renderSubtreeIntoContainer() is no longer supported ' +\n+ 'in React 18. Consider using a portal instead. Until you switch to ' +\n+ \"the createRoot API, your app will behave as if it's running React \" +\n+ '17. Learn more: https:\/\/reactjs.org\/link\/switch-to-createroot',\n+ );\n+ }\n+\n if (!isValidContainerLegacy(containerNode)) {\n throw new Error('Target container is not a DOM element.');\n }\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex 540a9d03cc..ba8a3bd437 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -19,7 +19,6 @@ export const warnAboutDeprecatedLifecycles = true;\n export const enableLazyElements = true;\n export const enableComponentStackLocations = true;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const enablePersistentOffscreenHostContainer = false;\n \n \/\/ -----------------------------------------------------------------------------\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 2e7ed5b252..5bf0f37db9 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -47,7 +47,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = false;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 1a64e8c7aa..5c97146a82 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = false;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex e4f3393fe8..b44bc97206 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = false;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex 7169629762..4b8c1b7741 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableComponentStackLocations = false;\n export const enableLegacyFBSupport = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex ec04b6be37..b6f620e2fb 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = true;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = true;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\nindex dfe9625873..dbfc8fb704 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = false;\n export const disableModulePatternComponents = false;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = false;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\nindex a9ef92b69a..95fa25cf59 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n@@ -38,7 +38,6 @@ export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\n export const disableTextareaChildren = __EXPERIMENTAL__;\n export const disableModulePatternComponents = true;\n-export const warnUnstableRenderSubtreeIntoContainer = false;\n export const warnAboutSpreadingKeyToJSX = false;\n export const enableSuspenseAvoidThisFallback = true;\n export const enableSuspenseAvoidThisFallbackFizz = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 381fa5532e..ac50fe4fd9 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -88,8 +88,6 @@ export const enableComponentStackLocations = true;\n \n export const disableTextareaChildren = __EXPERIMENTAL__;\n \n-export const warnUnstableRenderSubtreeIntoContainer = false;\n-\n \/\/ Enable forked reconciler. Piggy-backing on the \"variant\" global so that we\n \/\/ don't have to add another test dimension. The build system will compile this\n \/\/ to the correct value.\n","files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/renderSubtreeIntoContainer-test.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOM.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMLegacy.js"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"}],"commit":{"authorEmail":"git@andrewclark.io","shortRevision":"a5b22155c8","authorName":"Andrew Clark","revision":"a5b22155c8431c25df728f61869ff1616e51e133","authoredAt":"2022-02-24T01:42:22-05:00","subject":"Warn if renderSubtreeIntoContainer is called (#23355)"}}

dillon1000/react

Files changed