{"body":"Converts ~half of react-dom tests","files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/CSSPropertyOperations-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/DOMPropertyOperations-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/InvalidEventListeners-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactComponent-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactComponentLifeCycle-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactCompositeComponent-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactCompositeComponentState-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOM-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/findDOMNodeFB-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/utils\/ReactDOMServerIntegrationTestUtils.js"}],"parents":["c81312e3a78dcbf71ed98c8893abe6dbfeaef3f2"],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/CSSPropertyOperations-test.js b\/packages\/react-dom\/src\/__tests__\/CSSPropertyOperations-test.js\nindex bda95b8434..b5671cf759 100644\n--- a\/packages\/react-dom\/src\/__tests__\/CSSPropertyOperations-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/CSSPropertyOperations-test.js\n@@ -13,6 +13,8 @@ const React = require('react');\n const ReactDOMClient = require('react-dom\/client');\n const ReactDOMServer = require('react-dom\/server');\n const act = require('internal-test-utils').act;\n+const assertConsoleErrorDev =\n+ require('internal-test-utils').assertConsoleErrorDev;\n \n describe('CSSPropertyOperations', () => {\n it('should automatically append `px` to relevant styles', () => {\n@@ -103,15 +105,14 @@ describe('CSSPropertyOperations', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev(\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n 'Unsupported style property background-color. Did you mean backgroundColor?' +\n '\\n in div (at **)' +\n '\\n in Comp (at **)',\n- );\n+ ]);\n });\n \n it('should warn when updating hyphenated style names', async () => {\n@@ -132,11 +133,10 @@ describe('CSSPropertyOperations', () => {\n await act(() => {\n root.render();\n });\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev([\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n 'Unsupported style property -ms-transform. Did you mean msTransform?' +\n '\\n in div (at **)' +\n '\\n in Comp (at **)',\n@@ -165,11 +165,10 @@ describe('CSSPropertyOperations', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev([\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n \/\/ msTransform is correct already and shouldn't warn\n 'Unsupported vendor-prefixed style property oTransform. ' +\n 'Did you mean OTransform?' +\n@@ -202,11 +201,10 @@ describe('CSSPropertyOperations', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev([\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n \"Style property values shouldn't contain a semicolon. \" +\n 'Try \"backgroundColor: blue\" instead.' +\n '\\n in div (at **)' +\n@@ -229,15 +227,14 @@ describe('CSSPropertyOperations', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev(\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n '`NaN` is an invalid value for the `fontSize` css style property.' +\n '\\n in div (at **)' +\n '\\n in Comp (at **)',\n- );\n+ ]);\n });\n \n it('should not warn when setting CSS custom properties', async () => {\n@@ -265,15 +262,14 @@ describe('CSSPropertyOperations', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev(\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n '`Infinity` is an invalid value for the `fontSize` css style property.' +\n '\\n in div (at **)' +\n '\\n in Comp (at **)',\n- );\n+ ]);\n });\n \n it('should not add units to CSS custom properties', async () => {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/DOMPropertyOperations-test.js b\/packages\/react-dom\/src\/__tests__\/DOMPropertyOperations-test.js\nindex cecc71b45a..ef09e49bf3 100644\n--- a\/packages\/react-dom\/src\/__tests__\/DOMPropertyOperations-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/DOMPropertyOperations-test.js\n@@ -1333,7 +1333,8 @@ describe('DOMPropertyOperations', () => {\n });\n \n assertConsoleErrorDev([\n- 'The `popoverTarget` prop expects the ID of an Element as a string. Received HTMLDivElement {} instead.',\n+ 'The `popoverTarget` prop expects the ID of an Element as a string. Received HTMLDivElement {} instead.\\n' +\n+ ' in button (at **)',\n ]);\n \n \/\/ Dedupe warning\n@@ -1375,13 +1376,17 @@ describe('DOMPropertyOperations', () => {\n expect(container.firstChild.getAttribute('value')).toBe('foo');\n }\n expect(container.firstChild.value).toBe('foo');\n- await expect(async () => {\n- await act(() => {\n- root.render();\n- });\n- }).toErrorDev(\n- 'A component is changing a controlled input to be uncontrolled',\n- );\n+ await act(() => {\n+ root.render();\n+ });\n+ assertConsoleErrorDev([\n+ 'A component is changing a controlled input to be uncontrolled. ' +\n+ 'This is likely caused by the value changing from a defined to undefined, ' +\n+ 'which should not happen. Decide between using a controlled or uncontrolled ' +\n+ 'input element for the lifetime of the component. ' +\n+ 'More info: https:\/\/react.dev\/link\/controlled-components\\n' +\n+ ' in input (at **)',\n+ ]);\n if (disableInputAttributeSyncing) {\n expect(container.firstChild.hasAttribute('value')).toBe(false);\n } else {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/InvalidEventListeners-test.js b\/packages\/react-dom\/src\/__tests__\/InvalidEventListeners-test.js\nindex d7045d2756..8bff125c82 100644\n--- a\/packages\/react-dom\/src\/__tests__\/InvalidEventListeners-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/InvalidEventListeners-test.js\n@@ -15,13 +15,14 @@ describe('InvalidEventListeners', () => {\n let React;\n let ReactDOMClient;\n let act;\n+ let assertConsoleErrorDev;\n let container;\n \n beforeEach(() => {\n jest.resetModules();\n React = require('react');\n ReactDOMClient = require('react-dom\/client');\n- act = require('internal-test-utils').act;\n+ ({act, assertConsoleErrorDev} = require('internal-test-utils'));\n \n container = document.createElement('div');\n document.body.appendChild(container);\n@@ -34,13 +35,13 @@ describe('InvalidEventListeners', () => {\n \n it('should prevent non-function listeners, at dispatch', async () => {\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render(

);\n- });\n- }).toErrorDev(\n- 'Expected `onClick` listener to be a function, instead got a value of `string` type.',\n- );\n+ await act(() => {\n+ root.render(

);\n+ });\n+ assertConsoleErrorDev([\n+ 'Expected `onClick` listener to be a function, instead got a value of `string` type.\\n' +\n+ ' in div (at **)',\n+ ]);\n const node = container.firstChild;\n \n console.error = jest.fn();\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js b\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\nindex 1c1475534f..ba0c028fa8 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\n@@ -15,6 +15,7 @@\n let React;\n let ReactDOMClient;\n let act;\n+let assertConsoleErrorDev;\n \n describe('ReactChildReconciler', () => {\n beforeEach(() => {\n@@ -22,7 +23,7 @@ describe('ReactChildReconciler', () => {\n \n React = require('react');\n ReactDOMClient = require('react-dom\/client');\n- act = require('internal-test-utils').act;\n+ ({act, assertConsoleErrorDev} = require('internal-test-utils'));\n });\n \n function createIterable(array) {\n@@ -62,15 +63,21 @@ describe('ReactChildReconciler', () => {\n \n const container = document.createElement('div');\n const root = ReactDOMClient.createRoot(container);\n- await expect(async () => {\n- await act(() => {\n- root.render(\n-

\n-

{});\n }\n \n","commit":{"authorName":"Ricky","shortRevision":"a7c898d83a","authorEmail":"rickhanlonii@gmail.com","authoredAt":"2025-01-02T15:28:06-05:00","revision":"a7c898d83a991c48f3981fcc65d969f1d90d80a1","subject":"[assert helpers] react-dom (pt 1) (#31897)"}}

dillon1000/react

Files changed