dillon1000/react

Commit

[rfc] always create collections even if elements have errors

BuildHIR currently propagates UnsupportedNodes for collection types where the 
element itself can fail (for example object expressions where the key may not be 
valid). However, given that we currently abort compilation after the first 
failing pass (and will probably do so for quite a while) I think we can simplify 
and just always return the collection. Note that I already did this for 
destructuring. I'm open to leaving the code as-is if you prefer, though.
Browse files
Changed paths1 file
First-parent comparison
M compiler/forget/src/HIR/BuildHIR.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…