{"parents":["909cba225461a14bad100717819f54326f77f38a"],"commit":{"authorName":"jim","authoredAt":"2016-01-15T14:10:32-08:00","subject":"Removed cloneWithProps addon.","shortRevision":"accd0d874d","authorEmail":"jsproch@fb.com","revision":"accd0d874dc82990ec248f0dd74e943f3f4be270"},"body":"","files":[{"path":"grunt\/tasks\/npm-react-addons.js","status":"M"},{"path":"src\/addons\/ReactWithAddons.js","status":"M"},{"path":"src\/isomorphic\/deprecated\/__tests__\/cloneWithProps-test.js","status":"D"},{"path":"src\/isomorphic\/deprecated\/cloneWithProps.js","status":"D"}],"patch":"diff --git a\/grunt\/tasks\/npm-react-addons.js b\/grunt\/tasks\/npm-react-addons.js\nindex 67bbf783b8..238fefc60b 100644\n--- a\/grunt\/tasks\/npm-react-addons.js\n+++ b\/grunt\/tasks\/npm-react-addons.js\n@@ -36,11 +36,6 @@ var addons = {\n name: 'transition-group',\n docs: 'animation',\n },\n- cloneWithProps: {\n- module: 'cloneWithProps',\n- name: 'clone-with-props',\n- docs: 'clone-with-props',\n- },\n createFragment: {\n module: 'ReactFragment',\n method: 'create',\ndiff --git a\/src\/addons\/ReactWithAddons.js b\/src\/addons\/ReactWithAddons.js\nindex b9a8004dd8..d3cf053a25 100644\n--- a\/src\/addons\/ReactWithAddons.js\n+++ b\/src\/addons\/ReactWithAddons.js\n@@ -27,7 +27,6 @@ var ReactFragment = require('ReactFragment');\n var ReactTransitionGroup = require('ReactTransitionGroup');\n var ReactUpdates = require('ReactUpdates');\n \n-var cloneWithProps = require('cloneWithProps');\n var shallowCompare = require('shallowCompare');\n var update = require('update');\n var warning = require('warning');\n@@ -51,7 +50,6 @@ React.addons = {\n }\n return ReactUpdates.batchedUpdates.apply(this, arguments);\n },\n- cloneWithProps: cloneWithProps,\n createFragment: ReactFragment.create,\n shallowCompare: shallowCompare,\n update: update,\ndiff --git a\/src\/isomorphic\/deprecated\/__tests__\/cloneWithProps-test.js b\/src\/isomorphic\/deprecated\/__tests__\/cloneWithProps-test.js\ndeleted file mode 100644\nindex 1b96026895..0000000000\n--- a\/src\/isomorphic\/deprecated\/__tests__\/cloneWithProps-test.js\n+++ \/dev\/null\n@@ -1,196 +0,0 @@\n-\/**\n- * Copyright 2013-present, Facebook, Inc.\n- * All rights reserved.\n- *\n- * This source code is licensed under the BSD-style license found in the\n- * LICENSE file in the root directory of this source tree. An additional grant\n- * of patent rights can be found in the PATENTS file in the same directory.\n- *\n- * @emails react-core\n- *\/\n-\n-'use strict';\n-\n-var React;\n-var ReactDOM;\n-var ReactTestUtils;\n-\n-var onlyChild;\n-var cloneWithProps;\n-var emptyObject;\n-\n-describe('cloneWithProps', function() {\n-\n- beforeEach(function() {\n- jest.resetModuleRegistry();\n- React = require('React');\n- ReactDOM = require('ReactDOM');\n- ReactTestUtils = require('ReactTestUtils');\n- onlyChild = require('onlyChild');\n- cloneWithProps = require('cloneWithProps');\n- emptyObject = require('emptyObject');\n- spyOn(console, 'error');\n- });\n-\n- it('should warn once because it is deprecated', function() {\n- var Parent = React.createClass({\n- render: function() {\n- return (\n-

\n- {cloneWithProps(onlyChild(this.props.children), {})}\n- <\/div>\n- );\n- },\n- });\n- ReactTestUtils.renderIntoDocument(

<\/Parent>);\n- ReactTestUtils.renderIntoDocument(

<\/Parent>);\n- expect(console.error.argsForCall.length).toBe(1);\n- expect(console.error.argsForCall[0][0]).toContain(\n- 'cloneWithProps(...) is deprecated. ' +\n- 'Please use React.cloneElement instead.'\n- );\n- });\n-\n- it('should clone a DOM component with new props', function() {\n- var Grandparent = React.createClass({\n- render: function() {\n- return

<\/Parent>;\n- },\n- });\n- var Parent = React.createClass({\n- render: function() {\n- return (\n-

\n- {cloneWithProps(onlyChild(this.props.children), {className: 'xyz'})}\n- <\/div>\n- );\n- },\n- });\n- var component = ReactTestUtils.renderIntoDocument();\n- expect(ReactDOM.findDOMNode(component).childNodes[0].className)\n- .toBe('xyz child');\n- });\n-\n- it('should clone a composite component with new props', function() {\n-\n- var Child = React.createClass({\n- render: function() {\n- return

;\n- },\n- });\n-\n- var Grandparent = React.createClass({\n- render: function() {\n- return <\/Parent>;\n- },\n- });\n- var Parent = React.createClass({\n- render: function() {\n- return (\n-

\n- {cloneWithProps(onlyChild(this.props.children), {className: 'xyz'})}\n- <\/div>\n- );\n- },\n- });\n- var component = ReactTestUtils.renderIntoDocument();\n- expect(ReactDOM.findDOMNode(component).childNodes[0].className)\n- .toBe('xyz child');\n- });\n-\n- it('should warn when cloning with refs', function() {\n- var Grandparent = React.createClass({\n- render: function() {\n- return

<\/Parent>;\n- },\n- });\n- var Parent = React.createClass({\n- render: function() {\n- return (\n-

\n- {cloneWithProps(onlyChild(this.props.children), {className: 'xyz'})}\n- <\/div>\n- );\n- },\n- });\n-\n- var component = ReactTestUtils.renderIntoDocument();\n- expect(component.refs).toBe(emptyObject);\n- expect(console.error.argsForCall.length).toBe(2);\n- });\n-\n- it('should transfer the key property', function() {\n- var Component = React.createClass({\n- render: function() {\n- return null;\n- },\n- });\n- var clone = cloneWithProps(, {key: 'xyz'});\n- expect(clone.key).toBe('xyz');\n- });\n-\n- it('should transfer children', function() {\n- var Component = React.createClass({\n- render: function() {\n- expect(this.props.children).toBe('xyz');\n- return

;\n- },\n- });\n-\n- ReactTestUtils.renderIntoDocument(\n- cloneWithProps(, {children: 'xyz'})\n- );\n- });\n-\n- it('should shallow clone children', function() {\n- var Component = React.createClass({\n- render: function() {\n- expect(this.props.children).toBe('xyz');\n- return

;\n- },\n- });\n-\n- ReactTestUtils.renderIntoDocument(\n- cloneWithProps(xyz<\/Component>, {})\n- );\n- });\n-\n- it('should support keys and refs', function() {\n- var Component = React.createClass({\n- render: function() {\n- return

;\n- },\n- });\n-\n- var Parent = React.createClass({\n- render: function() {\n- var clone =\n- cloneWithProps(this.props.children, {key: 'xyz', ref: 'xyz'});\n- expect(clone.key).toBe('xyz');\n- expect(clone.ref).toBe('xyz');\n- return

{clone}<\/div>;\n- },\n- });\n-\n- var Grandparent = React.createClass({\n- render: function() {\n- return <\/Parent>;\n- },\n- });\n-\n- ReactTestUtils.renderIntoDocument();\n- });\n-\n- it('should overwrite props', function() {\n- var Component = React.createClass({\n- render: function() {\n- expect(this.props.myprop).toBe('xyz');\n- return

;\n- },\n- });\n-\n- ReactTestUtils.renderIntoDocument(\n- cloneWithProps(, {myprop: 'xyz'})\n- );\n- });\n-});\ndiff --git a\/src\/isomorphic\/deprecated\/cloneWithProps.js b\/src\/isomorphic\/deprecated\/cloneWithProps.js\ndeleted file mode 100644\nindex 5504d82927..0000000000\n--- a\/src\/isomorphic\/deprecated\/cloneWithProps.js\n+++ \/dev\/null\n@@ -1,63 +0,0 @@\n-\/**\n- * Copyright 2013-present, Facebook, Inc.\n- * All rights reserved.\n- *\n- * This source code is licensed under the BSD-style license found in the\n- * LICENSE file in the root directory of this source tree. An additional grant\n- * of patent rights can be found in the PATENTS file in the same directory.\n- *\n- * @providesModule cloneWithProps\n- *\/\n-\n-'use strict';\n-\n-var ReactElement = require('ReactElement');\n-var ReactPropTransferer = require('ReactPropTransferer');\n-\n-var keyOf = require('keyOf');\n-var warning = require('warning');\n-\n-var CHILDREN_PROP = keyOf({children: null});\n-\n-var didDeprecatedWarn = false;\n-\n-\/**\n- * Sometimes you want to change the props of a child passed to you. Usually\n- * this is to add a CSS class.\n- *\n- * @param {ReactElement} child child element you'd like to clone\n- * @param {object} props props you'd like to modify. className and style will be\n- * merged automatically.\n- * @return {ReactElement} a clone of child with props merged in.\n- * @deprecated\n- *\/\n-function cloneWithProps(child, props) {\n- if (__DEV__) {\n- warning(\n- didDeprecatedWarn,\n- 'cloneWithProps(...) is deprecated. ' +\n- 'Please use React.cloneElement instead.'\n- );\n- didDeprecatedWarn = true;\n- warning(\n- !child.ref,\n- 'You are calling cloneWithProps() on a child with a ref. This is ' +\n- 'dangerous because you\\'re creating a new child which will not be ' +\n- 'added as a ref to its parent.'\n- );\n- }\n-\n- var newProps = ReactPropTransferer.mergeProps(props, child.props);\n-\n- \/\/ Use `child.props.children` if it is provided.\n- if (!newProps.hasOwnProperty(CHILDREN_PROP) &&\n- child.props.hasOwnProperty(CHILDREN_PROP)) {\n- newProps.children = child.props.children;\n- }\n-\n- \/\/ The current API doesn't retain _owner, which is why this\n- \/\/ doesn't use ReactElement.cloneAndReplaceProps.\n- return ReactElement.createElement(child.type, newProps);\n-}\n-\n-module.exports = cloneWithProps;\n"}

dillon1000/react

Files changed