dillon1000/react

Commits/af6e837b60

Commit

Fix destructuring with mixed local/scope declarations

Fixes T176436488. The logic for rewriting Destructure instructions was correct, 
but the visitor implementation was accidentally dropping subsequent Destructure 
instructions within a block after encountering one that needed a rewrite. 
Switching to use the transform infra (added after this pass was written) fixes 
it.

Browse files

Joe Savona authored 2/6/2024, 6:29:53 AM af6e837b60fcdf1ae77e119f63afc4a6cff41459 Parent 0277bc4

Changed paths5 files

First-parent comparison

M compiler/packages/babel-plugin-react-forget/src/ReactiveScopes/ExtractScopeDeclarationsFromDestructuring.ts Modified A

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/sequential-destructuring-assignment-to-scope-declarations.expect.md

Added A

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/sequential-destructuring-assignment-to-scope-declarations.js

Added A

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/sequential-destructuring-both-mixed-local-and-scope-declaration.expect.md

Added A

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/sequential-destructuring-both-mixed-local-and-scope-declaration.js

Added

Patch

Files changed

Rendering syntax-highlighted changes…