{"commit":{"subject":"Add component stacks to (almost) all warnings (#17586)","revision":"b15bf36750ca4c4a5a09f2de76c5315ded1258d0","authorName":"Dan Abramov","authorEmail":"dan.abramov@gmail.com","shortRevision":"b15bf36750","authoredAt":"2019-12-12T23:47:55+00:00"},"parents":["612a76812fce2354aa37e8cbcc1b39bba3e9a97b"],"patch":"diff --git a\/packages\/create-subscription\/src\/createSubscription.js b\/packages\/create-subscription\/src\/createSubscription.js\nindex f0130dd868..0403762a05 100644\n--- a\/packages\/create-subscription\/src\/createSubscription.js\n+++ b\/packages\/create-subscription\/src\/createSubscription.js\n@@ -9,7 +9,7 @@\n \n import React from 'react';\n import invariant from 'shared\/invariant';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n type Unsubscribe = () => void;\n \n@@ -38,12 +38,10 @@ export function createSubscription(\n \n if (__DEV__) {\n if (typeof getCurrentValue !== 'function') {\n- warningWithoutStack(\n- 'Subscription must specify a getCurrentValue function',\n- );\n+ warning('Subscription must specify a getCurrentValue function');\n }\n if (typeof subscribe !== 'function') {\n- warningWithoutStack('Subscription must specify a subscribe function');\n+ warning('Subscription must specify a subscribe function');\n }\n }\n \ndiff --git a\/packages\/legacy-events\/EventPluginUtils.js b\/packages\/legacy-events\/EventPluginUtils.js\nindex 22f1d7c357..ac78119b8d 100644\n--- a\/packages\/legacy-events\/EventPluginUtils.js\n+++ b\/packages\/legacy-events\/EventPluginUtils.js\n@@ -7,7 +7,7 @@\n \n import {invokeGuardedCallbackAndCatchFirstError} from 'shared\/ReactErrorUtils';\n import invariant from 'shared\/invariant';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n export let getFiberCurrentPropsFromNode = null;\n export let getInstanceFromNode = null;\n@@ -23,7 +23,7 @@ export function setComponentTree(\n getNodeFromInstance = getNodeFromInstanceImpl;\n if (__DEV__) {\n if (!getNodeFromInstance || !getInstanceFromNode) {\n- warningWithoutStack(\n+ warning(\n 'EventPluginUtils.setComponentTree(...): Injected ' +\n 'module is missing getNodeFromInstance or getInstanceFromNode.',\n );\n@@ -52,7 +52,7 @@ if (__DEV__) {\n : 0;\n \n if (instancesIsArr !== listenersIsArr || instancesLen !== listenersLen) {\n- warningWithoutStack('EventPluginUtils: Invalid `event`.');\n+ warning('EventPluginUtils: Invalid `event`.');\n }\n };\n }\ndiff --git a\/packages\/legacy-events\/EventPropagators.js b\/packages\/legacy-events\/EventPropagators.js\nindex 022b968307..02069849bb 100644\n--- a\/packages\/legacy-events\/EventPropagators.js\n+++ b\/packages\/legacy-events\/EventPropagators.js\n@@ -10,7 +10,7 @@ import {\n traverseTwoPhase,\n traverseEnterLeave,\n } from 'shared\/ReactTreeTraversal';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n import {getListener} from '.\/EventPluginHub';\n import accumulateInto from '.\/accumulateInto';\n@@ -47,7 +47,7 @@ function listenerAtPhase(inst, event, propagationPhase: PropagationPhases) {\n function accumulateDirectionalDispatches(inst, phase, event) {\n if (__DEV__) {\n if (!inst) {\n- warningWithoutStack('Dispatching inst must not be null');\n+ warning('Dispatching inst must not be null');\n }\n }\n const listener = listenerAtPhase(inst, event, phase);\ndiff --git a\/packages\/legacy-events\/ResponderTouchHistoryStore.js b\/packages\/legacy-events\/ResponderTouchHistoryStore.js\nindex 0b02db652a..a892aeb324 100644\n--- a\/packages\/legacy-events\/ResponderTouchHistoryStore.js\n+++ b\/packages\/legacy-events\/ResponderTouchHistoryStore.js\n@@ -8,7 +8,7 @@\n *\/\n \n import invariant from 'shared\/invariant';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n import {isStartish, isMoveish, isEndish} from '.\/ResponderTopLevelEventTypes';\n \n@@ -96,7 +96,7 @@ function getTouchIdentifier({identifier}: Touch): number {\n invariant(identifier != null, 'Touch object is missing identifier.');\n if (__DEV__) {\n if (identifier > MAX_TOUCH_BANK) {\n- warningWithoutStack(\n+ warning(\n 'Touch identifier %s is greater than maximum supported %s which causes ' +\n 'performance issues backfilling array locations for all of the indices.',\n identifier,\n@@ -202,7 +202,7 @@ const ResponderTouchHistoryStore = {\n if (__DEV__) {\n const activeRecord = touchBank[touchHistory.indexOfSingleActiveTouch];\n if (activeRecord == null || !activeRecord.touchActive) {\n- warningWithoutStack('Cannot find single active touch.');\n+ warning('Cannot find single active touch.');\n }\n }\n }\ndiff --git a\/packages\/legacy-events\/SyntheticEvent.js b\/packages\/legacy-events\/SyntheticEvent.js\nindex 393f4cfda5..840da2e109 100644\n--- a\/packages\/legacy-events\/SyntheticEvent.js\n+++ b\/packages\/legacy-events\/SyntheticEvent.js\n@@ -8,7 +8,7 @@\n \/* eslint valid-typeof: 0 *\/\n \n import invariant from 'shared\/invariant';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n const EVENT_POOL_SIZE = 10;\n \n@@ -284,7 +284,7 @@ function getPooledWarningPropertyDefinition(propName, getVal) {\n \n function warn(action, result) {\n if (__DEV__) {\n- warningWithoutStack(\n+ warning(\n \"This synthetic event is reused for performance reasons. If you're seeing this, \" +\n \"you're %s `%s` on a released\/nullified synthetic event. %s. \" +\n 'If you must keep the original synthetic event around, use event.persist(). ' +\ndiff --git a\/packages\/react-cache\/src\/ReactCache.js b\/packages\/react-cache\/src\/ReactCache.js\nindex b0960cf94b..242bc7d32a 100644\n--- a\/packages\/react-cache\/src\/ReactCache.js\n+++ b\/packages\/react-cache\/src\/ReactCache.js\n@@ -8,7 +8,7 @@\n *\/\n \n import React from 'react';\n-import warningWithoutStack from 'shared\/warningWithoutStack';\n+import warning from 'shared\/warning';\n \n import {createLRU} from '.\/LRU';\n \n@@ -71,7 +71,7 @@ function identityHashFn(input) {\n input !== undefined &&\n input !== null\n ) {\n- warningWithoutStack(\n+ warning(\n 'Invalid key type. Expected a string, number, symbol, or boolean, ' +\n 'but instead received: %s' +\n '\\n\\nTo use non-primitive values as keys, you must pass a hash ' +\ndiff --git a\/packages\/react-cache\/src\/__tests__\/ReactCache-test.internal.js b\/packages\/react-cache\/src\/__tests__\/ReactCache-test.internal.js\nindex f7be9de093..726c1d840b 100644\n--- a\/packages\/react-cache\/src\/__tests__\/ReactCache-test.internal.js\n+++ b\/packages\/react-cache\/src\/__tests__\/ReactCache-test.internal.js\n@@ -172,15 +172,12 @@ describe('ReactCache', () => {\n if (__DEV__) {\n expect(() => {\n expect(Scheduler).toFlushAndYield(['App', 'Loading...']);\n- }).toWarnDev(\n- [\n- 'Invalid key type. Expected a string, number, symbol, or ' +\n- 'boolean, but instead received: Hi,100\\n\\n' +\n- 'To use non-primitive values as keys, you must pass a hash ' +\n- 'function as the second argument to createResource().',\n- ],\n- {withoutStack: true},\n- );\n+ }).toWarnDev([\n+ 'Invalid key type. Expected a string, number, symbol, or ' +\n+ 'boolean, but instead received: Hi,100\\n\\n' +\n+ 'To use non-primitive values as keys, you must pass a hash ' +\n+ 'function as the second argument to createResource().',\n+ ]);\n } else {\n expect(Scheduler).toFlushAndYield(['App', 'Loading...']);\n }\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactComponentLifeCycle-test.js b\/packages\/react-dom\/src\/__tests__\/ReactComponentLifeCycle-test.js\nindex 1984224875..8b0b0899ac 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactComponentLifeCycle-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactComponentLifeCycle-test.js\n@@ -215,7 +215,6 @@ describe('ReactComponentLifeCycle', () => {\n 'StatefulComponent: It is not recommended to assign props directly to state ' +\n \"because updates to props won't be reflected in state. \" +\n 'In most cases, it is better to use props directly.',\n- {withoutStack: true},\n );\n });\n \n@@ -240,7 +239,6 @@ describe('ReactComponentLifeCycle', () => {\n 'This is a no-op, but it might indicate a bug in your application. ' +\n 'Instead, assign to `this.state` directly or define a `state = {};` ' +\n 'class property with the desired state in the StatefulComponent component.',\n- {withoutStack: true},\n );\n \n \/\/ Check deduplication; (no extra warnings should be logged).\n@@ -271,9 +269,7 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => {\n const instance = ReactTestUtils.renderIntoDocument(element);\n expect(instance._isMounted()).toBeTruthy();\n- }).toWarnDev('Component is accessing isMounted inside its render()', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Component is accessing isMounted inside its render()');\n });\n \n it('should correctly determine if a null component is mounted', () => {\n@@ -300,9 +296,7 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => {\n const instance = ReactTestUtils.renderIntoDocument(element);\n expect(instance._isMounted()).toBeTruthy();\n- }).toWarnDev('Component is accessing isMounted inside its render()', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Component is accessing isMounted inside its render()');\n });\n \n it('isMounted should return false when unmounted', () => {\n@@ -340,9 +334,7 @@ describe('ReactComponentLifeCycle', () => {\n \n expect(() => {\n ReactTestUtils.renderIntoDocument();\n- }).toWarnDev('Component is accessing findDOMNode inside its render()', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Component is accessing findDOMNode inside its render()');\n });\n \n it('should carry through each of the phases of setup', () => {\n@@ -408,7 +400,6 @@ describe('ReactComponentLifeCycle', () => {\n instance = ReactDOM.render(, container);\n }).toWarnDev(\n 'LifeCycleComponent is accessing isMounted inside its render() function',\n- {withoutStack: true},\n );\n \n \/\/ getInitialState\n@@ -705,7 +696,6 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => {\n expect(() => ReactDOM.render(, container)).toWarnDev(\n 'Unsafe legacy lifecycles will not be called for components using new component APIs.',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(\n [\n@@ -744,7 +734,6 @@ describe('ReactComponentLifeCycle', () => {\n ReactDOM.render(, container),\n ).toWarnDev(\n 'Unsafe legacy lifecycles will not be called for components using new component APIs.',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(\n [\n@@ -780,7 +769,6 @@ describe('ReactComponentLifeCycle', () => {\n const container = document.createElement('div');\n expect(() => ReactDOM.render(, container)).toWarnDev(\n 'Unsafe legacy lifecycles will not be called for components using new component APIs.',\n- {withoutStack: true},\n );\n ReactDOM.render(, container);\n });\n@@ -812,7 +800,6 @@ describe('ReactComponentLifeCycle', () => {\n ' componentWillUpdate\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(\n [\n@@ -839,7 +826,6 @@ describe('ReactComponentLifeCycle', () => {\n ' UNSAFE_componentWillMount\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n \n class WillMountAndUpdate extends React.Component {\n@@ -864,7 +850,6 @@ describe('ReactComponentLifeCycle', () => {\n ' UNSAFE_componentWillUpdate\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(['componentWillMount has been renamed'], {\n withoutStack: true,\n@@ -888,7 +873,6 @@ describe('ReactComponentLifeCycle', () => {\n ' componentWillReceiveProps\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(['componentWillReceiveProps has been renamed'], {\n withoutStack: true,\n@@ -921,7 +905,6 @@ describe('ReactComponentLifeCycle', () => {\n ' componentWillUpdate\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(\n [\n@@ -947,7 +930,6 @@ describe('ReactComponentLifeCycle', () => {\n ' UNSAFE_componentWillMount\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n \n class WillMountAndUpdate extends React.Component {\n@@ -971,7 +953,6 @@ describe('ReactComponentLifeCycle', () => {\n ' UNSAFE_componentWillUpdate\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(['componentWillMount has been renamed'], {\n withoutStack: true,\n@@ -994,7 +975,6 @@ describe('ReactComponentLifeCycle', () => {\n ' componentWillReceiveProps\\n\\n' +\n 'The above lifecycles should be removed. Learn more about this warning here:\\n' +\n 'https:\/\/fb.me\/react-unsafe-component-lifecycles',\n- {withoutStack: true},\n );\n }).toLowPriorityWarnDev(['componentWillReceiveProps has been renamed'], {\n withoutStack: true,\n@@ -1045,7 +1025,6 @@ describe('ReactComponentLifeCycle', () => {\n \"If you can't use a class try assigning the prototype on the function as a workaround. \" +\n '`Parent.prototype = React.Component.prototype`. ' +\n \"Don't use an arrow function since it cannot be called with `new` by React.\",\n- {withoutStack: true},\n );\n ReactDOM.render( c && log.push('ref')} \/>, div);\n \n@@ -1074,7 +1053,6 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => ReactDOM.render(, div)).toWarnDev(\n 'MyComponent.getDerivedStateFromProps(): A valid state object (or null) must ' +\n 'be returned. You have returned undefined.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\n@@ -1097,7 +1075,6 @@ describe('ReactComponentLifeCycle', () => {\n 'undefined. This is not recommended. Instead, define the initial state by ' +\n 'assigning an object to `this.state` in the constructor of `MyComponent`. ' +\n 'This ensures that `getDerivedStateFromProps` arguments have a consistent shape.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\n@@ -1366,7 +1343,6 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => ReactDOM.render(, div)).toWarnDev(\n 'MyComponent.getSnapshotBeforeUpdate(): A snapshot value (or null) must ' +\n 'be returned. You have returned undefined.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\n@@ -1387,7 +1363,6 @@ describe('ReactComponentLifeCycle', () => {\n expect(() => ReactDOM.render(, div)).toWarnDev(\n 'MyComponent: getSnapshotBeforeUpdate() should be used with componentDidUpdate(). ' +\n 'This component defines getSnapshotBeforeUpdate() only.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponent-test.js\nindex 7766944ec6..cede35d72a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponent-test.js\n@@ -124,7 +124,6 @@ describe('ReactCompositeComponent', () => {\n \"If you can't use a class try assigning the prototype on the function as a workaround. \" +\n '`Child.prototype = React.Component.prototype`. ' +\n \"Don't use an arrow function since it cannot be called with `new` by React.\",\n- {withoutStack: true},\n );\n \n expect(el.textContent).toBe('test');\n@@ -287,7 +286,6 @@ describe('ReactCompositeComponent', () => {\n 'This is a no-op, but it might indicate a bug in your application. ' +\n 'Instead, assign to `this.state` directly or define a `state = {};` ' +\n 'class property with the desired state in the MyComponent component.',\n- {withoutStack: true},\n );\n \n \/\/ No additional warning should be recorded\n@@ -312,7 +310,6 @@ describe('ReactCompositeComponent', () => {\n 'This is a no-op, but it might indicate a bug in your application. ' +\n 'Instead, assign to `this.state` directly or define a `state = {};` ' +\n 'class property with the desired state in the MyComponent component.',\n- {withoutStack: true},\n );\n \n \/\/ No additional warning should be recorded\n@@ -440,7 +437,6 @@ describe('ReactCompositeComponent', () => {\n 'Warning: The component appears to have a render method, ' +\n \"but doesn't extend React.Component. This is likely to cause errors. \" +\n 'Change ClassWithRenderNotExtended to extend React.Component instead.',\n- {withoutStack: true},\n );\n \n \/\/ Test deduplication\n@@ -475,7 +471,6 @@ describe('ReactCompositeComponent', () => {\n }).toWarnDev(\n 'Cannot update during an existing state transition (such as within ' +\n '`render`). Render methods should be a pure function of props and state.',\n- {withoutStack: true},\n );\n \n \/\/ The setState call is queued and then executed as a second pass. This\n@@ -523,7 +518,6 @@ describe('ReactCompositeComponent', () => {\n instance = ReactDOM.render(, container);\n }).toWarnDev(\n 'Warning: setState(...): Cannot call setState() inside getChildContext()',\n- {withoutStack: true},\n );\n \n expect(renderPasses).toBe(2);\n@@ -600,7 +594,6 @@ describe('ReactCompositeComponent', () => {\n expect(() => instance.setState({bogus: true})).toWarnDev(\n 'Warning: Component.shouldComponentUpdate(): Returned undefined instead of a ' +\n 'boolean value. Make sure to return true or false.',\n- {withoutStack: true},\n );\n });\n \n@@ -617,7 +610,6 @@ describe('ReactCompositeComponent', () => {\n 'Warning: Component has a method called ' +\n 'componentDidUnmount(). But there is no such lifecycle method. ' +\n 'Did you mean componentWillUnmount()?',\n- {withoutStack: true},\n );\n });\n \n@@ -636,7 +628,6 @@ describe('ReactCompositeComponent', () => {\n 'If you meant to update the state in response to changing props, ' +\n 'use componentWillReceiveProps(). If you meant to fetch data or ' +\n 'run side-effects or mutations after React has updated the UI, use componentDidUpdate().',\n- {withoutStack: true},\n );\n });\n \n@@ -655,7 +646,6 @@ describe('ReactCompositeComponent', () => {\n expect(() => ReactTestUtils.renderIntoDocument()).toWarnDev(\n 'Warning: Setting defaultProps as an instance property on Component is not supported ' +\n 'and will be ignored. Instead, define defaultProps as a static property on Component.',\n- {withoutStack: true},\n );\n });\n \n@@ -1146,7 +1136,6 @@ describe('ReactCompositeComponent', () => {\n 'triggering nested component updates from render is not allowed. If ' +\n 'necessary, trigger nested updates in componentDidUpdate.\\n\\nCheck the ' +\n 'render method of Outer.',\n- {withoutStack: true},\n );\n });\n \n@@ -1438,7 +1427,6 @@ describe('ReactCompositeComponent', () => {\n expect(() => ReactDOM.render(, container)).toWarnDev(\n 'Foo(...): When calling super() in `Foo`, make sure to pass ' +\n \"up the same props that your component's constructor was passed.\",\n- {withoutStack: true},\n );\n });\n \n@@ -1737,17 +1725,14 @@ describe('ReactCompositeComponent', () => {\n expect(() => {\n ReactTestUtils.renderIntoDocument();\n }).toThrow();\n- }).toWarnDev(\n- [\n- \/\/ Expect two errors because invokeGuardedCallback will dispatch an error event,\n- \/\/ Causing the warning to be logged again.\n- 'Warning: RenderTextInvalidConstructor(...): No `render` method found on the returned component instance: ' +\n- 'did you accidentally return an object from the constructor?',\n- 'Warning: RenderTextInvalidConstructor(...): No `render` method found on the returned component instance: ' +\n- 'did you accidentally return an object from the constructor?',\n- ],\n- {withoutStack: true},\n- );\n+ }).toWarnDev([\n+ \/\/ Expect two errors because invokeGuardedCallback will dispatch an error event,\n+ \/\/ Causing the warning to be logged again.\n+ 'Warning: RenderTextInvalidConstructor(...): No `render` method found on the returned component instance: ' +\n+ 'did you accidentally return an object from the constructor?',\n+ 'Warning: RenderTextInvalidConstructor(...): No `render` method found on the returned component instance: ' +\n+ 'did you accidentally return an object from the constructor?',\n+ ]);\n });\n \n it('should warn about reassigning this.props while rendering', () => {\n@@ -1776,17 +1761,14 @@ describe('ReactCompositeComponent', () => {\n expect(() => {\n ReactTestUtils.renderIntoDocument();\n }).toThrow();\n- }).toWarnDev(\n- [\n- \/\/ Expect two errors because invokeGuardedCallback will dispatch an error event,\n- \/\/ Causing the warning to be logged again.\n- 'Warning: RenderTestUndefinedRender(...): No `render` method found on the returned ' +\n- 'component instance: you may have forgotten to define `render`.',\n- 'Warning: RenderTestUndefinedRender(...): No `render` method found on the returned ' +\n- 'component instance: you may have forgotten to define `render`.',\n- ],\n- {withoutStack: true},\n- );\n+ }).toWarnDev([\n+ \/\/ Expect two errors because invokeGuardedCallback will dispatch an error event,\n+ \/\/ Causing the warning to be logged again.\n+ 'Warning: RenderTestUndefinedRender(...): No `render` method found on the returned ' +\n+ 'component instance: you may have forgotten to define `render`.',\n+ 'Warning: RenderTestUndefinedRender(...): No `render` method found on the returned ' +\n+ 'component instance: you may have forgotten to define `render`.',\n+ ]);\n });\n \n \/\/ Regression test for accidental breaking change\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponentState-test.js b\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponentState-test.js\nindex 3c28f48337..4bee754661 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponentState-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactCompositeComponentState-test.js\n@@ -410,7 +410,6 @@ describe('ReactCompositeComponent-state', () => {\n 'Warning: Test.componentWillReceiveProps(): Assigning directly to ' +\n \"this.state is deprecated (except inside a component's constructor). \" +\n 'Use setState instead.',\n- {withoutStack: true},\n );\n \n expect(ops).toEqual([\n@@ -452,7 +451,6 @@ describe('ReactCompositeComponent-state', () => {\n 'Warning: Test.componentWillMount(): Assigning directly to ' +\n \"this.state is deprecated (except inside a component's constructor). \" +\n 'Use setState instead.',\n- {withoutStack: true},\n );\n \n expect(ops).toEqual([\n@@ -480,7 +478,6 @@ describe('ReactCompositeComponent-state', () => {\n \"If you can't use a class try assigning the prototype on the function as a workaround. \" +\n '`Child.prototype = React.Component.prototype`. ' +\n \"Don't use an arrow function since it cannot be called with `new` by React.\",\n- {withoutStack: true},\n );\n \n expect(el.textContent).toBe('count:123');\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\nindex 6f4efc14f9..bade522f65 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\n@@ -81,9 +81,7 @@ describe('ReactDOMRoot', () => {\n \n <\/div>,\n );\n- expect(() => Scheduler.unstable_flushAll()).toWarnDev('Extra attributes', {\n- withoutStack: true,\n- });\n+ expect(() => Scheduler.unstable_flushAll()).toWarnDev('Extra attributes');\n });\n \n it('does not clear existing children', async () => {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerLifecycles-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerLifecycles-test.js\nindex 4aed0e0246..2cd1dbe325 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerLifecycles-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerLifecycles-test.js\n@@ -183,7 +183,6 @@ describe('ReactDOMServerLifecycles', () => {\n expect(() => ReactDOMServer.renderToString()).toWarnDev(\n 'Component.getDerivedStateFromProps(): A valid state object (or null) must ' +\n 'be returned. You have returned undefined.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\n@@ -205,7 +204,6 @@ describe('ReactDOMServerLifecycles', () => {\n 'undefined. This is not recommended. Instead, define the initial state by ' +\n 'assigning an object to `this.state` in the constructor of `Component`. ' +\n 'This ensures that `getDerivedStateFromProps` arguments have a consistent shape.',\n- {withoutStack: true},\n );\n \n \/\/ De-duped\n@@ -229,9 +227,7 @@ describe('ReactDOMServerLifecycles', () => {\n \n expect(() =>\n ReactDOMServer.renderToString(),\n- ).toLowPriorityWarnDev('componentWillMount has been renamed', {\n- withoutStack: true,\n- });\n+ ).toLowPriorityWarnDev('componentWillMount has been renamed');\n expect(log).toEqual(['componentWillMount', 'UNSAFE_componentWillMount']);\n });\n \n@@ -266,7 +262,6 @@ describe('ReactDOMServerLifecycles', () => {\n 'usually means you called setState() outside componentWillMount() on ' +\n 'the server. This is a no-op.\\n\\n' +\n 'Please check the code for the Outer component.',\n- {withoutStack: true},\n );\n });\n \n@@ -286,9 +281,7 @@ describe('ReactDOMServerLifecycles', () => {\n \n expect(() =>\n ReactDOMServer.renderToString(),\n- ).toLowPriorityWarnDev('componentWillMount has been renamed', {\n- withoutStack: true,\n- });\n+ ).toLowPriorityWarnDev('componentWillMount has been renamed');\n });\n \n it('should warn about deprecated lifecycle hooks', () => {\n@@ -301,9 +294,7 @@ describe('ReactDOMServerLifecycles', () => {\n \n expect(() =>\n ReactDOMServer.renderToString(),\n- ).toLowPriorityWarnDev('componentWillMount has been renamed', {\n- withoutStack: true,\n- });\n+ ).toLowPriorityWarnDev('componentWillMount has been renamed');\n \n \/\/ De-duped\n ReactDOMServer.renderToString();\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js\nindex ce89d56e23..cf24ee3d82 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js\n@@ -44,7 +44,6 @@ describe('ReactDeprecationWarnings', () => {\n 'Warning: FunctionalComponent: Support for defaultProps ' +\n 'will be removed from function components in a future major ' +\n 'release. Use JavaScript default parameters instead.',\n- {withoutStack: true},\n );\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactErrorBoundaries-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactErrorBoundaries-test.internal.js\nindex 3dea42709a..dce7a69697 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactErrorBoundaries-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactErrorBoundaries-test.internal.js\n@@ -815,7 +815,6 @@ describe('ReactErrorBoundaries', () => {\n \"If you can't use a class try assigning the prototype on the function as a workaround. \" +\n '`BrokenComponentWillMountWithContext.prototype = React.Component.prototype`. ' +\n \"Don't use an arrow function since it cannot be called with `new` by React.\",\n- {withoutStack: true},\n );\n \n expect(container.firstChild.textContent).toBe('Caught an error: Hello.');\n@@ -2244,7 +2243,6 @@ describe('ReactErrorBoundaries', () => {\n }).toWarnDev(\n 'InvalidErrorBoundary: Error boundaries should implement getDerivedStateFromError(). ' +\n 'In that method, return a state update to display an error message or fallback UI.',\n- {withoutStack: true},\n );\n expect(container.textContent).toBe('');\n });\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\nindex 685a1cffb9..db36eca037 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\n@@ -111,7 +111,6 @@ describe('ReactFunctionComponent', () => {\n ).toWarnDev(\n 'FunctionComponentWithChildContext: Function ' +\n 'components do not support getDerivedStateFromProps.',\n- {withoutStack: true},\n );\n });\n \n@@ -134,7 +133,6 @@ describe('ReactFunctionComponent', () => {\n ).toWarnDev(\n 'FunctionComponentWithChildContext(...): childContextTypes cannot ' +\n 'be defined on a function component.',\n- {withoutStack: true},\n );\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactLegacyContextDisabled-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactLegacyContextDisabled-test.internal.js\nindex f788748aa9..337eb4a264 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactLegacyContextDisabled-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactLegacyContextDisabled-test.internal.js\n@@ -90,17 +90,14 @@ describe('ReactLegacyContextDisabled', () => {\n <\/LegacyProvider>,\n container,\n );\n- }).toWarnDev(\n- [\n- 'LegacyProvider uses the legacy childContextTypes API which is no longer supported. ' +\n- 'Use React.createContext() instead.',\n- 'LegacyClsConsumer uses the legacy contextTypes API which is no longer supported. ' +\n- 'Use React.createContext() with static contextType instead.',\n- 'LegacyFnConsumer uses the legacy contextTypes API which is no longer supported. ' +\n- 'Use React.createContext() with React.useContext() instead.',\n- ],\n- {withoutStack: true},\n- );\n+ }).toWarnDev([\n+ 'LegacyProvider uses the legacy childContextTypes API which is no longer supported. ' +\n+ 'Use React.createContext() instead.',\n+ 'LegacyClsConsumer uses the legacy contextTypes API which is no longer supported. ' +\n+ 'Use React.createContext() with static contextType instead.',\n+ 'LegacyFnConsumer uses the legacy contextTypes API which is no longer supported. ' +\n+ 'Use React.createContext() with React.useContext() instead.',\n+ ]);\n expect(container.textContent).toBe('{}undefinedundefined');\n expect(lifecycleContextLog).toEqual([]);\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactLegacyErrorBoundaries-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactLegacyErrorBoundaries-test.internal.js\nindex 30a6d0c30b..85c024431e 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactLegacyErrorBoundaries-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactLegacyErrorBoundaries-test.internal.js\n@@ -847,7 +847,6 @@ describe('ReactLegacyErrorBoundaries', () => {\n \"If you can't use a class try assigning the prototype on the function as a workaround. \" +\n '`BrokenComponentWillMountWithContext.prototype = React.Component.prototype`. ' +\n \"Don't use an arrow function since it cannot be called with `new` by React.\",\n- {withoutStack: true},\n );\n expect(container.firstChild.textContent).toBe('Caught an error: Hello.');\n });\n@@ -2117,7 +2116,6 @@ describe('ReactLegacyErrorBoundaries', () => {\n );\n }).toWarnDev(\n 'ErrorBoundary: Error boundaries should implement getDerivedStateFromError()',\n- {withoutStack: true},\n );\n expect(container.firstChild.textContent).toBe('Sibling');\n expect(log).toEqual([\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactMount-test.js b\/packages\/react-dom\/src\/__tests__\/ReactMount-test.js\nindex e99db093d5..2511ad0e6a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactMount-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactMount-test.js\n@@ -137,7 +137,6 @@ describe('ReactMount', () => {\n \n expect(() => ReactDOM.hydrate(

, container)).toWarnDev(\n 'Did not expect server HTML to contain the text node \" \" in .',\n- {withoutStack: true},\n );\n });\n \n@@ -175,7 +174,6 @@ describe('ReactMount', () => {\n ).toWarnDev(\n 'Server: \"This markup contains an nbsp entity: server text\" ' +\n 'Client: \"This markup contains an nbsp entity: client text\"',\n- {withoutStack: true},\n );\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactRenderDocument-test.js b\/packages\/react-dom\/src\/__tests__\/ReactRenderDocument-test.js\nindex 32903540eb..1619111520 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactRenderDocument-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactRenderDocument-test.js\n@@ -203,9 +203,7 @@ describe('rendering React components at document', () => {\n 'with ReactDOM.hydrate() if you want React to attach to the server HTML.',\n {withoutStack: true},\n );\n- }).toWarnDev('Warning: Text content did not match.', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Warning: Text content did not match.');\n });\n \n it('should throw on full document render w\/ no markup', () => {\n@@ -373,7 +371,6 @@ describe('rendering React components at document', () => {\n container.textContent = 'potato';\n expect(() => ReactDOM.hydrate(

parsnip<\/div>, container)).toWarnDev(\n 'Expected server HTML to contain a matching

.',\n- {withoutStack: true},\n );\n expect(container.textContent).toBe('parsnip');\n });\n@@ -399,9 +396,7 @@ describe('rendering React components at document', () => {\n \n expect(() =>\n ReactDOM.hydrate(, testDocument),\n- ).toWarnDev('Warning: Text content did not match.', {\n- withoutStack: true,\n- });\n+ ).toWarnDev('Warning: Text content did not match.');\n expect(testDocument.body.innerHTML).toBe('Hello world');\n });\n \n@@ -424,9 +419,7 @@ describe('rendering React components at document', () => {\n \/\/ getTestDocument() has an extra that we didn't render.\n expect(() =>\n ReactDOM.hydrate(, testDocument),\n- ).toWarnDev('Did not expect server HTML to contain a in .', {\n- withoutStack: true,\n- });\n+ ).toWarnDev('Did not expect server HTML to contain a in .');\n expect(testDocument.body.innerHTML).toBe('Hello world');\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js b\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\nindex 54edfacb84..5a80060abe 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\n@@ -856,7 +856,6 @@ describe('ReactDOMServer', () => {\n 'Warning: The component appears to have a render method, ' +\n \"but doesn't extend React.Component. This is likely to cause errors. \" +\n 'Change ClassWithRenderNotExtended to extend React.Component instead.',\n- {withoutStack: true},\n );\n \n \/\/ Test deduplication\n@@ -1022,7 +1021,6 @@ describe('ReactDOMServer', () => {\n 'Warning: ComponentA defines an invalid contextType. ' +\n 'contextType should point to the Context object returned by React.createContext(). ' +\n 'Did you accidentally pass the Context.Consumer instead?',\n- {withoutStack: true},\n );\n \n \/\/ Warnings should be deduped by component type\n@@ -1034,7 +1032,6 @@ describe('ReactDOMServer', () => {\n 'Warning: ComponentB defines an invalid contextType. ' +\n 'contextType should point to the Context object returned by React.createContext(). ' +\n 'Did you accidentally pass the Context.Provider instead?',\n- {withoutStack: true},\n );\n });\n \n@@ -1072,7 +1069,6 @@ describe('ReactDOMServer', () => {\n 'This can be caused by a typo or by mixing up named and default imports. ' +\n 'This can also happen due to a circular dependency, ' +\n 'so try moving the createContext() call to a separate file.',\n- {withoutStack: true},\n );\n });\n \n@@ -1096,7 +1092,6 @@ describe('ReactDOMServer', () => {\n 'Foo defines an invalid contextType. ' +\n 'contextType should point to the Context object returned by React.createContext(). ' +\n 'However, it is set to an object with keys {x, y}.',\n- {withoutStack: true},\n );\n });\n \n@@ -1116,7 +1111,6 @@ describe('ReactDOMServer', () => {\n 'Foo defines an invalid contextType. ' +\n 'contextType should point to the Context object returned by React.createContext(). ' +\n 'However, it is set to a string.',\n- {withoutStack: true},\n );\n });\n });\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\nindex 64ed76d90b..81969a89d5 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n@@ -104,9 +104,7 @@ describe('ReactDOMServerHydration', () => {\n element.innerHTML = lastMarkup;\n expect(() => {\n instance = ReactDOM.render(, element);\n- }).toWarnDev('Text content did not match. Server: \"x\" Client: \"y\"', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Text content did not match. Server: \"x\" Client: \"y\"');\n expect(mountCount).toEqual(4);\n expect(element.innerHTML.length > 0).toBe(true);\n expect(element.innerHTML).not.toEqual(lastMarkup);\n@@ -189,9 +187,7 @@ describe('ReactDOMServerHydration', () => {\n element.innerHTML = lastMarkup;\n expect(() => {\n instance = ReactDOM.hydrate(, element);\n- }).toWarnDev('Text content did not match. Server: \"x\" Client: \"y\"', {\n- withoutStack: true,\n- });\n+ }).toWarnDev('Text content did not match. Server: \"x\" Client: \"y\"');\n expect(mountCount).toEqual(4);\n expect(element.innerHTML.length > 0).toBe(true);\n expect(element.innerHTML).not.toEqual(lastMarkup);\n@@ -254,7 +250,6 @@ describe('ReactDOMServerHydration', () => {\n ReactDOM.hydrate(

dillon1000/react

Files changed