dillon1000/react

Commit

[babel] Make gating option a pair of module and project

There are some internal restrictions in Metro that only allow us to specify one 
gating module as an injected dependency. To allow multiple projects, this PR 
updates the Babel plugin to take a gating options config specifiying a project 
name. The project name is used as a suffix for the generated import; for 
example: 

```js 

const options = { 

// ... 

gating: { 

module: "ReactForgetFeatureFlag", 

importSpecifierName: "isForgetEnabled_Secret", 

}; 

// generates 

import {isForgetEnabled_Secret} from "ReactForgetFeatureFlag"; // a module that 
exports multiple flags 

// ... 

```
Browse files
Changed paths21 files
First-parent comparison
M compiler/forget/src/Babel/BabelPlugin.ts ModifiedM compiler/forget/src/Babel/PluginOptions.ts ModifiedM compiler/forget/src/__tests__/compiler-test.ts ModifiedM compiler/forget/src/__tests__/disableMemoizeJsxElements-test.ts ModifiedM compiler/forget/src/__tests__/fixtures/compiler/arrow-function-expr-gating-test.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/arrow-function-expr-gating-test.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/error._todo.multi-arrow-expr-export-default-gating-test.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/error._todo.multi-arrow-expr-export-default-gating-test.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-default-function.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-default-function.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-function-and-default.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-function-and-default.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-function.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test-export-function.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/gating-test.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/multi-arrow-expr-export-gating-test.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/multi-arrow-expr-export-gating-test.js ModifiedM compiler/forget/src/__tests__/fixtures/compiler/multi-arrow-expr-gating-test.expect.md ModifiedM compiler/forget/src/__tests__/fixtures/compiler/multi-arrow-expr-gating-test.js ModifiedM compiler/forget/src/__tests__/test-utils/generateTestsFromFixtures.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…