{"commit":{"authoredAt":"2023-01-13T16:33:04+00:00","subject":"[be] Don't show duplicate codegen tab","revision":"b1eb22d94159e7e829fd0cb93e9c60e28f228ea0","authorEmail":"gsathya.ceg@gmail.com","authorName":"Sathya Gunasekaran","shortRevision":"b1eb22d941"},"body":"The JS tab and the codegen tab are the same.","parents":["ddc135cf40b8e323f7b0bd03165127e958368b82"],"files":[{"status":"M","path":"compiler\/forget\/packages\/playground\/components\/Editor\/Output.tsx"}],"patch":"diff --git a\/compiler\/forget\/packages\/playground\/components\/Editor\/Output.tsx b\/compiler\/forget\/packages\/playground\/components\/Editor\/Output.tsx\nindex f4f9c38ecd..2d691b9b8f 100644\n--- a\/compiler\/forget\/packages\/playground\/components\/Editor\/Output.tsx\n+++ b\/compiler\/forget\/packages\/playground\/components\/Editor\/Output.tsx\n@@ -61,24 +61,12 @@ function compile(source: string): Map | CompilerError {\n \n \/\/ TODO: Handle multiple functions\n const func = astFunctions[0];\n-\n const tabs = new Map();\n- const generator = run(func);\n- let ast;\n- while (true) {\n- const next = generator.next();\n- if (next.done) {\n- ast = next.value;\n- break;\n- }\n- const result = next.value;\n+ let ast: t.Function | null = null;\n+ for (const result of run(func)) {\n switch (result.kind) {\n case \"ast\": {\n- const { code } = codegen(result.value, source);\n- tabs.set(\n- result.name,\n- <\/TextTabContent>\n- );\n+ ast = result.value;\n break;\n }\n case \"hir\": {\n@@ -104,19 +92,21 @@ function compile(source: string): Map | CompilerError {\n }\n \/\/ Ensure that JS and the JS source map come first\n const reorderedTabs = new Map();\n- const { code, sourceMapUrl } = codegen(ast, source);\n- reorderedTabs.set(\"JS\", <\/TextTabContent>);\n- if (sourceMapUrl) {\n- reorderedTabs.set(\n- \"SourceMap\",\n- <>\n- \n- <\/>\n- );\n+ if (ast !== null) {\n+ const { code, sourceMapUrl } = codegen(ast, source);\n+ reorderedTabs.set(\"JS\", <\/TextTabContent>);\n+ if (sourceMapUrl) {\n+ reorderedTabs.set(\n+ \"SourceMap\",\n+ <>\n+ \n+ <\/>\n+ );\n+ }\n }\n tabs.forEach((tab, name) => {\n reorderedTabs.set(name, tab);\n"}

dillon1000/react

Files changed