{"parents":["14d0a22ae8a0063003c7291dee67615efc9f6607","ba418c6014a3c812b2efb97f40f0a65609394181"],"commit":{"subject":"Merge pull request #2480 from spicyj\/text-stability","authorName":"Paul O’Shannessy","shortRevision":"b243f1eec6","revision":"b243f1eec6c4363b15250f9bf2ed5b653b689c73","authoredAt":"2014-11-07T16:56:58-08:00","authorEmail":"paul@oshannessy.com"},"files":[{"path":"src\/core\/__tests__\/ReactTextComponent-test.js","status":"M"}],"body":"Test that text spans aren't remounted needlessly","patch":"diff --git a\/src\/core\/__tests__\/ReactTextComponent-test.js b\/src\/core\/__tests__\/ReactTextComponent-test.js\nindex cbea2d4072..60a8cfc028 100644\n--- a\/src\/core\/__tests__\/ReactTextComponent-test.js\n+++ b\/src\/core\/__tests__\/ReactTextComponent-test.js\n@@ -18,12 +18,28 @@ describe('ReactTextComponent', function() {\n React = require('React');\n });\n \n- it('should escape the rootID', function(){\n+ it('should escape the rootID', function() {\n var ThisThingShouldBeEscaped = '\">>> LULZ <<<\"';\n var ThisThingWasBeEscaped = '">>> LULZ <<<"';\n var thing =

LULZ<\/span><\/div>;\n var html = React.renderToString(thing);\n expect(html).not.toContain(ThisThingShouldBeEscaped);\n expect(html).toContain(ThisThingWasBeEscaped);\n- })\n+ });\n+\n+ it('updates a mounted text component in place', function() {\n+ var el = document.createElement('div');\n+ var inst = React.render(

{'foo'}{'bar'}<\/div>, el);\n+\n+ var foo = inst.getDOMNode().children[0];\n+ var bar = inst.getDOMNode().children[1];\n+ expect(foo.tagName).toBe('SPAN');\n+ expect(bar.tagName).toBe('SPAN');\n+\n+ var inst = React.render(

{'baz'}{'qux'}<\/div>, el);\n+ \/\/ After the update, the spans should have stayed in place (as opposed to\n+ \/\/ getting unmounted and remounted)\n+ expect(inst.getDOMNode().children[0]).toBe(foo);\n+ expect(inst.getDOMNode().children[1]).toBe(bar);\n+ });\n });\n"}

dillon1000/react

Files changed