{"commit":{"authorEmail":"sebastian@calyptus.eu","authorName":"Sebastian Markbåge","authoredAt":"2017-01-26T07:15:36-08:00","shortRevision":"b26265718a","subject":"Merge pull request #8840 from sebmarkbage\/statelesscoroutines","revision":"b26265718aad394333f3c7f9cc08295ffc750501"},"body":"[Fiber] Simplify coroutines by making yields stateless","files":[{"path":"scripts\/fiber\/tests-passing.txt","status":"M"},{"path":"src\/isomorphic\/classic\/element\/ReactElementValidator.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactChildFiber.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiber.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiberBeginWork.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiberCommitWork.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiberCompleteWork.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiberScheduler.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactFiberTreeReflection.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/ReactReifiedYield.js","status":"D"},{"path":"src\/renderers\/shared\/fiber\/__tests__\/ReactCoroutine-test.js","status":"M"},{"path":"src\/renderers\/shared\/fiber\/isomorphic\/ReactCoroutine.js","status":"M"},{"path":"src\/test\/ReactTestUtils.js","status":"M"}],"parents":["39472f1c3ec82892030273fae0da3dcc7a68ac9e","975ad92e68781aaa5fce215e73496781799e9c3c"],"patch":"diff --git a\/scripts\/fiber\/tests-passing.txt b\/scripts\/fiber\/tests-passing.txt\nindex d6733db76e..a9d16d92eb 100644\n--- a\/scripts\/fiber\/tests-passing.txt\n+++ b\/scripts\/fiber\/tests-passing.txt\n@@ -1143,7 +1143,9 @@ src\/renderers\/shared\/__tests__\/ReactPerf-test.js\n \n src\/renderers\/shared\/fiber\/__tests__\/ReactCoroutine-test.js\n * should render a coroutine\n+* should update a coroutine\n * should unmount a composite in a coroutine\n+* should handle deep updates in coroutine\n \n src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\n * should render a simple component\ndiff --git a\/src\/isomorphic\/classic\/element\/ReactElementValidator.js b\/src\/isomorphic\/classic\/element\/ReactElementValidator.js\nindex f3910590dc..cc60aee305 100644\n--- a\/src\/isomorphic\/classic\/element\/ReactElementValidator.js\n+++ b\/src\/isomorphic\/classic\/element\/ReactElementValidator.js\n@@ -200,8 +200,7 @@ var ReactElementValidator = {\n createElement: function(type, props, children) {\n var validType =\n typeof type === 'string' ||\n- typeof type === 'function' ||\n- type !== null && typeof type === 'object' && typeof type.tag === 'number';\n+ typeof type === 'function';\n \/\/ We warn in this case but don't throw. We expect the element creation to\n \/\/ succeed and there will likely be errors in render.\n if (!validType) {\ndiff --git a\/src\/renderers\/shared\/fiber\/ReactChildFiber.js b\/src\/renderers\/shared\/fiber\/ReactChildFiber.js\nindex 95cea880cf..0505ae07e3 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactChildFiber.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactChildFiber.js\n@@ -29,7 +29,6 @@ var {\n } = require('ReactPortal');\n \n var ReactFiber = require('ReactFiber');\n-var ReactReifiedYield = require('ReactReifiedYield');\n var ReactTypeOfSideEffect = require('ReactTypeOfSideEffect');\n var ReactTypeOfWork = require('ReactTypeOfWork');\n \n@@ -53,11 +52,6 @@ const {\n createFiberFromPortal,\n } = ReactFiber;\n \n-const {\n- createReifiedYield,\n- createUpdatedReifiedYield,\n-} = ReactReifiedYield;\n-\n const isArray = Array.isArray;\n \n const {\n@@ -316,21 +310,16 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n yieldNode : ReactYield,\n priority : PriorityLevel\n ) : Fiber {\n- \/\/ TODO: Should this also compare continuation to determine whether to reuse?\n if (current == null || current.tag !== YieldComponent) {\n \/\/ Insert\n- const reifiedYield = createReifiedYield(yieldNode);\n const created = createFiberFromYield(yieldNode, priority);\n- created.type = reifiedYield;\n+ created.type = yieldNode.value;\n created.return = returnFiber;\n return created;\n } else {\n \/\/ Move based on index\n const existing = useFiber(current, priority);\n- existing.type = createUpdatedReifiedYield(\n- current.type,\n- yieldNode\n- );\n+ existing.type = yieldNode.value;\n existing.return = returnFiber;\n return existing;\n }\n@@ -411,9 +400,8 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n }\n \n case REACT_YIELD_TYPE: {\n- const reifiedYield = createReifiedYield(newChild);\n const created = createFiberFromYield(newChild, priority);\n- created.type = reifiedYield;\n+ created.type = newChild.value;\n created.return = returnFiber;\n return created;\n }\n@@ -474,7 +462,10 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n }\n \n case REACT_YIELD_TYPE: {\n- if (newChild.key === key) {\n+ \/\/ Yields doesn't have keys. If the previous node is implicitly keyed\n+ \/\/ we can continue to replace it without aborting even if it is not a\n+ \/\/ yield.\n+ if (key === null) {\n return updateYield(returnFiber, oldFiber, newChild, priority);\n } else {\n return null;\n@@ -527,9 +518,9 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n }\n \n case REACT_YIELD_TYPE: {\n- const matchedFiber = existingChildren.get(\n- newChild.key === null ? newIdx : newChild.key\n- ) || null;\n+ \/\/ Yields doesn't have keys, so we neither have to check the old nor\n+ \/\/ new node for the key. If both are yields, they match.\n+ const matchedFiber = existingChildren.get(newIdx) || null;\n return updateYield(returnFiber, matchedFiber, newChild, priority);\n }\n \n@@ -561,7 +552,6 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n switch (child.$$typeof) {\n case REACT_ELEMENT_TYPE:\n case REACT_COROUTINE_TYPE:\n- case REACT_YIELD_TYPE:\n case REACT_PORTAL_TYPE:\n const key = child.key;\n if (typeof key !== 'string') {\n@@ -1019,34 +1009,22 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n yieldNode : ReactYield,\n priority : PriorityLevel\n ) : Fiber {\n- const key = yieldNode.key;\n+ \/\/ There's no need to check for keys on yields since they're stateless.\n let child = currentFirstChild;\n- while (child) {\n- \/\/ TODO: If key === null and child.key === null, then this only applies to\n- \/\/ the first item in the list.\n- if (child.key === key) {\n- if (child.tag === YieldComponent) {\n- deleteRemainingChildren(returnFiber, child.sibling);\n- const existing = useFiber(child, priority);\n- existing.type = createUpdatedReifiedYield(\n- child.type,\n- yieldNode\n- );\n- existing.return = returnFiber;\n- return existing;\n- } else {\n- deleteRemainingChildren(returnFiber, child);\n- break;\n- }\n+ if (child) {\n+ if (child.tag === YieldComponent) {\n+ deleteRemainingChildren(returnFiber, child.sibling);\n+ const existing = useFiber(child, priority);\n+ existing.type = yieldNode.value;\n+ existing.return = returnFiber;\n+ return existing;\n } else {\n- deleteChild(returnFiber, child);\n+ deleteRemainingChildren(returnFiber, child);\n }\n- child = child.sibling;\n }\n \n- const reifiedYield = createReifiedYield(yieldNode);\n const created = createFiberFromYield(yieldNode, priority);\n- created.type = reifiedYield;\n+ created.type = yieldNode.value;\n created.return = returnFiber;\n return created;\n }\ndiff --git a\/src\/renderers\/shared\/fiber\/ReactFiber.js b\/src\/renderers\/shared\/fiber\/ReactFiber.js\nindex 3657d087bb..b488c0bbb6 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactFiber.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactFiber.js\n@@ -393,8 +393,7 @@ exports.createFiberFromCoroutine = function(coroutine : ReactCoroutine, priority\n };\n \n exports.createFiberFromYield = function(yieldNode : ReactYield, priorityLevel : PriorityLevel) : Fiber {\n- const fiber = createFiber(YieldComponent, yieldNode.key);\n- fiber.pendingProps = {};\n+ const fiber = createFiber(YieldComponent, null);\n return fiber;\n };\n \ndiff --git a\/src\/renderers\/shared\/fiber\/ReactFiberBeginWork.js b\/src\/renderers\/shared\/fiber\/ReactFiberBeginWork.js\nindex dbbb914669..a19f6659fc 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactFiberBeginWork.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactFiberBeginWork.js\n@@ -516,13 +516,54 @@ module.exports = function(\n }\n }\n } else if (nextCoroutine === null || workInProgress.memoizedProps === nextCoroutine) {\n- return bailoutOnAlreadyFinishedWork(current, workInProgress);\n+ nextCoroutine = workInProgress.memoizedProps;\n+ \/\/ TODO: When bailing out, we might need to return the stateNode instead\n+ \/\/ of the child. To check it for work.\n+ \/\/ return bailoutOnAlreadyFinishedWork(current, workInProgress);\n+ }\n+\n+ const nextChildren = nextCoroutine.children;\n+ const priorityLevel = workInProgress.pendingWorkPriority;\n+\n+ \/\/ The following is a fork of reconcileChildrenAtPriority but using\n+ \/\/ stateNode to store the child.\n+\n+ \/\/ At this point any memoization is no longer valid since we'll have changed\n+ \/\/ the children.\n+ workInProgress.memoizedProps = null;\n+ if (!current) {\n+ workInProgress.stateNode = mountChildFibersInPlace(\n+ workInProgress,\n+ workInProgress.stateNode,\n+ nextChildren,\n+ priorityLevel\n+ );\n+ } else if (current.child === workInProgress.child) {\n+ clearDeletions(workInProgress);\n+\n+ workInProgress.stateNode = reconcileChildFibers(\n+ workInProgress,\n+ workInProgress.stateNode,\n+ nextChildren,\n+ priorityLevel\n+ );\n+\n+ transferDeletions(workInProgress);\n+ } else {\n+ workInProgress.stateNode = reconcileChildFibersInPlace(\n+ workInProgress,\n+ workInProgress.stateNode,\n+ nextChildren,\n+ priorityLevel\n+ );\n+\n+ transferDeletions(workInProgress);\n }\n- reconcileChildren(current, workInProgress, nextCoroutine.children);\n+\n memoizeProps(workInProgress, nextCoroutine);\n \/\/ This doesn't take arbitrary time so we could synchronously just begin\n \/\/ eagerly do the work of workInProgress.child as an optimization.\n- return workInProgress.child;\n+ return workInProgress.stateNode;\n }\n \n function updatePortalComponent(current, workInProgress) {\ndiff --git a\/src\/renderers\/shared\/fiber\/ReactFiberCommitWork.js b\/src\/renderers\/shared\/fiber\/ReactFiberCommitWork.js\nindex 37bef63964..0dd429cdda 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactFiberCommitWork.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactFiberCommitWork.js\n@@ -136,7 +136,6 @@ module.exports = function(\n while (node.tag !== HostComponent && node.tag !== HostText) {\n \/\/ If it is not host node and, we might have a host node inside it.\n \/\/ Try to search down until we find one.\n- \/\/ TODO: For coroutines, this will have to search the stateNode.\n if (node.effectTag & Placement) {\n \/\/ If we don't have a child, try the siblings instead.\n continue siblings;\n@@ -198,7 +197,6 @@ module.exports = function(\n \/\/ down its children. Instead, we'll get insertions from each child in\n \/\/ the portal directly.\n } else if (node.child) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node.child.return = node;\n node = node.child;\n continue;\n@@ -229,7 +227,6 @@ module.exports = function(\n \/\/ Visit children because they may contain more composite or host nodes.\n \/\/ Skip portals because commitUnmount() currently visits them recursively.\n if (node.child && node.tag !== HostPortal) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node.child.return = node;\n node = node.child;\n continue;\n@@ -273,7 +270,6 @@ module.exports = function(\n commitUnmount(node);\n \/\/ Visit children because we may find more host components below.\n if (node.child) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node.child.return = node;\n node = node.child;\n continue;\ndiff --git a\/src\/renderers\/shared\/fiber\/ReactFiberCompleteWork.js b\/src\/renderers\/shared\/fiber\/ReactFiberCompleteWork.js\nindex 776db30ecc..400bdf8394 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactFiberCompleteWork.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactFiberCompleteWork.js\n@@ -17,7 +17,6 @@ import type { Fiber } from 'ReactFiber';\n import type { HostContext } from 'ReactFiberHostContext';\n import type { FiberRoot } from 'ReactFiberRoot';\n import type { HostConfig } from 'ReactFiberReconciler';\n-import type { ReifiedYield } from 'ReactReifiedYield';\n \n var { reconcileChildFibers } = require('ReactChildFiber');\n var {\n@@ -66,14 +65,29 @@ module.exports = function(\n popHostContainer,\n } = hostContext;\n \n+ function markChildAsProgressed(current, workInProgress, priorityLevel) {\n+ \/\/ We now have clones. Let's store them as the currently progressed work.\n+ workInProgress.progressedChild = workInProgress.child;\n+ workInProgress.progressedPriority = priorityLevel;\n+ if (current) {\n+ \/\/ We also store it on the current. When the alternate swaps in we can\n+ \/\/ continue from this point.\n+ current.progressedChild = workInProgress.progressedChild;\n+ current.progressedPriority = workInProgress.progressedPriority;\n+ }\n+ }\n+\n function markUpdate(workInProgress : Fiber) {\n \/\/ Tag the fiber with an update effect. This turns a Placement into\n \/\/ an UpdateAndPlacement.\n workInProgress.effectTag |= Update;\n }\n \n- function appendAllYields(yields : Array, workInProgress : Fiber) {\n- let node = workInProgress.child;\n+ function appendAllYields(yields : Array, workInProgress : Fiber) {\n+ let node = workInProgress.stateNode;\n+ if (node) {\n+ node.return = workInProgress;\n+ }\n while (node) {\n if (node.tag === HostComponent || node.tag === HostText ||\n node.tag === HostPortal) {\n@@ -81,14 +95,10 @@ module.exports = function(\n } else if (node.tag === YieldComponent) {\n yields.push(node.type);\n } else if (node.child) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node.child.return = node;\n node = node.child;\n continue;\n }\n- if (node === workInProgress) {\n- return;\n- }\n while (!node.sibling) {\n if (!node.return || node.return === workInProgress) {\n return;\n@@ -117,22 +127,23 @@ module.exports = function(\n \n \/\/ Build up the yields.\n \/\/ TODO: Compare this to a generator or opaque helpers like Children.\n- var yields : Array = [];\n+ var yields : Array = [];\n appendAllYields(yields, workInProgress);\n var fn = coroutine.handler;\n var props = coroutine.props;\n var nextChildren = fn(props, yields);\n \n- var currentFirstChild = current ? current.stateNode : null;\n+ var currentFirstChild = current ? current.child : null;\n \/\/ Inherit the priority of the returnFiber.\n const priority = workInProgress.pendingWorkPriority;\n- workInProgress.stateNode = reconcileChildFibers(\n+ workInProgress.child = reconcileChildFibers(\n workInProgress,\n currentFirstChild,\n nextChildren,\n priority\n );\n- return workInProgress.stateNode;\n+ markChildAsProgressed(current, workInProgress, priority);\n+ return workInProgress.child;\n }\n \n function appendAllChildren(parent : I, workInProgress : Fiber) {\n@@ -147,7 +158,6 @@ module.exports = function(\n \/\/ down its children. Instead, we'll get insertions from each child in\n \/\/ the portal directly.\n } else if (node.child) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node = node.child;\n continue;\n }\ndiff --git a\/src\/renderers\/shared\/fiber\/ReactFiberScheduler.js b\/src\/renderers\/shared\/fiber\/ReactFiberScheduler.js\nindex 1b2fc17004..7cdf1b917d 100644\n--- a\/src\/renderers\/shared\/fiber\/ReactFiberScheduler.js\n+++ b\/src\/renderers\/shared\/fiber\/ReactFiberScheduler.js\n@@ -435,6 +435,8 @@ module.exports = function(config : HostConfig {\n ReactFeatureFlags.disableNewFiberFeatures = false;\n });\n \n+ function div(...children) {\n+ children = children.map(c => typeof c === 'string' ? { text: c } : c);\n+ return { type: 'div', children, prop: undefined };\n+ }\n+\n+ function span(prop) {\n+ return { type: 'span', children: [], prop };\n+ }\n+\n it('should render a coroutine', () => {\n var ops = [];\n \n function Continuation({ isSame }) {\n ops.push(['Continuation', isSame]);\n- return {isSame ? 'foo==bar' : 'foo!=bar'}<\/span>;\n+ return ;\n }\n \n \/\/ An alternative API could mark Continuation as something that needs\n@@ -39,8 +48,11 @@ describe('ReactCoroutine', () => {\n function Child({ bar }) {\n ops.push(['Child', bar]);\n return ReactCoroutine.createYield({\n- bar: bar,\n- }, Continuation, null);\n+ props: {\n+ bar: bar,\n+ },\n+ continuation: Continuation,\n+ });\n }\n \n function Indirection() {\n@@ -85,6 +97,67 @@ describe('ReactCoroutine', () => {\n ['Continuation', true],\n ['Continuation', false],\n ]);\n+ expect(ReactNoop.getChildren()).toEqual([\n+ div(\n+ span('foo==bar'),\n+ span('foo!=bar'),\n+ ),\n+ ]);\n+ });\n+\n+ it('should update a coroutine', () => {\n+ function Continuation({ isSame }) {\n+ return ;\n+ }\n+\n+ function Child({ bar }) {\n+ return ReactCoroutine.createYield({\n+ props: {\n+ bar: bar,\n+ },\n+ continuation: Continuation,\n+ });\n+ }\n+\n+ function Indirection() {\n+ return [, ];\n+ }\n+\n+ function HandleYields(props, yields) {\n+ return yields.map(y =>\n+ \n+ );\n+ }\n+\n+ function Parent(props) {\n+ return ReactCoroutine.createCoroutine(\n+ props.children,\n+ HandleYields,\n+ props\n+ );\n+ }\n+\n+ function App(props) {\n+ return

<\/Parent><\/div>;\n+ }\n+\n+ ReactNoop.render();\n+ ReactNoop.flush();\n+ expect(ReactNoop.getChildren()).toEqual([\n+ div(\n+ span('foo==bar'),\n+ span('foo!=bar'),\n+ ),\n+ ]);\n+\n+ ReactNoop.render();\n+ ReactNoop.flush();\n+ expect(ReactNoop.getChildren()).toEqual([\n+ div(\n+ span('foo!=bar'),\n+ span('foo==bar'),\n+ ),\n+ ]);\n });\n \n it('should unmount a composite in a coroutine', () => {\n@@ -103,7 +176,7 @@ describe('ReactCoroutine', () => {\n class Child extends React.Component {\n render() {\n ops.push('Child');\n- return ReactCoroutine.createYield({}, Continuation, null);\n+ return ReactCoroutine.createYield(Continuation);\n }\n componentWillUnmount() {\n ops.push('Unmount Child');\n@@ -112,7 +185,7 @@ describe('ReactCoroutine', () => {\n \n function HandleYields(props, yields) {\n ops.push('HandleYields');\n- return yields.map(y => );\n+ return yields.map(ContinuationComponent => );\n }\n \n class Parent extends React.Component {\n@@ -146,11 +219,50 @@ describe('ReactCoroutine', () => {\n \n expect(ops).toEqual([\n 'Unmount Parent',\n- \/\/ TODO: This should happen in the order Child, Continuation which it\n- \/\/ will once we swap stateNode and child positions of these.\n- 'Unmount Continuation',\n 'Unmount Child',\n+ 'Unmount Continuation',\n+ ]);\n+\n+ });\n+\n+ it('should handle deep updates in coroutine', () => {\n+ let instances = {};\n+\n+ class Counter extends React.Component {\n+ state = {value: 5};\n+ render() {\n+ instances[this.props.id] = this;\n+ return ReactCoroutine.createYield(this.state.value);\n+ }\n+ }\n+\n+ function App(props) {\n+ return ReactCoroutine.createCoroutine(\n+ [\n+ ,\n+ ,\n+ ,\n+ ],\n+ (p, yields) => yields.map(y => ),\n+ {}\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ ReactNoop.flush();\n+ expect(ReactNoop.getChildren()).toEqual([\n+ span(500),\n+ span(500),\n+ span(500),\n ]);\n \n+ instances.a.setState({value: 1});\n+ instances.b.setState({value: 2});\n+ ReactNoop.flush();\n+ expect(ReactNoop.getChildren()).toEqual([\n+ span(100),\n+ span(200),\n+ span(500),\n+ ]);\n });\n });\ndiff --git a\/src\/renderers\/shared\/fiber\/isomorphic\/ReactCoroutine.js b\/src\/renderers\/shared\/fiber\/isomorphic\/ReactCoroutine.js\nindex 609470fd39..68f3a99b5d 100644\n--- a\/src\/renderers\/shared\/fiber\/isomorphic\/ReactCoroutine.js\n+++ b\/src\/renderers\/shared\/fiber\/isomorphic\/ReactCoroutine.js\n@@ -16,30 +16,29 @@ import type { ReactNodeList } from 'ReactTypes';\n \n \/\/ The Symbol used to tag the special React types. If there is no native Symbol\n \/\/ nor polyfill, then a plain number is used for performance.\n-var REACT_COROUTINE_TYPE =\n- (typeof Symbol === 'function' && Symbol.for && Symbol.for('react.coroutine')) ||\n- 0xeac8;\n+var REACT_COROUTINE_TYPE;\n+var REACT_YIELD_TYPE;\n+if (typeof Symbol === 'function' && Symbol.for) {\n+ REACT_COROUTINE_TYPE = Symbol.for('react.coroutine');\n+ REACT_YIELD_TYPE = Symbol.for('react.yield');\n+} else {\n+ REACT_COROUTINE_TYPE = 0xeac8;\n+ REACT_YIELD_TYPE = 0xeac9;\n+}\n \n-var REACT_YIELD_TYPE =\n- (typeof Symbol === 'function' && Symbol.for && Symbol.for('react.yield')) ||\n- 0xeac9;\n-\n-type ReifiedYield = { continuation: Object, props: Object };\n-type CoroutineHandler = (props: T, yields: Array) => ReactNodeList;\n+type CoroutineHandler = (props: T, yields: Array) => ReactNodeList;\n \n export type ReactCoroutine = {\n $$typeof: Symbol | number,\n key: null | string,\n children: any,\n \/\/ This should be a more specific CoroutineHandler\n- handler: (props: any, yields: Array) => ReactNodeList,\n+ handler: (props: any, yields: Array) => ReactNodeList,\n props: any,\n };\n export type ReactYield = {\n $$typeof: Symbol | number,\n- key: null | string,\n- props: Object,\n- continuation: mixed\n+ value: mixed,\n };\n \n exports.createCoroutine = function(\n@@ -68,19 +67,16 @@ exports.createCoroutine = function(\n return coroutine;\n };\n \n-exports.createYield = function(props : mixed, continuation : mixed, key : ?string = null) {\n+exports.createYield = function(value : mixed) : ReactYield {\n var yieldNode = {\n \/\/ This tag allow us to uniquely identify this as a React Yield\n $$typeof: REACT_YIELD_TYPE,\n- key: key == null ? null : '' + key,\n- props: props,\n- continuation: continuation,\n+ value: value,\n };\n \n if (__DEV__) {\n \/\/ TODO: Add _store property for marking this as validated.\n if (Object.freeze) {\n- Object.freeze(yieldNode.props);\n Object.freeze(yieldNode);\n }\n }\ndiff --git a\/src\/test\/ReactTestUtils.js b\/src\/test\/ReactTestUtils.js\nindex 1a393d426b..7a01f13cb7 100644\n--- a\/src\/test\/ReactTestUtils.js\n+++ b\/src\/test\/ReactTestUtils.js\n@@ -97,7 +97,6 @@ function findAllInRenderedFiberTreeInternal(fiber, test) {\n }\n }\n if (node.child) {\n- \/\/ TODO: Coroutines need to visit the stateNode.\n node.child.return = node;\n node = node.child;\n continue;\n"}

dillon1000/react

Files changed