dillon1000/react

Commit

Replace `wrap-warning-with-env-check` with an eslint plugin (#17540)

* Replace Babel plugin with an ESLint plugin

* Fix ESLint rule violations

* Move shared conditions higher

* Test formatting nits

* Tweak ESLint rule

* Bugfix: inside else branch, 'if' tests are not satisfactory

* Use a stricter check for exactly if (__DEV__)

This makes it easier to see what's going on and matches dominant style in the codebase.

* Fix remaining files after stricter check
Browse files
Laura buns authored b43eec7eaad14747d24ef24a06b27cb2a5653bbc Parent acfe4b2
Changed paths35 files
First-parent comparison
M .eslintrc.js ModifiedM packages/create-subscription/src/createSubscription.js ModifiedM packages/legacy-events/SyntheticEvent.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMSelect.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js ModifiedM packages/react-dom/src/server/ReactPartialRendererHooks.js ModifiedM packages/react-dom/src/shared/CSSPropertyOperations.js ModifiedM packages/react-dom/src/shared/ReactDOMInvalidARIAHook.js ModifiedM packages/react-dom/src/shared/ReactDOMNullInputValuePropHook.js ModifiedM packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js ModifiedM packages/react-dom/src/shared/sanitizeURL.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-native-renderer/src/NativeMethodsMixin.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactFabricHostConfig.js ModifiedM packages/react-native-renderer/src/ReactNativeComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeFiberHostComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberDevToolsHook.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-test-renderer/src/ReactShallowRenderer.js ModifiedM packages/react-test-renderer/src/ReactTestHostConfig.js ModifiedM packages/react/src/ReactElement.js ModifiedM packages/react/src/ReactElementValidator.js ModifiedR scripts/babel/__tests__/wrap-warning-with-env-check-test.js →scripts/babel/__tests__/lift-warning-conditional-argument-test.js RenamedR scripts/babel/wrap-warning-with-env-check.js →scripts/babel/lift-warning-conditional-argument.js RenamedA scripts/eslint-rules/__tests__/no-production-logging-test.internal.js AddedM scripts/eslint-rules/index.js ModifiedA scripts/eslint-rules/no-production-logging.js AddedM scripts/jest/preprocessor.js ModifiedM scripts/rollup/build.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…