{"files":[{"status":"M","path":"packages\/react-debug-tools\/src\/ReactDebugHooks.js"},{"status":"M","path":"packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.internal.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.internal.js"},{"status":"M","path":"packages\/react-dom\/src\/server\/ReactPartialRendererHooks.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberDispatcher.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberHooks.js"},{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js"},{"status":"M","path":"packages\/react\/src\/React.js"},{"status":"M","path":"packages\/react\/src\/ReactHooks.js"}],"patch":"diff --git a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\nindex b3283b1021..9b5a3b4994 100644\n--- a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n+++ b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n@@ -54,7 +54,7 @@ function getPrimitiveStackCache(): Map> {\n Dispatcher.useRef(null);\n Dispatcher.useLayoutEffect(() => {});\n Dispatcher.useEffect(() => {});\n- Dispatcher.useImperativeMethods(undefined, () => null);\n+ Dispatcher.useImperativeHandle(undefined, () => null);\n Dispatcher.useCallback(() => {});\n Dispatcher.useMemo(() => null);\n } finally {\n@@ -159,7 +159,7 @@ function useEffect(\n hookLog.push({primitive: 'Effect', stackError: new Error(), value: create});\n }\n \n-function useImperativeMethods(\n+function useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n create: () => T,\n inputs: Array | void | null,\n@@ -174,7 +174,7 @@ function useImperativeMethods(\n instance = ref.current;\n }\n hookLog.push({\n- primitive: 'ImperativeMethods',\n+ primitive: 'ImperativeHandle',\n stackError: new Error(),\n value: instance,\n });\n@@ -205,7 +205,7 @@ const Dispatcher = {\n useCallback,\n useContext,\n useEffect,\n- useImperativeMethods,\n+ useImperativeHandle,\n useLayoutEffect,\n useMemo,\n useReducer,\ndiff --git a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.internal.js b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.internal.js\nindex 98fa9f7360..d740bb4fdc 100644\n--- a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.internal.js\n+++ b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.internal.js\n@@ -82,7 +82,7 @@ describe('ReactHooksInspectionIntergration', () => {\n React.useLayoutEffect(effect);\n React.useEffect(effect);\n \n- React.useImperativeMethods(\n+ React.useImperativeHandle(\n outsideRef,\n () => {\n \/\/ Return a function so that jest treats them as non-equal.\n@@ -118,7 +118,7 @@ describe('ReactHooksInspectionIntergration', () => {\n {name: 'Ref', value: 'c', subHooks: []},\n {name: 'LayoutEffect', value: effect, subHooks: []},\n {name: 'Effect', value: effect, subHooks: []},\n- {name: 'ImperativeMethods', value: outsideRef.current, subHooks: []},\n+ {name: 'ImperativeHandle', value: outsideRef.current, subHooks: []},\n {name: 'Memo', value: 'ab', subHooks: []},\n {name: 'Callback', value: updateStates, subHooks: []},\n ]);\n@@ -134,7 +134,7 @@ describe('ReactHooksInspectionIntergration', () => {\n {name: 'Ref', value: 'C', subHooks: []},\n {name: 'LayoutEffect', value: effect, subHooks: []},\n {name: 'Effect', value: effect, subHooks: []},\n- {name: 'ImperativeMethods', value: outsideRef.current, subHooks: []},\n+ {name: 'ImperativeHandle', value: outsideRef.current, subHooks: []},\n {name: 'Memo', value: 'Ab', subHooks: []},\n {name: 'Callback', value: updateStates, subHooks: []},\n ]);\n@@ -165,7 +165,7 @@ describe('ReactHooksInspectionIntergration', () => {\n it('should inspect forwardRef', () => {\n let obj = function() {};\n let Foo = React.forwardRef(function(props, ref) {\n- React.useImperativeMethods(ref, () => obj);\n+ React.useImperativeHandle(ref, () => obj);\n return

;\n });\n let ref = React.createRef();\n@@ -174,7 +174,7 @@ describe('ReactHooksInspectionIntergration', () => {\n let childFiber = renderer.root.findByType(Foo)._currentFiber();\n let tree = ReactDebugTools.inspectHooksOfFiber(childFiber);\n expect(tree).toEqual([\n- {name: 'ImperativeMethods', value: obj, subHooks: []},\n+ {name: 'ImperativeHandle', value: obj, subHooks: []},\n ]);\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.internal.js\nindex a8f56ef95c..2e585a1373 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.internal.js\n@@ -24,7 +24,7 @@ let useContext;\n let useCallback;\n let useMemo;\n let useRef;\n-let useImperativeMethods;\n+let useImperativeHandle;\n let useLayoutEffect;\n let forwardRef;\n let yieldedValues;\n@@ -48,7 +48,7 @@ function initModules() {\n useCallback = React.useCallback;\n useMemo = React.useMemo;\n useRef = React.useRef;\n- useImperativeMethods = React.useImperativeMethods;\n+ useImperativeHandle = React.useImperativeHandle;\n useLayoutEffect = React.useLayoutEffect;\n forwardRef = React.forwardRef;\n \n@@ -529,10 +529,10 @@ describe('ReactDOMServerHooks', () => {\n });\n });\n \n- describe('useImperativeMethods', () => {\n+ describe('useImperativeHandle', () => {\n it('should not be invoked on the server', async () => {\n function Counter(props, ref) {\n- useImperativeMethods(ref, () => {\n+ useImperativeHandle(ref, () => {\n throw new Error('should not be invoked');\n });\n return ;\ndiff --git a\/packages\/react-dom\/src\/server\/ReactPartialRendererHooks.js b\/packages\/react-dom\/src\/server\/ReactPartialRendererHooks.js\nindex 3f1d011822..d5ca03dee8 100644\n--- a\/packages\/react-dom\/src\/server\/ReactPartialRendererHooks.js\n+++ b\/packages\/react-dom\/src\/server\/ReactPartialRendererHooks.js\n@@ -347,8 +347,8 @@ export const Dispatcher = {\n useLayoutEffect,\n \/\/ Callbacks are passed as they are in the server environment.\n useCallback: identity,\n- \/\/ useImperativeMethods is not run in the server environment\n- useImperativeMethods: noop,\n+ \/\/ useImperativeHandle is not run in the server environment\n+ useImperativeHandle: noop,\n \/\/ Effects are not run in the server environment.\n useEffect: noop,\n };\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberDispatcher.js b\/packages\/react-reconciler\/src\/ReactFiberDispatcher.js\nindex f86319e394..d29267f84b 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberDispatcher.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberDispatcher.js\n@@ -12,7 +12,7 @@ import {\n useCallback,\n useContext,\n useEffect,\n- useImperativeMethods,\n+ useImperativeHandle,\n useLayoutEffect,\n useMemo,\n useReducer,\n@@ -25,7 +25,7 @@ export const Dispatcher = {\n useCallback,\n useContext,\n useEffect,\n- useImperativeMethods,\n+ useImperativeHandle,\n useLayoutEffect,\n useMemo,\n useReducer,\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex 5122a8dda4..b859f4067b 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -557,7 +557,7 @@ function useEffectImpl(fiberEffectTag, hookEffectTag, create, inputs): void {\n );\n }\n \n-export function useImperativeMethods(\n+export function useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n create: () => T,\n inputs: Array | void | null,\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js\nindex ea56721474..aa0a572155 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js\n@@ -23,7 +23,7 @@ let useLayoutEffect;\n let useCallback;\n let useMemo;\n let useRef;\n-let useImperativeMethods;\n+let useImperativeHandle;\n let forwardRef;\n let flushPassiveEffects;\n let memo;\n@@ -71,7 +71,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n useCallback = React.useCallback;\n useMemo = React.useMemo;\n useRef = React.useRef;\n- useImperativeMethods = React.useImperativeMethods;\n+ useImperativeHandle = React.useImperativeHandle;\n forwardRef = React.forwardRef;\n memo = React.memo;\n });\n@@ -88,7 +88,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n it('resumes after an interruption', () => {\n function Counter(props, ref) {\n const [count, updateCount] = useState(0);\n- useImperativeMethods(ref, () => ({updateCount}));\n+ useImperativeHandle(ref, () => ({updateCount}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -172,7 +172,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n it('simple mount and update', () => {\n function Counter(props, ref) {\n const [count, updateCount] = useState(0);\n- useImperativeMethods(ref, () => ({updateCount}));\n+ useImperativeHandle(ref, () => ({updateCount}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -196,7 +196,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n ReactNoop.yield('getInitialState');\n return props.initialState;\n });\n- useImperativeMethods(ref, () => ({updateCount}));\n+ useImperativeHandle(ref, () => ({updateCount}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -214,7 +214,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n function Counter(props, ref) {\n const [count, updateCount] = useState(0);\n const [label, updateLabel] = useState('Count');\n- useImperativeMethods(ref, () => ({updateCount, updateLabel}));\n+ useImperativeHandle(ref, () => ({updateCount, updateLabel}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -444,7 +444,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n function Counter({row: newRow}, ref) {\n let [reducer, setReducer] = useState(() => reducerA);\n let [count, dispatch] = useReducer(reducer, 0);\n- useImperativeMethods(ref, () => ({dispatch}));\n+ useImperativeHandle(ref, () => ({dispatch}));\n if (count < 20) {\n dispatch('increment');\n \/\/ Swap reducers each time we increment\n@@ -505,7 +505,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n \n function Counter(props, ref) {\n const [count, dispatch] = useReducer(reducer, 0);\n- useImperativeMethods(ref, () => ({dispatch}));\n+ useImperativeHandle(ref, () => ({dispatch}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -546,7 +546,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n \n function Counter(props, ref) {\n const [count, dispatch] = useReducer(reducer, 0, initialAction);\n- useImperativeMethods(ref, () => ({dispatch}));\n+ useImperativeHandle(ref, () => ({dispatch}));\n return ;\n }\n Counter = forwardRef(Counter);\n@@ -576,7 +576,7 @@ describe('ReactHooksWithNoopRenderer', () => {\n \n function Counter(props, ref) {\n const [count, dispatch] = useReducer(reducer, 0);\n- useImperativeMethods(ref, () => ({dispatch}));\n+ useImperativeHandle(ref, () => ({dispatch}));\n return ;\n }\n \ndiff --git a\/packages\/react\/src\/React.js b\/packages\/react\/src\/React.js\nindex c19a6653e3..9544e21ad9 100644\n--- a\/packages\/react\/src\/React.js\n+++ b\/packages\/react\/src\/React.js\n@@ -32,7 +32,7 @@ import {\n useCallback,\n useContext,\n useEffect,\n- useImperativeMethods,\n+ useImperativeHandle,\n useLayoutEffect,\n useMemo,\n useReducer,\n@@ -98,7 +98,7 @@ if (enableHooks) {\n React.useCallback = useCallback;\n React.useContext = useContext;\n React.useEffect = useEffect;\n- React.useImperativeMethods = useImperativeMethods;\n+ React.useImperativeHandle = useImperativeHandle;\n React.useLayoutEffect = useLayoutEffect;\n React.useMemo = useMemo;\n React.useReducer = useReducer;\ndiff --git a\/packages\/react\/src\/ReactHooks.js b\/packages\/react\/src\/ReactHooks.js\nindex 1e27f71108..e5fa9d3a50 100644\n--- a\/packages\/react\/src\/ReactHooks.js\n+++ b\/packages\/react\/src\/ReactHooks.js\n@@ -102,11 +102,11 @@ export function useMemo(\n return dispatcher.useMemo(create, inputs);\n }\n \n-export function useImperativeMethods(\n+export function useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n create: () => T,\n inputs: Array | void | null,\n ): void {\n const dispatcher = resolveDispatcher();\n- return dispatcher.useImperativeMethods(ref, create, inputs);\n+ return dispatcher.useImperativeHandle(ref, create, inputs);\n }\n","body":"","parents":["ab03e3d6518ae3c68feca8d5debf2ef69a91a38c"],"commit":{"shortRevision":"b4ad8e9471","authorName":"Sunil Pai","authorEmail":"threepointone@oculus.com","authoredAt":"2019-01-10T13:37:50+00:00","revision":"b4ad8e947150a1a0b486a388e2d4762d3eee51ee","subject":"rename useImperativeMethods -> useImperativeHandle (#14565)"}}

dillon1000/react

Files changed