{"body":"Changed the Transitions type to Array because Transitions was confusing","parents":["c89a15c716febe71b7d857f839829cd1dc74918f"],"files":[{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberLane.new.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberLane.old.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberRoot.new.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberRoot.old.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.new.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.old.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberWorkLoop.new.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberWorkLoop.old.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactInternalTypes.js"}],"commit":{"revision":"b8cfda15e1232554487c7285fb464f22705a23ce","shortRevision":"b8cfda15e1","authorEmail":"lunaris.ruan@gmail.com","subject":"changed Transitions type to Array (#24249)","authoredAt":"2022-04-01T17:02:28-04:00","authorName":"Luna Ruan"},"patch":"diff --git a\/packages\/react-reconciler\/src\/ReactFiberLane.new.js b\/packages\/react-reconciler\/src\/ReactFiberLane.new.js\nindex 3bf65a9093..4013545caf 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberLane.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberLane.new.js\n@@ -8,10 +8,7 @@\n *\/\n \n import type {FiberRoot} from '.\/ReactInternalTypes';\n-import type {\n- Transition,\n- Transitions,\n-} from '.\/ReactFiberTracingMarkerComponent.new';\n+import type {Transition} from '.\/ReactFiberTracingMarkerComponent.new';\n \n \/\/ TODO: Ideally these types would be opaque but that doesn't work well with\n \/\/ our reconciler fork infra, since these leak into non-reconciler packages.\n@@ -824,7 +821,7 @@ export function addTransitionToLanesMap(\n export function getTransitionsForLanes(\n root: FiberRoot,\n lanes: Lane | Lanes,\n-): Transitions | null {\n+): Array | null {\n if (!enableTransitionTracing) {\n return null;\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberLane.old.js b\/packages\/react-reconciler\/src\/ReactFiberLane.old.js\nindex ec884de182..37fb44cc10 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberLane.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberLane.old.js\n@@ -8,10 +8,7 @@\n *\/\n \n import type {FiberRoot} from '.\/ReactInternalTypes';\n-import type {\n- Transition,\n- Transitions,\n-} from '.\/ReactFiberTracingMarkerComponent.old';\n+import type {Transition} from '.\/ReactFiberTracingMarkerComponent.old';\n \n \/\/ TODO: Ideally these types would be opaque but that doesn't work well with\n \/\/ our reconciler fork infra, since these leak into non-reconciler packages.\n@@ -824,7 +821,7 @@ export function addTransitionToLanesMap(\n export function getTransitionsForLanes(\n root: FiberRoot,\n lanes: Lane | Lanes,\n-): Transitions | null {\n+): Array | null {\n if (!enableTransitionTracing) {\n return null;\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberRoot.new.js b\/packages\/react-reconciler\/src\/ReactFiberRoot.new.js\nindex 7ff03ceead..ba8717a65e 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberRoot.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberRoot.new.js\n@@ -15,7 +15,7 @@ import type {\n } from '.\/ReactInternalTypes';\n import type {RootTag} from '.\/ReactRootTags';\n import type {Cache} from '.\/ReactFiberCacheComponent.new';\n-import type {Transitions} from '.\/ReactFiberTracingMarkerComponent.new';\n+import type {Transition} from '.\/ReactFiberTracingMarkerComponent.new';\n \n import {noTimeout, supportsHydration} from '.\/ReactFiberHostConfig';\n import {createHostRootFiber} from '.\/ReactFiber.new';\n@@ -42,7 +42,7 @@ export type RootState = {\n element: any,\n isDehydrated: boolean,\n cache: Cache,\n- transitions: Transitions | null,\n+ transitions: Array | null,\n };\n \n function FiberRootNode(\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberRoot.old.js b\/packages\/react-reconciler\/src\/ReactFiberRoot.old.js\nindex 179b9c17ae..1d5edd410c 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberRoot.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberRoot.old.js\n@@ -15,7 +15,7 @@ import type {\n } from '.\/ReactInternalTypes';\n import type {RootTag} from '.\/ReactRootTags';\n import type {Cache} from '.\/ReactFiberCacheComponent.old';\n-import type {Transitions} from '.\/ReactFiberTracingMarkerComponent.old';\n+import type {Transition} from '.\/ReactFiberTracingMarkerComponent.old';\n \n import {noTimeout, supportsHydration} from '.\/ReactFiberHostConfig';\n import {createHostRootFiber} from '.\/ReactFiber.old';\n@@ -42,7 +42,7 @@ export type RootState = {\n element: any,\n isDehydrated: boolean,\n cache: Cache,\n- transitions: Transitions | null,\n+ transitions: Array | null,\n };\n \n function FiberRootNode(\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.new.js b\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.new.js\nindex aad0c912c5..cc3834f5cc 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.new.js\n@@ -34,8 +34,6 @@ export type BatchConfigTransition = {\n _updatedFibers?: Set,\n };\n \n-export type Transitions = Array | null;\n-\n export type TransitionCallback = 0 | 1;\n \n export const TransitionStart = 0;\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.old.js b\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.old.js\nindex aad0c912c5..cc3834f5cc 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberTracingMarkerComponent.old.js\n@@ -34,8 +34,6 @@ export type BatchConfigTransition = {\n _updatedFibers?: Set,\n };\n \n-export type Transitions = Array | null;\n-\n export type TransitionCallback = 0 | 1;\n \n export const TransitionStart = 0;\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.new.js b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.new.js\nindex 3e50d6e391..4da17c7bb6 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.new.js\n@@ -18,7 +18,7 @@ import type {EventPriority} from '.\/ReactEventPriorities.new';\n import type {\n PendingTransitionCallbacks,\n TransitionObject,\n- Transitions,\n+ Transition,\n } from '.\/ReactFiberTracingMarkerComponent.new';\n \n import {\n@@ -325,7 +325,7 @@ let workInProgressRootRenderTargetTime: number = Infinity;\n \/\/ suspense heuristics and opt out of rendering more content.\n const RENDER_TIMEOUT_MS = 500;\n \n-let workInProgressTransitions: Transitions | null = null;\n+let workInProgressTransitions: Array | null = null;\n export function getWorkInProgressTransitions() {\n return workInProgressTransitions;\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.old.js b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.old.js\nindex 2745bb87c0..2c940a7100 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.old.js\n@@ -18,7 +18,7 @@ import type {EventPriority} from '.\/ReactEventPriorities.old';\n import type {\n PendingTransitionCallbacks,\n TransitionObject,\n- Transitions,\n+ Transition,\n } from '.\/ReactFiberTracingMarkerComponent.old';\n \n import {\n@@ -325,7 +325,7 @@ let workInProgressRootRenderTargetTime: number = Infinity;\n \/\/ suspense heuristics and opt out of rendering more content.\n const RENDER_TIMEOUT_MS = 500;\n \n-let workInProgressTransitions: Transitions | null = null;\n+let workInProgressTransitions: Array | null = null;\n export function getWorkInProgressTransitions() {\n return workInProgressTransitions;\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactInternalTypes.js b\/packages\/react-reconciler\/src\/ReactInternalTypes.js\nindex 1fa3d4b668..319bbc1c33 100644\n--- a\/packages\/react-reconciler\/src\/ReactInternalTypes.js\n+++ b\/packages\/react-reconciler\/src\/ReactInternalTypes.js\n@@ -26,7 +26,7 @@ import type {Lane, Lanes, LaneMap} from '.\/ReactFiberLane.old';\n import type {RootTag} from '.\/ReactRootTags';\n import type {TimeoutHandle, NoTimeout} from '.\/ReactFiberHostConfig';\n import type {Cache} from '.\/ReactFiberCacheComponent.old';\n-import type {Transitions} from '.\/ReactFiberTracingMarkerComponent.new';\n+import type {Transition} from '.\/ReactFiberTracingMarkerComponent.new';\n \n \/\/ Unwind Circular: moved from ReactFiberHooks.old\n export type HookType =\n@@ -320,7 +320,7 @@ export type TransitionTracingCallbacks = {\n \/\/ The following fields are only used in transition tracing in Profile builds\n type TransitionTracingOnlyFiberRootProperties = {|\n transitionCallbacks: null | TransitionTracingCallbacks,\n- transitionLanes: Array,\n+ transitionLanes: Array | null>,\n |};\n \n \/\/ Exported FiberRoot type includes all properties,\n"}

dillon1000/react

Files changed