{"commit":{"authorName":"Sota","revision":"bd255700d73ed5fa88f9e32fa4b43623679adf0c","shortRevision":"bd255700d7","authorEmail":"5866096+sota000@users.noreply.github.com","authoredAt":"2021-08-16T18:43:24-07:00","subject":"Show a soft error when a text string or number is supplied as a child to non text wrappers (#22109)"},"patch":"diff --git a\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js b\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\nindex 8ca9401597..c71a905021 100644\n--- a\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\n+++ b\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\n@@ -22,8 +22,6 @@ import type {\n import {mountSafeCallback_NOT_REALLY_SAFE} from '.\/NativeMethodsMixinUtils';\n import {create, diff} from '.\/ReactNativeAttributePayload';\n \n-import invariant from 'shared\/invariant';\n-\n import {dispatchEvent} from '.\/ReactFabricEventEmitter';\n \n import {\n@@ -264,10 +262,11 @@ export function createTextInstance(\n hostContext: HostContext,\n internalInstanceHandle: Object,\n ): TextInstance {\n- invariant(\n- hostContext.isInAParentText,\n- 'Text strings must be rendered within a component.',\n- );\n+ if (__DEV__) {\n+ if (!hostContext.isInAParentText) {\n+ console.error('Text strings must be rendered within a component.');\n+ }\n+ }\n \n const tag = nextReactTag;\n nextReactTag += 2;\ndiff --git a\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js b\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\nindex c7e4e3dee1..9f2851382a 100644\n--- a\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\n+++ b\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\n@@ -524,7 +524,7 @@ describe('ReactFabric', () => {\n });\n });\n \n- it('should throw for text not inside of a ancestor', () => {\n+ it('should console error for text not inside of a ancestor', () => {\n const ScrollView = createReactNativeComponentClass('RCTScrollView', () => ({\n validAttributes: {},\n uiViewClassName: 'RCTScrollView',\n@@ -542,7 +542,7 @@ describe('ReactFabric', () => {\n act(() => {\n ReactFabric.render(this should warn<\/View>, 11);\n });\n- }).toThrow('Text strings must be rendered within a component.');\n+ }).toErrorDev(['Text strings must be rendered within a component.']);\n \n expect(() => {\n act(() => {\n@@ -553,7 +553,7 @@ describe('ReactFabric', () => {\n 11,\n );\n });\n- }).toThrow('Text strings must be rendered within a component.');\n+ }).toErrorDev(['Text strings must be rendered within a component.']);\n });\n \n it('should not throw for text inside of an indirect ancestor', () => {\n","body":"","files":[{"status":"M","path":"packages\/react-native-renderer\/src\/ReactFabricHostConfig.js"},{"status":"M","path":"packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js"}],"parents":["424fe587087d05302259d6d5ebb359675387f3b1"]}

dillon1000/react

Files changed