dillon1000/react

Commit

Extract logic for detecting bad fallback to helper

Pure refactor, no change in behavior.

Extracts the logic for detecting whether a suspended component will
result in a "bad" Suspense fallback into a helper function. An example
of a bad Suspense fallback is one that causes already-visible content
to disappear.

I want to reuse this same logic in the work loop, too.
Browse files
Changed paths6 files
First-parent comparison
M packages/react-reconciler/src/ReactFiberCompleteWork.new.js ModifiedM packages/react-reconciler/src/ReactFiberCompleteWork.old.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseComponent.new.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseComponent.old.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseContext.new.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseContext.old.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…