{"body":"","parents":["f51abe0b552ceabfa926957337d182d6f7173344"],"files":[{"path":"src\/renderers\/shared\/stack\/reconciler\/__tests__\/ReactErrorBoundaries-test.js","status":"M"}],"patch":"diff --git a\/src\/renderers\/shared\/stack\/reconciler\/__tests__\/ReactErrorBoundaries-test.js b\/src\/renderers\/shared\/stack\/reconciler\/__tests__\/ReactErrorBoundaries-test.js\nindex e7475d5eef..658b76a1de 100644\n--- a\/src\/renderers\/shared\/stack\/reconciler\/__tests__\/ReactErrorBoundaries-test.js\n+++ b\/src\/renderers\/shared\/stack\/reconciler\/__tests__\/ReactErrorBoundaries-test.js\n@@ -196,7 +196,7 @@ describe('ReactErrorBoundaries', () => {\n \n BrokenComponentDidUpdate = class extends React.Component {\n static defaultProps = {\n- errorText: 'Hello'\n+ errorText: 'Hello',\n };\n constructor(props) {\n super(props);\n@@ -229,7 +229,7 @@ describe('ReactErrorBoundaries', () => {\n \n BrokenComponentWillUnmount = class extends React.Component {\n static defaultProps = {\n- errorText: 'Hello'\n+ errorText: 'Hello',\n };\n constructor(props) {\n super(props);\n@@ -502,6 +502,90 @@ describe('ReactErrorBoundaries', () => {\n };\n });\n \n+ it('does not swallow exceptions on mounting without boundaries', () => {\n+ var container = document.createElement('div');\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+\n+ container = document.createElement('div');\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+\n+ container = document.createElement('div');\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+ });\n+\n+ it('does not swallow exceptions on updating without boundaries', () => {\n+ var container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+\n+ container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+\n+ container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ expect(() => {\n+ ReactDOM.render(, container);\n+ }).toThrow('Hello');\n+ });\n+\n+ it('does not swallow exceptions on unmounting without boundaries', () => {\n+ var container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ expect(() => {\n+ ReactDOM.unmountComponentAtNode(container);\n+ }).toThrow('Hello');\n+ });\n+\n+ it('prevents errors from leaking into other roots', () => {\n+ var container1 = document.createElement('div');\n+ var container2 = document.createElement('div');\n+ var container3 = document.createElement('div');\n+\n+ ReactDOM.render(Before 1<\/span>, container1);\n+ expect(() => {\n+ ReactDOM.render(, container2);\n+ }).toThrow('Hello');\n+ ReactDOM.render(\n+ \n+ \n+ <\/ErrorBoundary>,\n+ container3\n+ );\n+ expect(container1.firstChild.textContent).toBe('Before 1');\n+ expect(container2.firstChild).toBe(null);\n+ expect(container3.firstChild.textContent).toBe('Caught an error: Hello.');\n+\n+ ReactDOM.render(After 1<\/span>, container1);\n+ ReactDOM.render(After 2<\/span>, container2);\n+ ReactDOM.render(\n+ \n+ After 3\n+ <\/ErrorBoundary>,\n+ container3\n+ );\n+ expect(container1.firstChild.textContent).toBe('After 1');\n+ expect(container2.firstChild.textContent).toBe('After 2');\n+ expect(container3.firstChild.textContent).toBe('After 3');\n+\n+ ReactDOM.unmountComponentAtNode(container1);\n+ ReactDOM.unmountComponentAtNode(container2);\n+ ReactDOM.unmountComponentAtNode(container3);\n+ expect(container1.firstChild).toBe(null);\n+ expect(container2.firstChild).toBe(null);\n+ expect(container3.firstChild).toBe(null);\n+ });\n+\n it('renders an error state if child throws in render', () => {\n var container = document.createElement('div');\n ReactDOM.render(\n","commit":{"authorName":"Dan Abramov","authorEmail":"dan.abramov@gmail.com","shortRevision":"c08469a7d6","authoredAt":"2016-10-28T19:23:35+01:00","revision":"c08469a7d6647fd1e4f0480713bdf2d9e49a719f","subject":"Add tests verifying we don't swallow exceptions"}}

dillon1000/react

Files changed