dillon1000/react

Commits/c7f1abade5

Commit

Stack and Fiber warn about missing getChildContext method

Previous (probably unintentional) behavior of Stack was to allow components to define childContextTypes without also supplying a getChildContext property. This PR updates Fiber to (temporarily) mimic that behavior. It also adds warning messages to both Fiber and Stack (along with a test).

For the time being, Fiber components with a missing getChildContext method will return the parent context as-is, after warning.

Browse files

Brian Vaughn authored 1/10/2017, 9:44:19 PM c7f1abade518c70a6386c15279054c2ed1abf2e8 Parent 199db63

Changed paths5 files

First-parent comparison

M scripts/fiber/tests-passing.txt Modified M src/isomorphic/classic/__tests__/ReactContextValidator-test.js Modified M src/renderers/shared/fiber/ReactFiberContext.js Modified M src/renderers/shared/shared/__tests__/ReactStatelessComponent-test.js Modified M src/renderers/shared/stack/reconciler/ReactCompositeComponent.js Modified

Patch

Files changed

Rendering syntax-highlighted changes…