dillon1000/react
Commit
Browse files Fix AMD and Brunch issues (#8686)
* Add manual build fixtures * Inject ReactDOM into ReactWithAddons from ReactWithAddons We used to read ReactDOM as a global inside ReactAddonsDOMDependenciesUMDShim. This didn't work in AMD environments such as RequireJS and SystemJS. Instead, I changed it so that ReactDOM gets injected into ReactWithAddons by ReactDOM itself. This way we don't have to try to require it (which wouldn't work because AMD doesn't handle circular dependencies well). This means you have to load ReactDOM first before using ReactDOM-dependent addons, but this was already the case before. This commit makes all build fixtures pass. * Memoize ReactDOM to avoid going into require on every access * Add Brunch fixture * Inline requires to work around Brunch bug See #8556 and https://github.com/brunch/brunch/issues/1591#issuecomment-270742503 for context. This appears to be a Brunch bug but we can keep a temporary fix until the next major.
Changed paths44 files
First-parent comparisonfixtures/README.md AddedA fixtures/browserify/.gitignore AddedA fixtures/browserify/index.html AddedA fixtures/browserify/input.js AddedA fixtures/browserify/package.json AddedA fixtures/brunch/.gitignore AddedA fixtures/brunch/app/initialize.js AddedA fixtures/brunch/config.js AddedA fixtures/brunch/index.html AddedA fixtures/brunch/input.js AddedA fixtures/brunch/package.json AddedA fixtures/build-all.js AddedA fixtures/globals.html AddedA fixtures/requirejs.html AddedA fixtures/rjs/.gitignore AddedA fixtures/rjs/config.js AddedA fixtures/rjs/index.html AddedA fixtures/rjs/input.js AddedA fixtures/rjs/package.json AddedA fixtures/systemjs-builder/.gitignore AddedA fixtures/systemjs-builder/build.js AddedA fixtures/systemjs-builder/config.js AddedA fixtures/systemjs-builder/index.html AddedA fixtures/systemjs-builder/input.js AddedA fixtures/systemjs-builder/package.json AddedA fixtures/systemjs.html AddedA fixtures/webpack-alias/.gitignore AddedA fixtures/webpack-alias/config.js AddedA fixtures/webpack-alias/index.html AddedA fixtures/webpack-alias/input.js AddedA fixtures/webpack-alias/package.json AddedA fixtures/webpack/.gitignore AddedA fixtures/webpack/config.js AddedA fixtures/webpack/index.html AddedA fixtures/webpack/input.js AddedA fixtures/webpack/package.json AddedM scripts/fiber/tests-passing-except-dev.txt ModifiedM scripts/fiber/tests-passing.txt ModifiedM src/addons/ReactAddonsDOMDependencies.js ModifiedM src/addons/transitions/ReactTransitionGroup.js ModifiedM src/addons/transitions/__tests__/ReactTransitionGroup-test.js ModifiedM src/umd/ReactDOMUMDEntry.js ModifiedM src/umd/ReactWithAddonsUMDEntry.js ModifiedM src/umd/shims/ReactAddonsDOMDependenciesUMDShim.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…