dillon1000/react

Commit

Fix switching between dangerouslySetInnerHTML and children

With this, ReactMultiChild handles all of the children-related operations for ReactDOMComponent so that we don't process operations out of order. This is necessary because ReactMultiChild does its own batching so there's no way without its cooperation to get the timing right here.

Ideally we'll factor this logic out a bit better in subsequent updates but this is the simplest way to fix #1232 which has embarrassingly been open for over a year.
Browse files
Changed paths8 files
First-parent comparison
M src/renderers/dom/client/ReactDOMIDOperations.js ModifiedM src/renderers/dom/client/__tests__/ReactDOMIDOperations-test.js ModifiedM src/renderers/dom/client/utils/DOMChildrenOperations.js ModifiedM src/renderers/dom/shared/ReactDOMComponent.js ModifiedM src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js ModifiedM src/renderers/shared/reconciler/ReactMultiChild.js ModifiedM src/renderers/shared/reconciler/ReactMultiChildUpdateTypes.js ModifiedM src/test/ReactDefaultPerfAnalysis.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…