dillon1000/react

Commit

fix(ServerRendering): execution should be sync

The documentation states that React.renderComponentToString
'uses a callback API to keep the API async', but the
implementation is actually synchronous. In order to maintain
this contract the callback should always be called
asynchronously or be change to a synchronous API.

As per the discussion of pull request 982, the API should
be changed to a synchronous one.
Browse files
Ben Ripkens authored cd2aecc3777d39a8844ab1f72fe6c40d65317872 Parent 526be15
Changed paths5 files
First-parent comparison
M CONTRIBUTING.md ModifiedM src/core/__tests__/ReactRenderDocument-test.js ModifiedM src/core/__tests__/ReactTextComponent-test.js ModifiedM src/environment/ReactServerRendering.js ModifiedM src/environment/__tests__/ReactServerRendering-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…