{"body":"","commit":{"subject":"Add more coverage for custom elements (#11811)","authorName":"Dan Abramov","shortRevision":"cda9fb0499","authorEmail":"dan.abramov@gmail.com","revision":"cda9fb04999bb0cc2dd148449748556464f3bf74","authoredAt":"2017-12-08T17:19:00+00:00"},"parents":["ac630e4a2f2a6e794c3f9858f606476147e735fd"],"files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\nindex 85fe8f949b..dc348cf4e0 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n@@ -2551,4 +2551,34 @@ describe('ReactDOMComponent', () => {\n }\n });\n });\n+\n+ \/\/ These tests mostly verify the existing behavior.\n+ \/\/ It may not always makes sense but we can't change it in minors.\n+ describe('Custom elements', () => {\n+ it('does not strip unknown boolean attributes', () => {\n+ const container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ const node = container.firstChild;\n+ expect(node.getAttribute('foo')).toBe('true');\n+ ReactDOM.render(, container);\n+ expect(node.getAttribute('foo')).toBe('false');\n+ ReactDOM.render(, container);\n+ expect(node.hasAttribute('foo')).toBe(false);\n+ ReactDOM.render(, container);\n+ expect(node.hasAttribute('foo')).toBe(true);\n+ });\n+\n+ it('does not strip the on* attributes', () => {\n+ const container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ const node = container.firstChild;\n+ expect(node.getAttribute('onx')).toBe('bar');\n+ ReactDOM.render(, container);\n+ expect(node.getAttribute('onx')).toBe('buzz');\n+ ReactDOM.render(, container);\n+ expect(node.hasAttribute('onx')).toBe(false);\n+ ReactDOM.render(, container);\n+ expect(node.getAttribute('onx')).toBe('bar');\n+ });\n+ });\n });\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\nindex c5ab8cae81..a6e52a1bb8 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\n@@ -213,16 +213,6 @@ describe('ReactDOMServerIntegration', () => {\n expect(e.className).toBe('test');\n },\n );\n-\n- itRenders('class for custom elements', async render => {\n- const e = await render(

, 0);\n- expect(e.getAttribute('class')).toBe('test');\n- });\n-\n- itRenders('className for custom elements', async render => {\n- const e = await render(

, 0);\n- expect(e.getAttribute('className')).toBe('test');\n- });\n });\n \n describe('htmlFor property', function() {\n@@ -256,16 +246,6 @@ describe('ReactDOMServerIntegration', () => {\n const e = await render(

);\n expect(e.hasAttribute('htmlFor')).toBe(false);\n });\n-\n- itRenders('htmlFor attribute on custom elements', async render => {\n- const e = await render(

);\n- expect(e.getAttribute('htmlFor')).toBe('test');\n- });\n-\n- itRenders('for attribute on custom elements', async render => {\n- const e = await render(

);\n- expect(e.getAttribute('for')).toBe('test');\n- });\n });\n \n describe('numeric properties', function() {\n@@ -529,35 +509,6 @@ describe('ReactDOMServerIntegration', () => {\n expect(e.getAttribute('foo')).toBe('bar');\n });\n \n- itRenders('unknown attributes for custom elements', async render => {\n- const e = await render();\n- expect(e.getAttribute('foo')).toBe('bar');\n- });\n-\n- itRenders(\n- 'no unknown attributes for custom elements with null value',\n- async render => {\n- const e = await render();\n- expect(e.hasAttribute('foo')).toBe(false);\n- },\n- );\n-\n- itRenders(\n- 'unknown attributes for custom elements using is',\n- async render => {\n- const e = await render(

);\n- expect(e.getAttribute('foo')).toBe('bar');\n- },\n- );\n-\n- itRenders(\n- 'no unknown attributes for custom elements using is with null value',\n- async render => {\n- const e = await render(

);\n- expect(e.hasAttribute('foo')).toBe(false);\n- },\n- );\n-\n itRenders('SVG tags with dashes in them', async render => {\n const e = await render(\n

, 0);\n+ expect(e.getAttribute('class')).toBe('test');\n+ });\n+\n+ itRenders('className for custom elements', async render => {\n+ const e = await render(

, 0);\n+ expect(e.getAttribute('className')).toBe('test');\n+ });\n+\n+ itRenders('htmlFor attribute on custom elements', async render => {\n+ const e = await render(

);\n+ expect(e.getAttribute('htmlFor')).toBe('test');\n+ });\n+\n+ itRenders('for attribute on custom elements', async render => {\n+ const e = await render(

);\n+ expect(e.getAttribute('for')).toBe('test');\n+ });\n+\n+ itRenders('unknown attributes for custom elements', async render => {\n+ const e = await render();\n+ expect(e.getAttribute('foo')).toBe('bar');\n+ });\n+\n+ itRenders('unknown `on*` attributes for custom elements', async render => {\n+ const e = await render();\n+ expect(e.getAttribute('onunknown')).toBe('bar');\n+ });\n+\n+ itRenders('unknown boolean `true` attributes as strings', async render => {\n+ const e = await render();\n+ expect(e.getAttribute('foo')).toBe('true');\n+ });\n+\n+ itRenders('unknown boolean `false` attributes as strings', async render => {\n+ const e = await render();\n+ expect(e.getAttribute('foo')).toBe('false');\n+ });\n+\n+ itRenders(\n+ 'no unknown attributes for custom elements with null value',\n+ async render => {\n+ const e = await render();\n+ expect(e.hasAttribute('foo')).toBe(false);\n+ },\n+ );\n+\n+ itRenders(\n+ 'unknown attributes for custom elements using is',\n+ async render => {\n+ const e = await render(

);\n+ expect(e.getAttribute('foo')).toBe('bar');\n+ },\n+ );\n+\n+ itRenders(\n+ 'no unknown attributes for custom elements using is with null value',\n+ async render => {\n+ const e = await render(

);\n+ expect(e.hasAttribute('foo')).toBe(false);\n+ },\n+ );\n+ });\n });\n"}

dillon1000/react

Files changed