dillon1000/react

Commit

Pass shouldHaveDebugID flag to instantiateComponent (#7193)

* Add failing tests for #7187 and #7190

* Pass shouldHaveDebugID flag to instantiateComponent

This allows us to remove a hack that was added in #6770 and caused #7187 and #7190.

* Move logic for choosing whether to use debugID outside instantiate
Browse files
Changed paths11 files
First-parent comparison
M src/isomorphic/devtools/ReactComponentTreeDevtool.js ModifiedM src/renderers/dom/client/ReactMount.js ModifiedM src/renderers/dom/server/ReactServerRendering.js ModifiedM src/renderers/native/ReactNativeMount.js ModifiedM src/renderers/shared/ReactDebugTool.js ModifiedM src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js ModifiedM src/renderers/shared/stack/reconciler/ReactChildReconciler.js ModifiedM src/renderers/shared/stack/reconciler/ReactCompositeComponent.js ModifiedM src/renderers/shared/stack/reconciler/ReactMultiChild.js ModifiedM src/renderers/shared/stack/reconciler/instantiateReactComponent.js ModifiedM src/renderers/testing/ReactTestMount.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…