dillon1000/react

Commit

Avoid meta programming to initialize functions in module scope (#26388)

I'm trying to get rid of all meta programming in the module scope so
that closure can do a better job figuring out cyclic dependencies and
ability to reorder.

This is converting a lot of the patterns that assign functions
conditionally to using function declarations instead.

```
let fn;
if (__DEV__) {
  fn = function() {
    ...
  };
}
```
->
```
function fn() {
  if (__DEV__) {
    ...
  }
}
```
Browse files
Changed paths24 files
First-parent comparison
M packages/dom-event-testing-library/domEnvironment.js ModifiedM packages/react-dom-bindings/src/client/ReactDOMComponent.js ModifiedD packages/react-dom-bindings/src/client/createMicrosoftUnsafeLocalFunction.js DeletedM packages/react-dom-bindings/src/client/setInnerHTML.js ModifiedM packages/react-dom-bindings/src/client/setTextContent.js ModifiedM packages/react-dom-bindings/src/client/validateDOMNesting.js ModifiedM packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js ModifiedM packages/react-dom-bindings/src/shared/warnValidStyle.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-native-renderer/src/ReactNativeEventEmitter.js ModifiedM packages/react-native-renderer/src/ReactNativeFiberInspector.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/deepDiffer.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/deepFreezeAndThrowOnMutationInDev.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/flattenStyle.js ModifiedM packages/react-native-renderer/src/legacy-events/EventBatching.js ModifiedM packages/react-native-renderer/src/legacy-events/EventPluginUtils.js ModifiedM packages/react-native-renderer/src/legacy-events/ResponderEventPlugin.js ModifiedM packages/react-reconciler/src/ReactFiber.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-server/src/ReactFizzClassComponent.js ModifiedM packages/react/src/ReactElement.js ModifiedM packages/react/src/jsx/ReactJSXElement.js ModifiedM packages/shared/forks/invokeGuardedCallbackImpl.www.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…