dillon1000/react
Commit
Browse files Validate callbacks just before they are invoked
This delays the type check until the point when the engine will have to perform a type check regardless. Because the error is now thrown during the commit phase rather than when the callback is originally scheduled, we warn in DEV when scheduling so it's easier to track down.
Changed paths9 files
First-parent comparisonsrc/renderers/__tests__/ReactUpdates-test.js ModifiedM src/renderers/dom/shared/__tests__/ReactDOM-test.js ModifiedM src/renderers/dom/stack/client/ReactMount.js ModifiedM src/renderers/shared/fiber/ReactFiberClassComponent.js ModifiedM src/renderers/shared/fiber/ReactFiberReconciler.js ModifiedM src/renderers/shared/fiber/ReactFiberUpdateQueue.js ModifiedM src/renderers/shared/stack/reconciler/CallbackQueue.js ModifiedM src/renderers/shared/stack/reconciler/ReactUpdateQueue.js ModifiedM src/renderers/shared/utils/validateCallback.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…