{"parents":["df10afba51cefad55ae2635cc3a60e5e59d84e43"],"files":[{"path":"src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap","status":"M"},{"path":"src\/__tests__\/profilingCharts-test.js","status":"M"}],"patch":"diff --git a\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap b\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\nindex 3e0539db75..3cfc8bdfc9 100644\n--- a\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\n+++ b\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\n@@ -11,18 +11,19 @@ Object {\n \"id\": 1,\n \"key\": null,\n \"parentID\": 0,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 2 => Object {\n \"children\": Array [\n 3,\n 4,\n+ 5,\n ],\n \"displayName\": \"Parent\",\n \"id\": 2,\n \"key\": null,\n \"parentID\": 1,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 3 => Object {\n \"children\": Array [],\n@@ -30,7 +31,7 @@ Object {\n \"id\": 3,\n \"key\": \"first\",\n \"parentID\": 2,\n- \"treeBaseDuration\": 2,\n+ \"treeBaseDuration\": 3,\n },\n 4 => Object {\n \"children\": Array [],\n@@ -40,6 +41,14 @@ Object {\n \"parentID\": 2,\n \"treeBaseDuration\": 2,\n },\n+ 5 => Object {\n+ \"children\": Array [],\n+ \"displayName\": \"Memo(Child)\",\n+ \"id\": 5,\n+ \"key\": \"third\",\n+ \"parentID\": 2,\n+ \"treeBaseDuration\": 0,\n+ },\n },\n \"rootID\": 1,\n }\n@@ -47,10 +56,11 @@ Object {\n \n exports[`profiling charts flamegraph chart should contain valid data: 0: FlamegraphChartData 1`] = `\n Object {\n- \"baseDuration\": 14,\n+ \"baseDuration\": 15,\n \"depth\": 2,\n \"idToDepthMap\": Map {\n 2 => 1,\n+ 5 => 2,\n 4 => 2,\n 3 => 2,\n },\n@@ -58,36 +68,46 @@ Object {\n \"rows\": Array [\n Array [\n Object {\n- \"actualDuration\": 14,\n+ \"actualDuration\": 15,\n \"didRender\": true,\n \"id\": 2,\n- \"label\": \"Parent (10ms of 14ms)\",\n+ \"label\": \"Parent (10ms of 15ms)\",\n \"name\": \"Parent\",\n \"offset\": 0,\n \"selfDuration\": 10,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n ],\n Array [\n+ Object {\n+ \"actualDuration\": 0,\n+ \"didRender\": false,\n+ \"id\": 5,\n+ \"label\": \"Memo(Child) key=\\\\\"third\\\\\"\",\n+ \"name\": \"Memo(Child)\",\n+ \"offset\": 15,\n+ \"selfDuration\": 0,\n+ \"treeBaseDuration\": 0,\n+ },\n Object {\n \"actualDuration\": 2,\n \"didRender\": true,\n \"id\": 4,\n \"label\": \"Memo(Child) key=\\\\\"second\\\\\" (2ms of 2ms)\",\n \"name\": \"Memo(Child)\",\n- \"offset\": 12,\n+ \"offset\": 13,\n \"selfDuration\": 2,\n \"treeBaseDuration\": 2,\n },\n Object {\n- \"actualDuration\": 2,\n+ \"actualDuration\": 3,\n \"didRender\": true,\n \"id\": 3,\n- \"label\": \"Memo(Child) key=\\\\\"first\\\\\" (2ms of 2ms)\",\n+ \"label\": \"Memo(Child) key=\\\\\"first\\\\\" (3ms of 3ms)\",\n \"name\": \"Memo(Child)\",\n \"offset\": 10,\n- \"selfDuration\": 2,\n- \"treeBaseDuration\": 2,\n+ \"selfDuration\": 3,\n+ \"treeBaseDuration\": 3,\n },\n ],\n ],\n@@ -105,18 +125,19 @@ Object {\n \"id\": 1,\n \"key\": null,\n \"parentID\": 0,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 2 => Object {\n \"children\": Array [\n 3,\n 4,\n+ 5,\n ],\n \"displayName\": \"Parent\",\n \"id\": 2,\n \"key\": null,\n \"parentID\": 1,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 3 => Object {\n \"children\": Array [],\n@@ -124,7 +145,7 @@ Object {\n \"id\": 3,\n \"key\": \"first\",\n \"parentID\": 2,\n- \"treeBaseDuration\": 2,\n+ \"treeBaseDuration\": 3,\n },\n 4 => Object {\n \"children\": Array [],\n@@ -134,6 +155,14 @@ Object {\n \"parentID\": 2,\n \"treeBaseDuration\": 2,\n },\n+ 5 => Object {\n+ \"children\": Array [],\n+ \"displayName\": \"Memo(Child)\",\n+ \"id\": 5,\n+ \"key\": \"third\",\n+ \"parentID\": 2,\n+ \"treeBaseDuration\": 0,\n+ },\n },\n \"rootID\": 1,\n }\n@@ -141,10 +170,11 @@ Object {\n \n exports[`profiling charts flamegraph chart should contain valid data: 1: FlamegraphChartData 1`] = `\n Object {\n- \"baseDuration\": 14,\n+ \"baseDuration\": 15,\n \"depth\": 2,\n \"idToDepthMap\": Map {\n 2 => 1,\n+ 5 => 2,\n 4 => 2,\n 3 => 2,\n },\n@@ -159,17 +189,27 @@ Object {\n \"name\": \"Parent\",\n \"offset\": 0,\n \"selfDuration\": 10,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n ],\n Array [\n+ Object {\n+ \"actualDuration\": 0,\n+ \"didRender\": false,\n+ \"id\": 5,\n+ \"label\": \"Memo(Child) key=\\\\\"third\\\\\"\",\n+ \"name\": \"Memo(Child)\",\n+ \"offset\": 15,\n+ \"selfDuration\": 0,\n+ \"treeBaseDuration\": 0,\n+ },\n Object {\n \"actualDuration\": 0,\n \"didRender\": false,\n \"id\": 4,\n \"label\": \"Memo(Child) key=\\\\\"second\\\\\"\",\n \"name\": \"Memo(Child)\",\n- \"offset\": 12,\n+ \"offset\": 13,\n \"selfDuration\": 0,\n \"treeBaseDuration\": 2,\n },\n@@ -181,7 +221,7 @@ Object {\n \"name\": \"Memo(Child)\",\n \"offset\": 10,\n \"selfDuration\": 0,\n- \"treeBaseDuration\": 2,\n+ \"treeBaseDuration\": 3,\n },\n ],\n ],\n@@ -190,15 +230,15 @@ Object {\n \n exports[`profiling charts interactions should contain valid data: Interactions 1`] = `\n Object {\n- \"lastInteractionTime\": 24,\n- \"maxCommitDuration\": 14,\n+ \"lastInteractionTime\": 25,\n+ \"maxCommitDuration\": 15,\n }\n `;\n \n exports[`profiling charts interactions should contain valid data: Interactions 2`] = `\n Object {\n- \"lastInteractionTime\": 24,\n- \"maxCommitDuration\": 14,\n+ \"lastInteractionTime\": 25,\n+ \"maxCommitDuration\": 15,\n }\n `;\n \n@@ -213,18 +253,19 @@ Object {\n \"id\": 1,\n \"key\": null,\n \"parentID\": 0,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 2 => Object {\n \"children\": Array [\n 3,\n 4,\n+ 5,\n ],\n \"displayName\": \"Parent\",\n \"id\": 2,\n \"key\": null,\n \"parentID\": 1,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 3 => Object {\n \"children\": Array [],\n@@ -232,7 +273,7 @@ Object {\n \"id\": 3,\n \"key\": \"first\",\n \"parentID\": 2,\n- \"treeBaseDuration\": 2,\n+ \"treeBaseDuration\": 3,\n },\n 4 => Object {\n \"children\": Array [],\n@@ -242,6 +283,14 @@ Object {\n \"parentID\": 2,\n \"treeBaseDuration\": 2,\n },\n+ 5 => Object {\n+ \"children\": Array [],\n+ \"displayName\": \"Memo(Child)\",\n+ \"id\": 5,\n+ \"key\": \"third\",\n+ \"parentID\": 2,\n+ \"treeBaseDuration\": 0,\n+ },\n },\n \"rootID\": 1,\n }\n@@ -259,9 +308,9 @@ Object {\n },\n Object {\n \"id\": 3,\n- \"label\": \"Memo(Child) key=\\\\\"first\\\\\" (2ms)\",\n+ \"label\": \"Memo(Child) key=\\\\\"first\\\\\" (3ms)\",\n \"name\": \"Memo(Child)\",\n- \"value\": 2,\n+ \"value\": 3,\n },\n Object {\n \"id\": 4,\n@@ -284,18 +333,19 @@ Object {\n \"id\": 1,\n \"key\": null,\n \"parentID\": 0,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 2 => Object {\n \"children\": Array [\n 3,\n 4,\n+ 5,\n ],\n \"displayName\": \"Parent\",\n \"id\": 2,\n \"key\": null,\n \"parentID\": 1,\n- \"treeBaseDuration\": 14,\n+ \"treeBaseDuration\": 15,\n },\n 3 => Object {\n \"children\": Array [],\n@@ -303,7 +353,7 @@ Object {\n \"id\": 3,\n \"key\": \"first\",\n \"parentID\": 2,\n- \"treeBaseDuration\": 2,\n+ \"treeBaseDuration\": 3,\n },\n 4 => Object {\n \"children\": Array [],\n@@ -313,6 +363,14 @@ Object {\n \"parentID\": 2,\n \"treeBaseDuration\": 2,\n },\n+ 5 => Object {\n+ \"children\": Array [],\n+ \"displayName\": \"Memo(Child)\",\n+ \"id\": 5,\n+ \"key\": \"third\",\n+ \"parentID\": 2,\n+ \"treeBaseDuration\": 0,\n+ },\n },\n \"rootID\": 1,\n }\ndiff --git a\/src\/__tests__\/profilingCharts-test.js b\/src\/__tests__\/profilingCharts-test.js\nindex 3e2613b5af..46901444ee 100644\n--- a\/src\/__tests__\/profilingCharts-test.js\n+++ b\/src\/__tests__\/profilingCharts-test.js\n@@ -32,15 +32,16 @@ describe('profiling charts', () => {\n Scheduler.advanceTime(10);\n return (\n \n- \n- \n+ \n+ \n+ \n <\/React.Fragment>\n );\n };\n \n \/\/ Memoize children to verify that chart doesn't include in the update.\n- const Child = React.memo(function Child() {\n- Scheduler.advanceTime(2);\n+ const Child = React.memo(function Child({ duration }) {\n+ Scheduler.advanceTime(duration);\n return null;\n });\n \n@@ -125,15 +126,16 @@ describe('profiling charts', () => {\n Scheduler.advanceTime(10);\n return (\n \n- \n- \n+ \n+ \n+ \n <\/React.Fragment>\n );\n };\n \n \/\/ Memoize children to verify that chart doesn't include in the update.\n- const Child = React.memo(function Child() {\n- Scheduler.advanceTime(2);\n+ const Child = React.memo(function Child({ duration }) {\n+ Scheduler.advanceTime(duration);\n return null;\n });\n \n@@ -214,15 +216,16 @@ describe('profiling charts', () => {\n Scheduler.advanceTime(10);\n return (\n \n- \n- \n+ \n+ \n+ \n <\/React.Fragment>\n );\n };\n \n \/\/ Memoize children to verify that chart doesn't include in the update.\n- const Child = React.memo(function Child() {\n- Scheduler.advanceTime(2);\n+ const Child = React.memo(function Child({ duration }) {\n+ Scheduler.advanceTime(duration);\n return null;\n });\n \n","commit":{"authoredAt":"2019-05-08T14:35:43-07:00","authorName":"Brian Vaughn","subject":"Updated Profiling chart tests to cover components with duration=0","shortRevision":"d42f86bb50","revision":"d42f86bb50e5b49edf05e8e51f043f6b7c3d46f8","authorEmail":"bvaughn@fb.com"},"body":""}

dillon1000/react

Files changed