dillon1000/react

Commits/d44538ad96

Commit

Stop passing NodePaths to CompilerError

This was causing issues in various places where errors would be stringified. 
Because the inner detail objects would contain a NodePath with circular 
structures this would cause a JSON.stringify error in code outside of our 
control. This change makes it so we always print the codeframe from the NodePath 
and then passing the string.

Browse files

Lauren Tan authored 1/26/2023, 6:58:56 PM d44538ad9654e048e5cfb53e874265bbf77a4391 Parent 4ab8cc6

Changed paths5 files

First-parent comparison

M compiler/forget/packages/playground/lib/forgetMonacoDiagnostics.ts Modified M compiler/forget/src/CompilerError.ts Modified M compiler/forget/src/HIR/BuildHIR.ts Modified M compiler/forget/src/HIR/HIRBuilder.ts Modified M compiler/forget/src/__tests__/hir-test.ts Modified

Patch

Files changed

Rendering syntax-highlighted changes…