dillon1000/react
Commit
Browse files Fix assignment expression with context variables
Fixes the one case discovered in the previous PR; for AssignmentExpression we correctly lowered the store instruction to a local/context, but then always used a `LoadLocal` to read the result back. The load instruction appears like it might be dangling - i think what was happening is that DCE cleaned up the unused LoadLocal whereas it leaves the LoadContext alone. But this works for now, we can always clean up the extra instruction later since this case isn't too common.
Changed paths4 files
First-parent comparisoncompiler/packages/babel-plugin-react-forget/src/HIR/BuildHIR.ts ModifiedD compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-repro-scope-missing-mutable-range.expect.md DeletedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/repro-scope-missing-mutable-range.expect.md AddedR compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-repro-scope-missing-mutable-range.js →compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/repro-scope-missing-mutable-range.js RenamedPatch
Files changed
Rendering syntax-highlighted changes…