{"patch":"diff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/Entrypoint\/Pipeline.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/Entrypoint\/Pipeline.ts\nindex 8711b251ea..1c96e65c71 100644\n--- a\/compiler\/packages\/babel-plugin-react-compiler\/src\/Entrypoint\/Pipeline.ts\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/Entrypoint\/Pipeline.ts\n@@ -452,17 +452,17 @@ function* runWithEnvironment(\n value: reactiveFunction,\n });\n \n- promoteUsedTemporaries(reactiveFunction);\n+ pruneUnusedLValues(reactiveFunction);\n yield log({\n kind: 'reactive',\n- name: 'PromoteUsedTemporaries',\n+ name: 'PruneUnusedLValues',\n value: reactiveFunction,\n });\n \n- pruneUnusedLValues(reactiveFunction);\n+ promoteUsedTemporaries(reactiveFunction);\n yield log({\n kind: 'reactive',\n- name: 'PruneUnusedLValues',\n+ name: 'PromoteUsedTemporaries',\n value: reactiveFunction,\n });\n \ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/CodegenReactiveFunction.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\nindex 978596dc67..bd3e97f23a 100644\n--- a\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n@@ -1209,7 +1209,7 @@ function codegenInstructionNullable(\n value = null;\n } else {\n lvalue = instr.value.lvalue.pattern;\n- let hasReasign = false;\n+ let hasReassign = false;\n let hasDeclaration = false;\n for (const place of eachPatternOperand(lvalue)) {\n if (\n@@ -1219,10 +1219,10 @@ function codegenInstructionNullable(\n cx.temp.set(place.identifier.declarationId, null);\n }\n const isDeclared = cx.hasDeclared(place.identifier);\n- hasReasign ||= isDeclared;\n+ hasReassign ||= isDeclared;\n hasDeclaration ||= !isDeclared;\n }\n- if (hasReasign && hasDeclaration) {\n+ if (hasReassign && hasDeclaration) {\n CompilerError.invariant(false, {\n reason:\n 'Encountered a destructuring operation where some identifiers are already declared (reassignments) but others are not (declarations)',\n@@ -1230,7 +1230,7 @@ function codegenInstructionNullable(\n loc: instr.loc,\n suggestions: null,\n });\n- } else if (hasReasign) {\n+ } else if (hasReassign) {\n kind = InstructionKind.Reassign;\n }\n value = codegenPlaceToExpression(cx, instr.value.value);\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts\nindex d897b924ce..12cbde01b2 100644\n--- a\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts\n@@ -15,13 +15,17 @@ import {\n PrunedReactiveScopeBlock,\n ReactiveFunction,\n ReactiveScope,\n+ ReactiveInstruction,\n ReactiveScopeBlock,\n ReactiveValue,\n ScopeId,\n+ SpreadPattern,\n promoteTemporary,\n promoteTemporaryJsxTag,\n+ IdentifierId,\n } from '..\/HIR\/HIR';\n import {ReactiveFunctionVisitor, visitReactiveFunction} from '.\/visitors';\n+import {eachInstructionValueLValue, eachPatternOperand} from '..\/HIR\/visitors';\n \n \/**\n * Phase 2: Promote identifiers which are used in a place that requires a named variable.\n@@ -225,6 +229,199 @@ class CollectPromotableTemporaries extends ReactiveFunctionVisitor {\n }\n }\n \n+type InterState = Map;\n+class PromoteInterposedTemporaries extends ReactiveFunctionVisitor {\n+ #promotable: State;\n+ #consts: Set = new Set();\n+ #globals: Set = new Set();\n+\n+ \/*\n+ * Unpromoted temporaries will be emitted at their use sites rather than as separate\n+ * declarations. However, this causes errors if an interposing temporary has been\n+ * promoted, or if an interposing instruction has had its lvalues deleted, because such\n+ * temporaries will be emitted as separate statements, which can effectively cause\n+ * code to be reordered, and when that code has side effects that changes program behavior.\n+ * This visitor promotes temporarties that have such interposing instructions to preserve\n+ * source ordering.\n+ *\/\n+ constructor(promotable: State, params: Array) {\n+ super();\n+ params.forEach(param => {\n+ switch (param.kind) {\n+ case 'Identifier':\n+ this.#consts.add(param.identifier.id);\n+ break;\n+ case 'Spread':\n+ this.#consts.add(param.place.identifier.id);\n+ break;\n+ }\n+ });\n+ this.#promotable = promotable;\n+ }\n+\n+ override visitPlace(\n+ _id: InstructionId,\n+ place: Place,\n+ state: InterState,\n+ ): void {\n+ const promo = state.get(place.identifier.id);\n+ if (promo) {\n+ const [identifier, needsPromotion] = promo;\n+ if (\n+ needsPromotion &&\n+ identifier.name === null &&\n+ !this.#consts.has(identifier.id)\n+ ) {\n+ \/*\n+ * If the identifier hasn't been promoted but is marked as needing\n+ * promotion by the logic in `visitInstruction`, and we've seen a\n+ * use of it after said marking, promote it\n+ *\/\n+ promoteIdentifier(identifier, this.#promotable);\n+ }\n+ }\n+ }\n+\n+ override visitInstruction(\n+ instruction: ReactiveInstruction,\n+ state: InterState,\n+ ): void {\n+ for (const lval of eachInstructionValueLValue(instruction.value)) {\n+ CompilerError.invariant(lval.identifier.name != null, {\n+ reason:\n+ 'PromoteInterposedTemporaries: Assignment targets not expected to be temporaries',\n+ loc: instruction.loc,\n+ });\n+ }\n+\n+ switch (instruction.value.kind) {\n+ case 'CallExpression':\n+ case 'MethodCall':\n+ case 'Await':\n+ case 'PropertyStore':\n+ case 'PropertyDelete':\n+ case 'ComputedStore':\n+ case 'ComputedDelete':\n+ case 'PostfixUpdate':\n+ case 'PrefixUpdate':\n+ case 'StoreLocal':\n+ case 'StoreContext':\n+ case 'StoreGlobal':\n+ case 'Destructure': {\n+ let constStore = false;\n+\n+ if (\n+ (instruction.value.kind === 'StoreContext' ||\n+ instruction.value.kind === 'StoreLocal') &&\n+ (instruction.value.lvalue.kind === 'Const' ||\n+ instruction.value.lvalue.kind === 'HoistedConst')\n+ ) {\n+ \/*\n+ * If an identifier is const, we don't need to worry about it\n+ * being mutated between being loaded and being used\n+ *\/\n+ this.#consts.add(instruction.value.lvalue.place.identifier.id);\n+ constStore = true;\n+ }\n+ if (\n+ instruction.value.kind === 'Destructure' &&\n+ (instruction.value.lvalue.kind === 'Const' ||\n+ instruction.value.lvalue.kind === 'HoistedConst')\n+ ) {\n+ [...eachPatternOperand(instruction.value.lvalue.pattern)].forEach(\n+ ident => this.#consts.add(ident.identifier.id),\n+ );\n+ constStore = true;\n+ }\n+ if (instruction.value.kind === 'MethodCall') {\n+ \/\/ Treat property of method call as constlike so we don't promote it.\n+ this.#consts.add(instruction.value.property.identifier.id);\n+ }\n+\n+ super.visitInstruction(instruction, state);\n+ if (\n+ !constStore &&\n+ (instruction.lvalue == null ||\n+ instruction.lvalue.identifier.name != null)\n+ ) {\n+ \/*\n+ * If we've stripped the lvalue or promoted the lvalue, then we will emit this instruction\n+ * as a statement in codegen.\n+ *\n+ * If this instruction will be emitted directly as a statement rather than as a temporary\n+ * during codegen, then it can interpose between the defs and the uses of other temporaries.\n+ * Since this instruction could potentially mutate those defs, it's not safe to relocate\n+ * the definition of those temporaries to after this instruction. Mark all those temporaries\n+ * as needing promotion, but don't promote them until we actually see them being used.\n+ *\/\n+ for (const [key, [ident, _]] of state.entries()) {\n+ state.set(key, [ident, true]);\n+ }\n+ }\n+ if (instruction.lvalue && instruction.lvalue.identifier.name === null) {\n+ \/\/ Add this instruction's lvalue to the state, initially not marked as needing promotion\n+ state.set(instruction.lvalue.identifier.id, [\n+ instruction.lvalue.identifier,\n+ false,\n+ ]);\n+ }\n+ break;\n+ }\n+ case 'DeclareContext':\n+ case 'DeclareLocal': {\n+ if (\n+ instruction.value.lvalue.kind === 'Const' ||\n+ instruction.value.lvalue.kind === 'HoistedConst'\n+ ) {\n+ this.#consts.add(instruction.value.lvalue.place.identifier.id);\n+ }\n+ super.visitInstruction(instruction, state);\n+ break;\n+ }\n+ case 'LoadContext':\n+ case 'LoadLocal': {\n+ if (instruction.lvalue && instruction.lvalue.identifier.name === null) {\n+ if (this.#consts.has(instruction.value.place.identifier.id)) {\n+ this.#consts.add(instruction.lvalue.identifier.id);\n+ }\n+ state.set(instruction.lvalue.identifier.id, [\n+ instruction.lvalue.identifier,\n+ false,\n+ ]);\n+ }\n+ super.visitInstruction(instruction, state);\n+ break;\n+ }\n+ case 'PropertyLoad':\n+ case 'ComputedLoad': {\n+ if (instruction.lvalue) {\n+ if (this.#globals.has(instruction.value.object.identifier.id)) {\n+ this.#globals.add(instruction.lvalue.identifier.id);\n+ this.#consts.add(instruction.lvalue.identifier.id);\n+ }\n+ if (instruction.lvalue.identifier.name === null) {\n+ state.set(instruction.lvalue.identifier.id, [\n+ instruction.lvalue.identifier,\n+ false,\n+ ]);\n+ }\n+ }\n+ super.visitInstruction(instruction, state);\n+ break;\n+ }\n+ case 'LoadGlobal': {\n+ instruction.lvalue &&\n+ this.#globals.add(instruction.lvalue.identifier.id);\n+ super.visitInstruction(instruction, state);\n+ break;\n+ }\n+ default: {\n+ super.visitInstruction(instruction, state);\n+ }\n+ }\n+ }\n+}\n+\n export function promoteUsedTemporaries(fn: ReactiveFunction): void {\n const state: State = {\n tags: new Set(),\n@@ -239,6 +436,12 @@ export function promoteUsedTemporaries(fn: ReactiveFunction): void {\n }\n }\n visitReactiveFunction(fn, new PromoteTemporaries(), state);\n+\n+ visitReactiveFunction(\n+ fn,\n+ new PromoteInterposedTemporaries(state, fn.params),\n+ new Map(),\n+ );\n visitReactiveFunction(\n fn,\n new PromoteAllInstancedOfPromotedTemporaries(),\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.expect.md b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.expect.md\ndeleted file mode 100644\nindex 4d36117ec7..0000000000\n--- a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.expect.md\n+++ \/dev\/null\n@@ -1,92 +0,0 @@\n-\n-## Input\n-\n-```javascript\n-import {makeArray, print} from 'shared-runtime';\n-\n-\/**\n- * Exposes bug involving iife inlining + codegen.\n- * We currently inline iifes to labeled blocks (not value-blocks).\n- *\n- * Here, print(1) and the evaluation of makeArray(...) get the same scope\n- * as the compiler infers that the makeArray call may mutate its arguments.\n- * Since print(1) does not get its own scope (and is thus not a declaration\n- * or dependency), it does not get promoted.\n- * As a result, print(1) gets reordered across the labeled-block instructions\n- * to be inlined at the makeArray callsite.\n- *\n- * Current evaluator results:\n- * Found differences in evaluator results\n- * Non-forget (expected):\n- * (kind: ok) [null,2]\n- * logs: [1,2]\n- * Forget:\n- * (kind: ok) [null,2]\n- * logs: [2,1]\n- *\/\n-function useTest() {\n- return makeArray(\n- print(1),\n- (function foo() {\n- print(2);\n- return 2;\n- })(),\n- );\n-}\n-\n-export const FIXTURE_ENTRYPOINT = {\n- fn: useTest,\n- params: [],\n-};\n-\n-```\n-\n-## Code\n-\n-```javascript\n-import { c as _c } from \"react\/compiler-runtime\";\n-import { makeArray, print } from \"shared-runtime\";\n-\n-\/**\n- * Exposes bug involving iife inlining + codegen.\n- * We currently inline iifes to labeled blocks (not value-blocks).\n- *\n- * Here, print(1) and the evaluation of makeArray(...) get the same scope\n- * as the compiler infers that the makeArray call may mutate its arguments.\n- * Since print(1) does not get its own scope (and is thus not a declaration\n- * or dependency), it does not get promoted.\n- * As a result, print(1) gets reordered across the labeled-block instructions\n- * to be inlined at the makeArray callsite.\n- *\n- * Current evaluator results:\n- * Found differences in evaluator results\n- * Non-forget (expected):\n- * (kind: ok) [null,2]\n- * logs: [1,2]\n- * Forget:\n- * (kind: ok) [null,2]\n- * logs: [2,1]\n- *\/\n-function useTest() {\n- const $ = _c(1);\n- let t0;\n- if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n- let t1;\n-\n- print(2);\n- t1 = 2;\n- t0 = makeArray(print(1), t1);\n- $[0] = t0;\n- } else {\n- t0 = $[0];\n- }\n- return t0;\n-}\n-\n-export const FIXTURE_ENTRYPOINT = {\n- fn: useTest,\n- params: [],\n-};\n-\n-```\n- \n\\ No newline at end of file\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.ts\ndeleted file mode 100644\nindex 0aa4a95bd5..0000000000\n--- a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.ts\n+++ \/dev\/null\n@@ -1,36 +0,0 @@\n-import {makeArray, print} from 'shared-runtime';\n-\n-\/**\n- * Exposes bug involving iife inlining + codegen.\n- * We currently inline iifes to labeled blocks (not value-blocks).\n- *\n- * Here, print(1) and the evaluation of makeArray(...) get the same scope\n- * as the compiler infers that the makeArray call may mutate its arguments.\n- * Since print(1) does not get its own scope (and is thus not a declaration\n- * or dependency), it does not get promoted.\n- * As a result, print(1) gets reordered across the labeled-block instructions\n- * to be inlined at the makeArray callsite.\n- *\n- * Current evaluator results:\n- * Found differences in evaluator results\n- * Non-forget (expected):\n- * (kind: ok) [null,2]\n- * logs: [1,2]\n- * Forget:\n- * (kind: ok) [null,2]\n- * logs: [2,1]\n- *\/\n-function useTest() {\n- return makeArray(\n- print(1),\n- (function foo() {\n- print(2);\n- return 2;\n- })(),\n- );\n-}\n-\n-export const FIXTURE_ENTRYPOINT = {\n- fn: useTest,\n- params: [],\n-};\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.expect.md b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.expect.md\nnew file mode 100644\nindex 0000000000..d17c934b3b\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.expect.md\n@@ -0,0 +1,62 @@\n+\n+## Input\n+\n+```javascript\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ let w = {};\n+ return makeArray(\n+ (w = 42),\n+ w,\n+ (function foo() {\n+ w = 999;\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+\n+## Code\n+\n+```javascript\n+import { c as _c } from \"react\/compiler-runtime\";\n+import { makeArray, print } from \"shared-runtime\";\n+\n+function useTest() {\n+ const $ = _c(1);\n+ let t0;\n+ if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ let w;\n+ w = {};\n+\n+ const t1 = (w = 42);\n+ const t2 = w;\n+\n+ w;\n+ let t3;\n+ w = 999;\n+ t3 = 2;\n+ t0 = makeArray(t1, t2, t3);\n+ $[0] = t0;\n+ } else {\n+ t0 = $[0];\n+ }\n+ return t0;\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+ \n+### Eval output\n+(kind: ok) [42,42,2]\n\\ No newline at end of file\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.ts\nnew file mode 100644\nindex 0000000000..8dd93a8482\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.ts\n@@ -0,0 +1,18 @@\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ let w = {};\n+ return makeArray(\n+ (w = 42),\n+ w,\n+ (function foo() {\n+ w = 999;\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.expect.md b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.expect.md\nnew file mode 100644\nindex 0000000000..58c54ddaab\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.expect.md\n@@ -0,0 +1,60 @@\n+\n+## Input\n+\n+```javascript\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ let w = {};\n+ return makeArray(\n+ (w.x = 42),\n+ w.x,\n+ (function foo() {\n+ w.x = 999;\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+\n+## Code\n+\n+```javascript\n+import { c as _c } from \"react\/compiler-runtime\";\n+import { makeArray, print } from \"shared-runtime\";\n+\n+function useTest() {\n+ const $ = _c(1);\n+ let t0;\n+ if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ const w = {};\n+\n+ const t1 = (w.x = 42);\n+ const t2 = w.x;\n+ let t3;\n+\n+ w.x = 999;\n+ t3 = 2;\n+ t0 = makeArray(t1, t2, t3);\n+ $[0] = t0;\n+ } else {\n+ t0 = $[0];\n+ }\n+ return t0;\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+ \n+### Eval output\n+(kind: ok) [42,42,2]\n\\ No newline at end of file\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.ts\nnew file mode 100644\nindex 0000000000..1b9f10856e\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.ts\n@@ -0,0 +1,18 @@\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ let w = {};\n+ return makeArray(\n+ (w.x = 42),\n+ w.x,\n+ (function foo() {\n+ w.x = 999;\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.expect.md b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.expect.md\nnew file mode 100644\nindex 0000000000..25a08bc332\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.expect.md\n@@ -0,0 +1,56 @@\n+\n+## Input\n+\n+```javascript\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ return makeArray(\n+ print(1),\n+ (function foo() {\n+ print(2);\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+\n+## Code\n+\n+```javascript\n+import { c as _c } from \"react\/compiler-runtime\";\n+import { makeArray, print } from \"shared-runtime\";\n+\n+function useTest() {\n+ const $ = _c(1);\n+ let t0;\n+ if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ const t1 = print(1);\n+ let t2;\n+\n+ print(2);\n+ t2 = 2;\n+ t0 = makeArray(t1, t2);\n+ $[0] = t0;\n+ } else {\n+ t0 = $[0];\n+ }\n+ return t0;\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n+\n+```\n+ \n+### Eval output\n+(kind: ok) [null,2]\n+logs: [1,2]\n\\ No newline at end of file\ndiff --git a\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.ts b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.ts\nnew file mode 100644\nindex 0000000000..52b1e8a927\n--- \/dev\/null\n+++ b\/compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.ts\n@@ -0,0 +1,16 @@\n+import {makeArray, print} from 'shared-runtime';\n+\n+function useTest() {\n+ return makeArray(\n+ print(1),\n+ (function foo() {\n+ print(2);\n+ return 2;\n+ })(),\n+ );\n+}\n+\n+export const FIXTURE_ENTRYPOINT = {\n+ fn: useTest,\n+ params: [],\n+};\n","files":[{"status":"M","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/Entrypoint\/Pipeline.ts"},{"status":"M","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/CodegenReactiveFunction.ts"},{"status":"M","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts"},{"status":"D","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.expect.md"},{"status":"D","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/bug-codegen-inline-iife.ts"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.expect.md"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-reassign.ts"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.expect.md"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife-storeprop.ts"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.expect.md"},{"status":"A","path":"compiler\/packages\/babel-plugin-react-compiler\/src\/__tests__\/fixtures\/compiler\/codegen-inline-iife.ts"}],"commit":{"authorName":"Mike Vitousek","authorEmail":"mmvitousek@gmail.com","authoredAt":"2024-08-12T12:36:49-07:00","subject":"[compiler] Promote temporaries when necessary to prevent codegen reordering over side-effectful operations","shortRevision":"d50e024fd4","revision":"d50e024fd49cbd701e7e286441ef2b6b0b59ba62"},"parents":["fbe81b214a474f0c7b6512dbfe8a9e3948e5620a"],"body":"ghstack-source-id: 639191e63a0d2b4290d1265a2da12fb17de750d9\nPull Request resolved: https:\/\/github.com\/facebook\/react\/pull\/30554"}

dillon1000/react

Files changed